From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id uDNqCaTSIGK2PgAAgWs5BA (envelope-from ) for ; Thu, 03 Mar 2022 15:37:24 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 6Fx3AqTSIGK4oAAAG6o9tA (envelope-from ) for ; Thu, 03 Mar 2022 15:37:24 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A1ADC3D3D2 for ; Thu, 3 Mar 2022 15:37:23 +0100 (CET) Received: from localhost ([::1]:49382 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nPma2-00031u-BP for larch@yhetil.org; Thu, 03 Mar 2022 09:37:22 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33462) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nPmZi-0002z8-W0 for guix-patches@gnu.org; Thu, 03 Mar 2022 09:37:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:48096) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nPmZi-0003CL-Ne for guix-patches@gnu.org; Thu, 03 Mar 2022 09:37:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nPmZi-0007s4-JQ for guix-patches@gnu.org; Thu, 03 Mar 2022 09:37:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#54216] [PATCH staging] gnu: shepherd: Build it from git, and clean up shepherd-for-guix. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 03 Mar 2022 14:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54216 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun Cc: 54216@debbugs.gnu.org Received: via spool by 54216-submit@debbugs.gnu.org id=B54216.164631821830244 (code B ref 54216); Thu, 03 Mar 2022 14:37:02 +0000 Received: (at 54216) by debbugs.gnu.org; 3 Mar 2022 14:36:58 +0000 Received: from localhost ([127.0.0.1]:41993 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPmZd-0007rk-Vb for submit@debbugs.gnu.org; Thu, 03 Mar 2022 09:36:58 -0500 Received: from michel.telenet-ops.be ([195.130.137.88]:50232) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPmZb-0007rX-9u for 54216@debbugs.gnu.org; Thu, 03 Mar 2022 09:36:56 -0500 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by michel.telenet-ops.be with bizsmtp id 1qct2700V4UW6Th06qctNX; Thu, 03 Mar 2022 15:36:53 +0100 Message-ID: From: Maxime Devos Date: Thu, 03 Mar 2022 15:36:53 +0100 In-Reply-To: References: <20220301182848.26694-1-attila@lendvai.name> <20220301184517.13439-1-attila@lendvai.name> <992c3326a10e0bb28491f8226ebbe84aa93ad9ca.camel@telenet.be> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-GZjxMJywa+0hGWUlx6sW" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1646318214; bh=n2TqiPY7mOGvxZaRC4C3Ksmr0ZfNnK7BpfeNuGqeZYg=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=fD27dptDBa5InEuxqiIojltF30j7envnO8Kp1837HFXD30BaOc6qlzB25ZCgczYnC r18yAKyz37BN5gxIFW+jEI719rWRPNXq1ceaestpiLktp+itVgt9fDiOaNf+x1eYCv pdesBR844qtLFtknmKlh4wgx5a1d2dD61JsGFPtL6nnBaE20+4Gp64QVk4PN9Mk+Tg ILPGNMPaZFzzdlJjgzbI02lF4B1+3yUQ7zdtE4E7/JW4zZdAE/oLnVklcZYDLnQnR+ x3IKOf3LJzaVIlPuTFMQ3NXw4rMnXE7pWm2UkavDLKVdOcmZvUiRz4tiJ/SsIa1C/K 3/0KNxxo8qLDQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1646318243; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=n2TqiPY7mOGvxZaRC4C3Ksmr0ZfNnK7BpfeNuGqeZYg=; b=brGl9ApTxLVyanukC8bgVE/O7u7Ze1FZfOrfrgiu9CpvQ7A+1kLM3wFOP3KPDmzxzmVnWo SOGChQzXUf4QgBzOS743dix+iR+vGsU07qSN1dT2HRsvTsHMWKdpbB/XHIc9bqhlWG9/r4 DRZI/ijY82T1GDMYYGMRR9pRWBfLtnTgmusoAicvLqQuhd7QJjeuJ+skj5OcR9Uv6KO5Lv y9K4keqRaTHCx6u+ybvepI1ru3s4w2p1/1vS0Gxm7/CvgU5dGfYD21n8AGH1hP1grEXSeL SoSqD4XQ5c2rqueuDdpiX9Rxsc/soGWovsvV2cqQDp+UN0U4exCWKwMD9wmldQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1646318243; a=rsa-sha256; cv=none; b=IPuSRwluvGQsL1jeSuqc4fSMFvZNXSMHhlNs+aO15sHXw5A8uZiP5OMFUlzAWkEfQU+nIM BpYCkagSfiQYQu86k841rsJ37YJTdRDKZxAziDARfAc4WvaHioKD2crlV8hu6PN7Adjo0H 20YCngjOC5Xsf138Xj6hMqXW2cd8UnrsVDQzPF1msBvfoTXlng2aTvuvAV3m4Ef5cmF6GX PXbV4amPW4XjtVhlMqSDNsGIE3ylbJA5pFVEDEMBE3rfWDugGspxjjThI3HbKsOg2ErMHT iVHjckvRgekpJhq0WURBPPwOhF7gi9WIXEAuqdXRoR5I8x3wJuFP/hL0rxhlWQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=fD27dptD; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 2.73 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=fD27dptD; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A1ADC3D3D2 X-Spam-Score: 2.73 X-Migadu-Scanner: scn0.migadu.com X-TUID: cUjk/Zyfc5k9 --=-GZjxMJywa+0hGWUlx6sW Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable zimoun schreef op wo 02-03-2022 om 10:14 [+0100]: > Hi Attila, >=20 > On Tue, 1 Mar 2022 at 20:42, Attila Lendvai wrote: >=20 > > unfortunately, it won't help us much here, because one snippet modifies > > Makefile.am, while the other Makefile.in. >=20 > Guix does not have a clear line for patching (or I am not aware of the > update); what is going to source+snippet vs arguments+phase. Pros and > cons for both; basically the question is what "guix build --source" > should return? >=20 > Option source+snippet means it returns the source of what Guix really > builds Seems like a pro for source+snippet (or source+patch, though that would be a bit more verbose) to me. > =C2=A0-- so many packages would not respect this rule of thumb. In that case, it seems like there are plenty of package definitions to improve! > Option arguments+phase means it returns the real unmodified upstream > source (modulo removal of non-free) -- so "guix shell -D foo" would > break for many packages. I assume you meant "guix build --source foo"? This seems like a con for "phases+arguments" to me. Sometimes, to hack on software, I download the source code with "guix build --source the-package", unpack it and do "guix shell -D the-package". I don't see much value in returning the unmodified upstream source. Especially since in this case the modified source fixes a bug (well, works-around a Guile bug). As long as it's source code, it builds, it doesn't do things like bundling, including binaries or non-free things, and it avoids being Guix-specific and fixes known bugs, it seems good source code to me. Also, most packages don't modify upstream code, so I don't see the =E2=80=98would break for many packages=E2=80=99 here ... > Difficult tension. :-) As implied from my explanations above, I don't see any tension here. > That's said, personally, in this case, instead of having the Makefile* > patch in 'source', I would do the patching using a phase. It's =E2=80=98merely=E2=80=99 setting some compilation flags, so maybe. Both options seem fine to me here but I don't see a point to _moving_ from the snippet-shed to phase-shed. Greetings, Maxime. --=-GZjxMJywa+0hGWUlx6sW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYiDShRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7kFgAQDGwT/D5lXc6wR2X8MIW7gnyjEr c11f0pSJiKarAeWhaAD/R/ecmWOz1O+0dzZokHS54qV8maGkr5bMU+K4zVsergY= =7WnR -----END PGP SIGNATURE----- --=-GZjxMJywa+0hGWUlx6sW--