all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#67503] [PATCH 0/2] Improvements to the go importer
@ 2023-11-28 10:18 Efraim Flashner
  2023-11-28 10:21 ` [bug#67503] [PATCH 1/2] guix: import: Don't include indirect dependencies in go Efraim Flashner
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Efraim Flashner @ 2023-11-28 10:18 UTC (permalink / raw)
  To: 67503; +Cc: Efraim Flashner, Katherine Cox-Buday

I had intended to do some go packaging but found myself working on the
go importer instead.

According to the upstream go documentation, go.mod IS supposed to list
the indirect dependencies so that when someone runs 'go build' or 'go
install' all the dependencies are already listed.  For us, the indirect
dependencies are already listed as propagated-inputs for the packages
which actually use them.

For the second patch I'm not super happy about using 'second' (yes,
(flatten (go.mod-directives go.mod 'go)) does return (version "1.18"))
but I couldn't find a nice way to return just the version string, and it
seemed better than cadr.  Using version>? was the simplest way to do the
version compare, but I can copy the logic over if we'd rather not import
(guix utils).

Efraim Flashner (2):
  guix: import: Don't include indirect dependencies in go.
  guix: import: Report go version for go importer.

 guix/import/go.scm | 37 +++++++++++++++++++++++++++++++------
 1 file changed, 31 insertions(+), 6 deletions(-)


base-commit: 62376e3eb67644454bc655bed56be4be965bd13e
-- 
Efraim Flashner   <efraim@flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-10-31 13:42 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-28 10:18 [bug#67503] [PATCH 0/2] Improvements to the go importer Efraim Flashner
2023-11-28 10:21 ` [bug#67503] [PATCH 1/2] guix: import: Don't include indirect dependencies in go Efraim Flashner
2023-11-28 10:21 ` [bug#67503] [PATCH 2/2] guix: import: Report go version for go importer Efraim Flashner
2024-10-31 13:39 ` [bug#67503] Improvements to the go importer (bumping) Steve George

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.