all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Steve George <steve@futurile.net>
To: 72578@debbugs.gnu.org
Subject: [bug#72578] Adding fooyin music player to Guix
Date: Thu, 31 Oct 2024 11:19:08 +0000	[thread overview]
Message-ID: <ZyNnrFFgKXRBtWlZ@dragon2> (raw)
In-Reply-To: <ce3335e5354c19829444fa46e6a29adca58fc777.1723387985.git.rodion.goritskov@gmail.com>

Hi,

Thanks for sending the patch to add Fooyin music player to Guix. 

I just had a quick look and you turned off tests, but I can see tests in the Git repository. Did you try to get them running and they failed, or was there some other reason for not running them? We generally prefer to have tests if at all possible.

Thanks,

Futurile




      reply	other threads:[~2024-10-31 11:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-11 14:53 [bug#72578] [PATCH] gnu: Add fooyin Rodion Goritskov
2024-10-31 11:19 ` Steve George [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZyNnrFFgKXRBtWlZ@dragon2 \
    --to=steve@futurile.net \
    --cc=72578@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.