On Mon, Oct 28, 2024 at 10:59:29AM +0100, Nicolas Graves wrote: > On 2024-10-28 10:49, Andreas Enge wrote: > > > Hello, > > > > I have just pushed this commit > > https://issues.guix.gnu.org/74006 > > that changes the default postgresql version from 10 (which has a CVE) to > > just the postgresql variable (now at 15). > > > > Since as I understood changing postgresql versions requires a > > (manual?) > > Indeed, in https://www.postgresql.org/support/versioning/: > > Upgrading > > Major versions make complex changes, so the contents of the data > directory cannot be maintained in a backward compatible way. A > dump/reload of the database or use of the pg_upgrade application is > required for major upgrades. We also recommend reading the upgrading > section of the major version you are planning to upgrade to. You can > upgrade from one major version to another without upgrading to > intervening versions, but we recommend reading the release notes of all > intervening major versions prior to doing so. > > > update of the database format, I am wondering whether we should > > - instead again choose a default value of a specific version? > > or maybe #f and force the user to choose one themselves? > > #f seems a good option since it forces users to update manually when > they require it, no magic updates involved. Maybe we should add a > comment about why the default is #f, and point to the url of the > documentation about upgrades. > > > - add a news item to be displayed during "guix pull"? > > I think a news item is necessary. > > Sorry I should have thought about it with the patch, let me know if > you'd wish I write this patch + news item. > > > Andreas > > > I feel like there is room for an 'upgrade action for postgresql, to dump a database (also useful for a 'backup action!) and then re-import it, but I didn't want to come anywhere near touching that. Also, thank you for updating it! I was recently feeling like it was on the 10 branch for too long and could use a bump. And some CVE handling. -- Efraim Flashner רנשלפ םירפא GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted