all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Andreas Enge <andreas@enge.fr>
To: 74039@debbugs.gnu.org
Subject: [bug#74039] Comments
Date: Mon, 28 Oct 2024 10:35:26 +0100	[thread overview]
Message-ID: <Zx9a3nfcGSZeXG_a@jurong> (raw)
In-Reply-To: <cover.1729985174.git.jesse@eisses.email>

Hello Jesse,

thanks for your contribution, which passes QA and looks mainly good!

QA runs "guix lint":
https://qa.guix.gnu.org/issue/74039
which complains about the following:
"the source file name should contain the package name"

Maybe you could run "guix lint" on your different packages and see to
which one it applies? Probably python-bip32 with its source taken from git.

Maybe you could use pypi there as well? When trying a "guix import pypi bip32"
I get a version 4.0 instead of 3.2; would this work as well?
Otherwise, there are examples in the Guix source of how to force a
descriptive name for the git checkout.

The description should consist of complete sentences and be a bit longer
and more descriptive, maybe a short paragraph. Often it can be taken from
the project website, after stripping out the marketing speech.

Please also adapt the commit messages to the Guix style.
Running "./etc/committer.scm" (instead of "git commit") could be an
option, it usually works well for adding new packages.

Looking forward to a v3,

Andreas





      parent reply	other threads:[~2024-10-28  9:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-26 23:53 [bug#74039] [0/5] Add ledger hardware wallet support jesse--- via Guix-patches via
2024-10-26 23:58 ` [bug#74039] [1/5] gnu: Add python-ledgercomm jesse--- via Guix-patches via
2024-10-26 23:58 ` [bug#74039] [2/5] gnu: Add python-coincurve jesse--- via Guix-patches via
2024-10-26 23:58 ` [bug#74039] [3/5] gnu: Add python-bip32 jesse--- via Guix-patches via
2024-10-26 23:58 ` [bug#74039] [4/5] gnu: Add python-ledger-bitcoin jesse--- via Guix-patches via
2024-10-26 23:58 ` [bug#74039] [5/5] gnu: Add ledger hardware wallet support to electrum jesse--- via Guix-patches via
2024-10-27  8:06   ` [bug#74039] [0/5] Add ledger hardware wallet support Jesse Eisses via Guix-patches via
2024-10-27 14:15     ` James Smith via Guix-patches via
2024-10-27 21:08       ` Jesse Eisses via Guix-patches via
2024-10-27 21:13 ` [bug#74039] [PATCH v2 1/5] gnu: Add python-ledgercomm jesse--- via Guix-patches via
2024-10-27 21:13   ` [bug#74039] [PATCH v2 2/5] gnu: Add python-coincurve jesse--- via Guix-patches via
2024-10-27 21:13   ` [bug#74039] [PATCH v2 3/5] gnu: Add python-bip32 jesse--- via Guix-patches via
2024-10-27 21:13   ` [bug#74039] [PATCH v2 4/5] gnu: Add python-ledger-bitcoin jesse--- via Guix-patches via
2024-10-27 21:13   ` [bug#74039] [PATCH v2 5/5] gnu: Add ledger hardware wallet support to electrum jesse--- via Guix-patches via
2024-10-28  9:35 ` Andreas Enge [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zx9a3nfcGSZeXG_a@jurong \
    --to=andreas@enge.fr \
    --cc=74039@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.