Re: Merging ‘core-updates’ real soon

["André Batista" <nandre@riseup.net>]

Hi,

qua 28 ago 2024 às 18:56:45 (1724882205), kaelyn.alexi@protonmail.com enviou:
> > 
> > Thoughts?
> 
> Do you have any modifications to e.g. the binutils package definition? It looks like the error is coming from using "cons" to append a configure flag; from the output above:

Not local, no.

> #:configure-flags (cons "--enable-64-bit-bfd" #<gexp (quote ("LDFLAGS=-static-libgcc" "--enable-new-dtags" "--with-lib-path=/no-ld-lib-path" "--enable-install-libbfd" "--enable-deterministic-archives" "--enable-64-bit-bfd" "--enable-compressed-debug-sections=all" "--enable-lto" "--enable-separate-code" "--enable-threads")) gnu/packages/base.scm:661:28 a765d108>)
> 
> I'd encountered a similar error in the past after more packages were migrated to use gexps because I hadn't yet learned of the gexp-aware helpers like "substitute-keyword-arguments". Basically the configure flags need to be extended using gexp operations instead of basic list operations like "cons". An example can be seen in the definition of "binutils-boot0" in gnu/packages/commencement.scm:
> 
> (substitute-keyword-arguments (package-arguments binutils)
>   ((#:configure-flags cf)
>    #~(append (list #$(string-append "--target="
>                                     (boot-triplet))
>                    "--disable-gprofng") ;requires Bison
>              #$cf)))))

But your comment put me on the right track and it seems both grub and
ipxe-qemu use inherited binutils' definitions which were trying to set
configure-flags using simple list procedures. I've sent a patch fixing
that on #72882, but I guess that patch can wait and be merged on master
right after core-updates?

Cheers,