all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Andreas Enge <andreas@enge.fr>
To: 71587-done@debbugs.gnu.org
Subject: bug#71587: Close
Date: Sun, 30 Jun 2024 11:44:46 +0200	[thread overview]
Message-ID: <ZoEpDve9ztBNUtI3@jurong> (raw)
In-Reply-To: <cover.1718512816.git.sergiodj@sergiodj.net>

Hello,

thanks for the patches!

I think renaming is a good idea; details are of course of the order of
bikeshedding. Since I like fediverse better, I kept your patch.

Concerning snac2, I have decided to call it snac instead. This is how it
is called on the author's github page (the largest heading), and it is
also the name of the binary. I have modernised the patch using gexps,
removed the #t return value of a phase, and added a comment why tests
are disabled.

There is no need to sign off your own patches, since you are already the
author.

Something strange happened with the change ids, there were two of them
in each commit; I have kept one every time.

Andreas





      parent reply	other threads:[~2024-06-30  9:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-16  4:46 [bug#71587] [PATCH 0/2] Rename mastodon.scm -> fediverse.scm and add snac2 Sergio Durigan Junior
2024-06-16  4:54 ` [bug#71587] [PATCH 1/2] gnu: mastodon: Rename to fediverse.scm Sergio Durigan Junior
2024-06-16  4:54 ` [bug#71587] [PATCH 2/2] gnu: fediverse: Add snac2 Sergio Durigan Junior
2024-06-17 10:43 ` [bug#71587] [PATCH 0/2] Rename mastodon.scm -> fediverse.scm and add snac2 MSavoritias
2024-06-17 17:56   ` Sergio Durigan Junior
2024-06-20 15:26 ` Sergio Durigan Junior
2024-06-29 20:17   ` Sergio Durigan Junior
2024-06-30  9:44 ` Andreas Enge [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZoEpDve9ztBNUtI3@jurong \
    --to=andreas@enge.fr \
    --cc=71587-done@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.