all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Andreas Enge <andreas@enge.fr>
To: Christopher Baines <mail@cbaines.net>
Cc: gemmaro.dev@gmail.com, 71396@debbugs.gnu.org
Subject: [bug#71396] Close
Date: Mon, 10 Jun 2024 12:21:11 +0200	[thread overview]
Message-ID: <ZmbTl5nTia1cFySb@jurong> (raw)
In-Reply-To: <87wmmxyuuo.fsf@cbaines.net>

Am Mon, Jun 10, 2024 at 11:07:11AM +0100 schrieb Christopher Baines:
> Note that quoting vs gexps matters for package inheritance, so even
> though there's no ungexp'ing happening in this pacakge, the phases could
> be ungexp'ed by a package that inherits from solaar.
> For this reason, I think it's important to move to using gexp's for all
> phases, even the trivial ones, so that there are less issues when it
> comes to package inheritance and modifying phases.

Good point, although most packages do not lead to inheritance; but when
they do, this issue becomes difficult to debug. Feel free to push the
second patch if you want to.

Andreas





      reply	other threads:[~2024-06-10 10:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-06 12:24 [bug#71396] [PATCH 0/2] gnu: solaar: Update to 1.1.13 gemmaro
2024-06-06 12:40 ` [bug#71396] [PATCH 1/2] " gemmaro
2024-06-06 12:40 ` [bug#71396] [PATCH 2/2] gnu: solaar: Use newer package style gemmaro
2024-06-10  9:58 ` bug#71396: Close Andreas Enge
2024-06-10 10:07   ` [bug#71396] Close Christopher Baines
2024-06-10 10:21     ` Andreas Enge [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZmbTl5nTia1cFySb@jurong \
    --to=andreas@enge.fr \
    --cc=71396@debbugs.gnu.org \
    --cc=gemmaro.dev@gmail.com \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.