From: Tomas Volf <~@wolfsden.cz>
To: Ian Eure <ian@retrospec.tv>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: Did something with format-patch or send-email break?
Date: Sun, 9 Jun 2024 12:19:21 +0200 [thread overview]
Message-ID: <ZmWBqWHr5QhdVT_x@ws> (raw)
In-Reply-To: <87jzizt01a.fsf@meson>
[-- Attachment #1: Type: text/plain, Size: 1435 bytes --]
Hi,
On 2024-06-08 17:22:30 -0700, Ian Eure wrote:
> I’m not sure of the precise mechanism employed, but I believe that that in the
> past, if I ran `git format-patch' and `git send-email', it would send an email
> to the right place.
There is etc/git/gitconfig in the repository that sets the necessary git
configuration for it to work.
> Is it broken?
Not for me.
> Am I missing one of the numerous intricate fiddly bits of setup to make email
> patch flow work?
Probably :) The fiddly piece here is that the git has to know about the
etc/git/gitconfig and it does not by default. If I grep my actual .git/config,
I see this:
$ cat .git/config | grep -B1 gitconfig
[include]
path = ../etc/git/gitconfig
The configuration is installed automatically (I assume that is why it is not
mentioned in the manual as you say), however it is done during the build:
$ cat Makefile.am | grep -C2 include.path
.git/config: etc/git/gitconfig
$(AM_V_at)if command -v git >/dev/null && test -d .git; then \
git config --fixed-value --replace-all include.path \
../etc/git/gitconfig ../etc/git/gitconfig; \
fi
So, can you please try the usual `./bootstrap && ./configure && make' and report
back whether it helped?
Hope this helps,
Tomas
--
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-06-09 10:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-09 0:22 Did something with format-patch or send-email break? Ian Eure
2024-06-09 10:19 ` Tomas Volf [this message]
2024-06-09 10:51 ` Tomas Volf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmWBqWHr5QhdVT_x@ws \
--to=~@wolfsden.cz \
--cc=guix-devel@gnu.org \
--cc=ian@retrospec.tv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.