bug#70960: Remove mozjs and icu4c versions

bug#70960: Remove mozjs and icu4c versions

[Andreas Enge]

After a recent patch updating the icu4c@68 dependency of 0ad to icu4c,
I have gone through icu4c and mozjs dependents.

It turns out that nothing depends on mozjs@91. Can it be removed?
Then I think that icu4c@69 can also be removed.

The only package depending on mozjs@78 is 0ad. Maybe the dependency
can be upgraded? (Well, we should check this first, upgrading to
mozjs@91 will prevent us from removing this...)

Andreas

bug#70960: Remove mozjs and icu4c versions

[Andreas Enge]

To partially answer my questions:

Am Wed, May 15, 2024 at 05:46:47PM +0200 schrieb Andreas Enge:
> The only package depending on mozjs@78 is 0ad. Maybe the dependency
> can be upgraded?

0ad is on the latest release, and cannot be built with any other of the
mozjs versions we currently have. So I would suggest to remove mozjs-91
and icu4c-69.

Thoughts?

Andreas

bug#70960: [PATCH] gnu: Remove mozjs-91.

[Andreas Enge]

* gnu/packages/gnuzilla.scm (mozjs-91): Delete variable.

Change-Id: I121a480eb15d670461a70b7703a3a658d9db6732
---
 gnu/packages/gnuzilla.scm | 31 -------------------------------
 1 file changed, 31 deletions(-)

diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index 814b610bba..6ec5ba272b 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -223,37 +223,6 @@ (define-public mozjs
 in C/C++.")
     (license license:mpl2.0))) ; and others for some files
 
-(define-public mozjs-91
-  (package
-    (inherit mozjs)
-    (version "91.13.0")
-    (source (origin
-              (method url-fetch)
-              (uri (string-append "https://ftp.mozilla.org/pub/firefox"
-                                  "/releases/" version "esr/source/firefox-"
-                                  version "esr.source.tar.xz"))
-              (sha256
-               (base32
-                "0qh7j960wdp5zcfqhkj8ki47spp9i9ms12xx0v0kxvmmw36jpgjk"))))
-    (arguments
-     (substitute-keyword-arguments (package-arguments mozjs)
-       ((#:phases phases)
-        #~(modify-phases #$phases
-            (add-before 'check 'disable-timezone-tests
-              (lambda _
-                (with-directory-excursion "../js/src/tests"
-                  ;; FIXME: Assertion failed: got "2021a", expected "2021a3"?
-                  (delete-file "non262/Intl/DateTimeFormat/timeZone_version.js")
-                  ;; XXX: Delete all tests that test time zone functionality,
-                  ;; because the test suite uses /etc/localtime to figure out
-                  ;; the offset from the hardware clock, which does not work
-                  ;; in the build container.  See <tests/non262/Date/shell.js>.
-                  (delete-file-recursively "non262/Date")
-                  (delete-file
-                   "non262/Intl/DateTimeFormat/tz-environment-variable.js"))))))))
-    (inputs (modify-inputs (package-inputs mozjs)
-              (replace "icu4c" icu4c-69)))))
-
 (define-public mozjs-78
   (package
     (inherit mozjs)

base-commit: bc6742e168f4af9d6479e00f482998b03653787a
prerequisite-patch-id: c4d3caa64171c21ee75b8ba30c80cab10c3674ef
-- 
2.41.0

bug#70960: Remove mozjs and icu4c versions

[Andreas Enge]

Well, icu4c-69 is needed by mozjs-78, so we cannot remove it.
But mozjs-91 should be good to remove. Let QA give us its opinion.

Andreas

bug#70960: [PATCH] gnu: Remove mozjs-91.

[Jonathan Brielmaier via Bug reports for GNU Guix]

Hallo Andreas,

Am 15.05.24 um 21:13 schrieb Andreas Enge:
> * gnu/packages/gnuzilla.scm (mozjs-91): Delete variable.

I'm not sure we should remove it yet.

0ad (the only reverse-dependency of mozjs@78) at master branch uses
mozjs@91. So the next release of it would require mozjs@91.

See:
https://trac.wildfiregames.com/wiki/SpiderMonkey
https://code.wildfiregames.com/D4428

~Jonathan

bug#70960: [PATCH] gnu: Remove mozjs-91.

[Andreas Enge]

Hallo, Jonathan!

Am Wed, May 15, 2024 at 10:12:10PM +0200 schrieb Jonathan Brielmaier:
> I'm not sure we should remove it yet.
> 0ad (the only reverse-dependency of mozjs@78) at master branch uses
> mozjs@91. So the next release of it would require mozjs@91.

thanks for the info! It agrees with the feeling that it is strange to
remove @91 while keeping @78.

So I will just close this bug report, which will store the info for
future use.

Andreas