bug#70324: After upgrade of linux-libre, linux-libre-documentation fails to build

bug#70324: After upgrade of linux-libre, linux-libre-documentation fails to build

[Tomas Volf]

[-- Attachment #1: Type: text/plain, Size: 5629 bytes --]

Hello,

linux-libre-documentation is broken again:

    starting phase `build'
    Traceback (most recent call last):
      File "/tmp/guix-build-linux-libre-documentation-6.8.4.drv-0/linux-6.8.4/./tools/net/ynl/ynl-gen-rst.py", line 26, in <module>
        import yaml
    ModuleNotFoundError: No module named 'yaml'
    Traceback (most recent call last):
      File "/tmp/guix-build-linux-libre-documentation-6.8.4.drv-0/linux-6.8.4/./tools/net/ynl/ynl-gen-rst.py", line 26, in <module>
        import yaml
    ModuleNotFoundError: No module named 'yaml'
    Traceback (most recent call last):
    Traceback (most recent call last):
      File "/tmp/guix-build-linux-libre-documentation-6.8.4.drv-0/linux-6.8.4/./tools/net/ynl/ynl-gen-rst.py", line 26, in <module>
      File "/tmp/guix-build-linux-libre-documentation-6.8.4.drv-0/linux-6.8.4/./tools/net/ynl/ynl-gen-rst.py", line 26, in <module>
        import yaml
        import yaml
    ModuleNotFoundError: No module named 'yaml'
    ModuleNotFoundError: No module named 'yaml'
    Traceback (most recent call last):
      File "/tmp/guix-build-linux-libre-documentation-6.8.4.drv-0/linux-6.8.4/./tools/net/ynl/ynl-gen-rst.py", line 26, in <module>
        import yaml
    ModuleNotFoundError: No module named 'yaml'
    Traceback (most recent call last):
      File "/tmp/guix-build-linux-libre-documentation-6.8.4.drv-0/linux-6.8.4/./tools/net/ynl/ynl-gen-rst.py", line 26, in <module>
        import yaml
    ModuleNotFoundError: No module named 'yaml'
    Traceback (most recent call last):
    Traceback (most recent call last):
      File "/tmp/guix-build-linux-libre-documentation-6.8.4.drv-0/linux-6.8.4/./tools/net/ynl/ynl-gen-rst.py", line 26, in <module>
      File "/tmp/guix-build-linux-libre-documentation-6.8.4.drv-0/linux-6.8.4/./tools/net/ynl/ynl-gen-rst.py", line 26, in <module>
        import yaml
    ModuleNotFoundError: No module named 'yaml'
        import yaml
    ModuleNotFoundError: No module named 'yaml'
    Traceback (most recent call last):
      File "/tmp/guix-build-linux-libre-documentation-6.8.4.drv-0/linux-6.8.4/./tools/net/ynl/ynl-gen-rst.py", line 26, in <module>
        import yaml
    ModuleNotFoundError: No module named 'yaml'
    Traceback (most recent call last):
      File "/tmp/guix-build-linux-libre-documentation-6.8.4.drv-0/linux-6.8.4/./tools/net/ynl/ynl-gen-rst.py", line 26, in <module>
    Traceback (most recent call last):
      File "/tmp/guix-build-linux-libre-documentation-6.8.4.drv-0/linux-6.8.4/./tools/net/ynl/ynl-gen-rst.py", line 26, in <module>
        import yaml
        import yaml
    ModuleNotFoundError: No module named 'yaml'
    ModuleNotFoundError: No module named 'yaml'
    Traceback (most recent call last):
      File "/tmp/guix-build-linux-libre-documentation-6.8.4.drv-0/linux-6.8.4/./tools/net/ynl/ynl-gen-rst.py", line 26, in <module>
        import yaml
    ModuleNotFoundError: No module named 'yaml'
    Traceback (most recent call last):
      File "/tmp/guix-build-linux-libre-documentation-6.8.4.drv-0/linux-6.8.4/./tools/net/ynl/ynl-gen-rst.py", line 26, in <module>
        import yaml
    ModuleNotFoundError: No module named 'yaml'
    Traceback (most recent call last):
      File "/tmp/guix-build-linux-libre-documentation-6.8.4.drv-0/linux-6.8.4/./tools/net/ynl/ynl-gen-rst.py", line 26, in <module>
        import yaml
    ModuleNotFoundError: No module named 'yaml'
    Traceback (most recent call last):
      File "/tmp/guix-build-linux-libre-documentation-6.8.4.drv-0/linux-6.8.4/./tools/net/ynl/ynl-gen-rst.py", line 26, in <module>
        import yaml
    ModuleNotFoundError: No module named 'yaml'
    make[2]: *** [Documentation/Makefile:111: Documentation/networking/netlink_spec/dpll.rst] Error 1
    make[2]: *** Waiting for unfinished jobs....
    make[2]: *** [Documentation/Makefile:111: Documentation/networking/netlink_spec/mptcp_pm.rst] Error 1
    make[2]: *** [Documentation/Makefile:111: Documentation/networking/netlink_spec/devlink.rst] Error 1
    make[2]: *** [Documentation/Makefile:111: Documentation/networking/netlink_spec/ethtool.rst] Error 1
    make[2]: *** [Documentation/Makefile:111: Documentation/networking/netlink_spec/handshake.rst] Error 1
    make[2]: *** [Documentation/Makefile:111: Documentation/networking/netlink_spec/nfsd.rst] Error 1
    make[2]: *** [Documentation/Makefile:111: Documentation/networking/netlink_spec/ovs_flow.rst] Error 1
    make[2]: *** [Documentation/Makefile:111: Documentation/networking/netlink_spec/fou.rst] Error 1
    make[2]: *** [Documentation/Makefile:111: Documentation/networking/netlink_spec/netdev.rst] Error 1
    make[2]: *** [Documentation/Makefile:111: Documentation/networking/netlink_spec/rt_addr.rst] Error 1
    make[2]: *** [Documentation/Makefile:111: Documentation/networking/netlink_spec/ovs_datapath.rst] Error 1
    make[2]: *** [Documentation/Makefile:111: Documentation/networking/netlink_spec/ovs_vport.rst] Error 1
    make[2]: *** [Documentation/Makefile:111: Documentation/networking/netlink_spec/rt_route.rst] Error 1
    make[2]: *** [Documentation/Makefile:111: Documentation/networking/netlink_spec/rt_link.rst] Error 1
    make[2]: *** [Documentation/Makefile:111: Documentation/networking/netlink_spec/tc.rst] Error 1
    make[1]: *** [/tmp/guix-build-linux-libre-documentation-6.8.4.drv-0/linux-6.8.4/Makefile:1705: infodocs] Error 2
    make: *** [Makefile:240: __sub-make] Error 2

How are these not caught in the CI?

Have a nice day,
Tomas Volf

--
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#70324: After upgrade of linux-libre, linux-libre-documentation fails to build

[Rostislav Svoboda]

> linux-libre-documentation is broken again:

Try to repeat ./bootstrap and configure

See also https://issues.guix.gnu.org/issue/70140 and the commit
74517806f80dab17474a3c5f0b91d437e4d4e052

Cheers, Bost

bug#70324: After upgrade of linux-libre, linux-libre-documentation fails to build

[Leo Famulari]

On Wed, Apr 10, 2024 at 05:05:15PM +0200, Tomas Volf wrote:
> linux-libre-documentation is broken again:
> 
>     starting phase `build'
>     Traceback (most recent call last):
>       File "/tmp/guix-build-linux-libre-documentation-6.8.4.drv-0/linux-6.8.4/./tools/net/ynl/ynl-gen-rst.py", line 26, in <module>
>         import yaml
>     ModuleNotFoundError: No module named 'yaml'

It looks like the package depends on pyyaml now. I wonder if that's
intentional. Did you search the upstream bug tracker to look for more
info?

> How are these not caught in the CI?

What do you mean? The CI server did register the build failure:

https://ci.guix.gnu.org/build/3863875/details

As well as many other build failures in the kernel packages:

https://ci.guix.gnu.org/eval/1228559

bug#70324: After upgrade of linux-libre, linux-libre-documentation fails to build

[Tomas Volf]

[-- Attachment #1: Type: text/plain, Size: 2098 bytes --]

On 2024-04-10 23:12:43 -0400, Leo Famulari wrote:
> On Wed, Apr 10, 2024 at 05:05:15PM +0200, Tomas Volf wrote:
> > linux-libre-documentation is broken again:
> >
> >     starting phase `build'
> >     Traceback (most recent call last):
> >       File "/tmp/guix-build-linux-libre-documentation-6.8.4.drv-0/linux-6.8.4/./tools/net/ynl/ynl-gen-rst.py", line 26, in <module>
> >         import yaml
> >     ModuleNotFoundError: No module named 'yaml'
>
> It looks like the package depends on pyyaml now. I wonder if that's
> intentional. Did you search the upstream bug tracker to look for more
> info?

I did (now) and the search gives nothing.  However I suspect the commit in
question would be a304fa1d10fcb974c117d391e5b4d34c2baa9a62:

  docs: Makefile: Add dependency to $(YNL_INDEX) for targets other than htmldocs

Based on the diff:

  +htmldocs texinfodocs latexdocs epubdocs xmldocs: $(YNL_INDEX)
  +
  +htmldocs:

I would assume it is the texinfodocs triggering the YNL_INDEX for us.  This
snippet from the commit message:

  If one of other targets such as latexdocs or epubdocs is built
  without building htmldocs, missing .rst files can cause additional
  WARNINGs from sphinx-build as follow:

Seems to indicate it is intentional.

>
> > How are these not caught in the CI?
>
> What do you mean? The CI server did register the build failure:
>
> https://ci.guix.gnu.org/build/3863875/details
>
> As well as many other build failures in the kernel packages:
>
> https://ci.guix.gnu.org/eval/1228559

Right, I should have written the question differently.  I am curious how this
got onto the master.  Given the point 9. in (guix)Submitting Patches, and the
fact the QA should run on every patch before it is accepted, I was surprised
that the broken build of dependent package was committed.

Since this was second time in past ~two months the linux-libre-documentation
package on master was broken, I was curious if it is special in some way.

Have a nice day,
Tomas Volf

--
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#70324: After upgrade of linux-libre, linux-libre-documentation fails to build

[Leo Famulari]

On Thu, Apr 11, 2024 at 04:42:27PM +0200, Tomas Volf wrote:
> I would assume it is the texinfodocs triggering the YNL_INDEX for us.  This
> snippet from the commit message:
> 
>   If one of other targets such as latexdocs or epubdocs is built
>   without building htmldocs, missing .rst files can cause additional
>   WARNINGs from sphinx-build as follow:
> 
> Seems to indicate it is intentional.

Okay, thanks for looking. We can add a dependency on python-pyyaml and
it should work.

> Right, I should have written the question differently.  I am curious how this
> got onto the master.  Given the point 9. in (guix)Submitting Patches, and the
> fact the QA should run on every patch before it is accepted, I was surprised
> that the broken build of dependent package was committed.
> 
> Since this was second time in past ~two months the linux-libre-documentation
> package on master was broken, I was curious if it is special in some way.

Oh, I see. As shown on the 'kernel-updates' Cuirass jobset page, our
infrastructure at ci.guix.gnu.org can build less than of the kernel
packages successfully. So, the documentation failures are "lost in the
noise".

https://ci.guix.gnu.org/jobset/kernel-updates

I'm looking for more people to help with the kernel packages, and one
person has joined the effort and that is great!

But if we want to hold the kernel packages to the normal Guix standard,
we need more help:

https://lists.gnu.org/archive/html/guix-devel/2023-10/msg00079.html

Based on lack of complaints, it seems that people are only using Guix's
linux-libre kernels on x86_64. Either nobody is using the other
architectures, or they are using different kernels. So bugs are seldom
reported or fixed.

Example of CI failure bugs that don't seem to affect anyone:
https://issues.guix.gnu.org/67535

And qa.quix.gnu.org is too slow for kernel updates, which occur roughly
once a week. If QA takes more than one week to process the proposed
updates, then we would never catch up. The QA workflow is very good and
we should be using it, but it needs to be more powerful.

bug#70324: After upgrade of linux-libre, linux-libre-documentation fails to build

[Leo Famulari]

On Thu, Apr 11, 2024 at 10:55:39AM -0400, Leo Famulari wrote:
> Okay, thanks for looking. We can add a dependency on python-pyyaml and
> it should work.

I sent a patch:

https://issues.guix.gnu.org/issue/70343

And CI will test it here:

https://ci.guix.gnu.org/eval/1241100

bug#70324: After upgrade of linux-libre, linux-libre-documentation fails to build

[Leo Famulari]

On Thu, Apr 11, 2024 at 03:18:49PM -0400, Leo Famulari wrote:
> I sent a patch:
> 
> https://issues.guix.gnu.org/issue/70343

This should be fixed with commit cc38699cf0cfd804a43ca1b6c8602cfc84e06117

Please let us know if you see more problems. Thanks for the report!