From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id SDbDMd9TD2byMwAA62LTzQ:P1 (envelope-from ) for ; Fri, 05 Apr 2024 03:29:04 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id SDbDMd9TD2byMwAA62LTzQ (envelope-from ) for ; Fri, 05 Apr 2024 03:29:03 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=6xq.net header.s=MBO0001 header.b=iL37V9Ze; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=6xq.net (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1712280543; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=E7+u1jWm55TpkoPjWEzO5vs84FBQgC7ui2zTZu9ipsI=; b=CORbzBJAY3eEMGXR9NOh9Q4CHEqU7qgwvYqzKCnzzvemWA6snq6rZTSHgyeeADp5SnOVAQ EAQIDDay1xImAprcPrh55H6Ih+UfXaeToJfur2Psd0coUrcBFoZvo8SxCu89glQ7+vla8L RJyJSR7FJZZ5k+9Gs0B20Ys8/7M5o2/itr8vkrb0S8sotm/38gJTKNUTN6x+27GDVySakQ aPiSO+NahprWrKiFoexqUdsu+S4bFnHv92PRCd8faYlcKW4flwNWJKXUb66JCcsCFz8Ijz H/FPpeKitYU3cXqkmnMKceDFXn6NfC1E7JwY2JJh44zTKk3Gq4tNx4dw1GAy5Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1712280543; a=rsa-sha256; cv=none; b=Ug+36481q8ZuG1DfM0BQ+dAw61dQMpLvCtiGWZpnJo4qcm4YldQBsJvKfi9HpBCNBO2lvl vkr1BYtM4Y7cbb8uHNeuXzNbBvw5iorQbdRZ2utjtWOys+4t8n7dxoOII5GF8WCXxLFW5y k3l7a0LD8XRtTiuQC0yu/GKsllQ2XsAZA1XtUcK6Wzd1+JTBDDj0hkOBtftOwRDY9MO4nq /1ohgM414Umz3+z3B+n7cVZ3htTJ3zEdQWKy45dJ6NNTawATil/oAFrvlQouo1yrRgzu+J qiXL33ftgoLK/Io3NRm7xVh2zfSwJtN+mSBsoaC3wBZyQ30zcfuvCmq+KUS03g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=6xq.net header.s=MBO0001 header.b=iL37V9Ze; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=6xq.net (policy=none) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6511822A74 for ; Fri, 5 Apr 2024 03:29:03 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rsYO2-0002Zf-Mg; Thu, 04 Apr 2024 21:28:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rsYO1-0002Xv-6V for guix-patches@gnu.org; Thu, 04 Apr 2024 21:28:57 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rsYO0-0003hp-Uv for guix-patches@gnu.org; Thu, 04 Apr 2024 21:28:56 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rsYO6-0007QQ-65 for guix-patches@gnu.org; Thu, 04 Apr 2024 21:29:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70179] [PATCH 0/3] Use system nss-certs in Python. Resent-From: Lars-Dominik Braun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 05 Apr 2024 01:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70179 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner Cc: Tanguy Le Carrour , Munyoki Kilyungi , 70179@debbugs.gnu.org, jgart , Marius Bakke , Sharlatan Hellseher Received: via spool by 70179-submit@debbugs.gnu.org id=B70179.171228049428330 (code B ref 70179); Fri, 05 Apr 2024 01:29:02 +0000 Received: (at 70179) by debbugs.gnu.org; 5 Apr 2024 01:28:14 +0000 Received: from localhost ([127.0.0.1]:35008 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rsYNI-0007Mi-Ij for submit@debbugs.gnu.org; Thu, 04 Apr 2024 21:28:13 -0400 Received: from mout-p-103.mailbox.org ([80.241.56.161]:40044) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rsYNG-0007LW-1B for 70179@debbugs.gnu.org; Thu, 04 Apr 2024 21:28:11 -0400 Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4V9gpj2v2gz9skc; Fri, 5 Apr 2024 03:27:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6xq.net; s=MBO0001; t=1712280477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E7+u1jWm55TpkoPjWEzO5vs84FBQgC7ui2zTZu9ipsI=; b=iL37V9Zeqn2NxxmH4JqCiSo8mXSEGxjmFbm1/MhVQZsTxyPkbRy6CZDvo/6QMWHCDB4edk NEFZg8djiw49YjxWEqZGiXOVs34p1iXa531CwGydmfsEeyTV1iJsY0DyDigmxJmbUWtgbw a18OogscCvGRYz053Avnyi3eEoTwIYlWROPWDI4F+bHGDuFS0ryzIEZXxfBRsnXiHatz8S Lf3Dt7nHNqnRQIhaMuxGwZE/PNSsbzUb2m4njYCg1U9ax7tmL0V1gbBEIN+hDoowU6u8mk BkvMFHkDE2Jp6n9WP2R9I3JNUdlFeyCeev70ycAB96kWKlBqpoctGG7301jhOg== Date: Fri, 5 Apr 2024 10:27:46 +0900 From: Lars-Dominik Braun Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 4V9gpj2v2gz9skc X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 5.28 X-Spam-Score: 5.28 X-Migadu-Queue-Id: 6511822A74 X-Migadu-Scanner: mx12.migadu.com X-TUID: X4/ADZ5qe1qq Hi Efraim, > It turns out that the Python ecosystem bundles a version of nss-certs. > This patch series should change it so that it uses the system nss-certs > instead. I would change the comment at the top of core.py so it mentions this is a Guix-specific version of certifi.py, so it’s clear the package has been altered. You probably don’t need `_CA_CERTS = None`, since the try…except clause covers all cases. Otherwise LGTM. Lars