From: Lars-Dominik Braun <lars@6xq.net>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: Tanguy Le Carrour <tanguy@bioneland.org>,
Munyoki Kilyungi <me@bonfacemunyoki.com>,
70179@debbugs.gnu.org, jgart <jgart@dismail.de>,
Marius Bakke <marius@gnu.org>,
Sharlatan Hellseher <sharlatanus@gmail.com>
Subject: [bug#70179] [PATCH 0/3] Use system nss-certs in Python.
Date: Fri, 5 Apr 2024 10:27:46 +0900 [thread overview]
Message-ID: <Zg9TkkZ6VTNldhTZ@philomena> (raw)
In-Reply-To: <cover.1712210069.git.efraim@flashner.co.il>
Hi Efraim,
> It turns out that the Python ecosystem bundles a version of nss-certs.
> This patch series should change it so that it uses the system nss-certs
> instead.
I would change the comment at the top of core.py so it mentions this is
a Guix-specific version of certifi.py, so it’s clear the package has
been altered. You probably don’t need `_CA_CERTS = None`, since the
try…except clause covers all cases.
Otherwise LGTM.
Lars
next prev parent reply other threads:[~2024-04-05 1:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 5:55 [bug#70179] [PATCH 0/3] Use system nss-certs in Python Efraim Flashner
2024-04-04 5:56 ` [bug#70179] [PATCH v2 1/3] gnu: python-certifi: Use system SSL certificates Efraim Flashner
2024-04-04 5:56 ` [bug#70179] [PATCH v2 2/3] gnu: python-pip: " Efraim Flashner
2024-04-04 5:56 ` [bug#70179] [PATCH v2 3/3] gnu: python: " Efraim Flashner
2024-04-05 1:27 ` Lars-Dominik Braun [this message]
2024-04-07 12:06 ` bug#70179: [PATCH 0/3] Use system nss-certs in Python Efraim Flashner
2024-04-07 20:41 ` [bug#70179] " Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zg9TkkZ6VTNldhTZ@philomena \
--to=lars@6xq.net \
--cc=70179@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
--cc=jgart@dismail.de \
--cc=marius@gnu.org \
--cc=me@bonfacemunyoki.com \
--cc=sharlatanus@gmail.com \
--cc=tanguy@bioneland.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.