all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: Suhail Singh <suhailsingh247@gmail.com>
Cc: 69558-done@debbugs.gnu.org, 69557-done@debbugs.gnu.org
Subject: [bug#69557] [bug#69558] [PATCH 0/2] gnu: Add emacs-lsp-booster rust app.
Date: Tue, 5 Mar 2024 10:22:01 +0200	[thread overview]
Message-ID: <ZebWKe-O4THT3Pkt@3900XT> (raw)
In-Reply-To: <cover.1709586245.git.suhail@bayesians.ca>

[-- Attachment #1: Type: text/plain, Size: 1427 bytes --]

Everything looked great, just some small things.

I had to downgrade rust-clap-verbose-flag-2 from 2.2.0 to 2.1.2 since
2.2.0 wanted a newer version of clap than we had (and this way I could
add it straight to master, not to rust-team).

I added a comment on emacs-lsp-booster that it was specifically emacs
and not emacs-minimal. Emacs-minimal wasn't able to run the bytecode
tests so it made more sense to use the full emacs.

Patches pushed!

On Mon, Mar 04, 2024 at 04:12:36PM -0500, Suhail Singh wrote:
> 
> Hi Guix,
> 
> Apologies for the noise of #69551.
> 
> This series adds the emacs-lsp-booster Rust application as well as one
> of its missing dependencies (rust-clap-verbosity-flag-2).  I have not
> packaged a Rust application in Guix previously, so would appreciate any
> comments and feedback.
> 
> Cheers
> 
> Suhail (2):
>   gnu: Add rust-clap-verbosity-flag-2.
>   gnu: Add emacs-lsp-booster.
> 
>  gnu/packages/crates-io.scm | 28 +++++++++++++++++++++++++++
>  gnu/packages/rust-apps.scm | 39 ++++++++++++++++++++++++++++++++++++++
>  2 files changed, 67 insertions(+)
> 
> 
> base-commit: f00f56514d90ebba5d9e08ec786c8118e437097c
> -- 
> 2.44.0
> 
> 
> 

-- 
Efraim Flashner   <efraim@flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2024-03-05  8:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-04 21:12 [bug#69558] [PATCH 0/2] gnu: Add emacs-lsp-booster rust app Suhail Singh
2024-03-04 23:57 ` [bug#69558] [PATCH 1/2] gnu: Add rust-clap-verbosity-flag-2 Suhail Singh
2024-03-05  5:45 ` [bug#69558] [PATCH 2/2] gnu: Add emacs-lsp-booster Suhail Singh
2024-03-05  8:22 ` Efraim Flashner [this message]
2024-03-05 15:01   ` [bug#69557] [bug#69558] [PATCH 0/2] gnu: Add emacs-lsp-booster rust app Suhail Singh
2024-03-06  7:54     ` Efraim Flashner
2024-03-06 14:59       ` [bug#69557] " Suhail Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZebWKe-O4THT3Pkt@3900XT \
    --to=efraim@flashner.co.il \
    --cc=69557-done@debbugs.gnu.org \
    --cc=69558-done@debbugs.gnu.org \
    --cc=suhailsingh247@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.