From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id eI0nNx9a1GXdcgAAe85BDQ:P1 (envelope-from ) for ; Tue, 20 Feb 2024 08:52:00 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id eI0nNx9a1GXdcgAAe85BDQ (envelope-from ) for ; Tue, 20 Feb 2024 08:52:00 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=CYiudNcN; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1708415519; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=ceDbWWrol8HlL/fnhBKlmSXo13izBaekTAGo4pVScI4=; b=dz5SpZ3KCP3tYwSQFUazaNCiNhU6biEMRqK8Jz3guvSasJw/1ByrEni2DC10+9kz64FX+F AkssZdnyIu1TPDmLIbzBxZSyTYI6mEa5FGEj4LWKq2aKuvCJHk+S1LyGTOlC6WOTSSlJch hG9BdoIZvguHC6A+0ZxMozTXBbOlHFLKscGMamYvHAqf5ewXv0et9rm4hrrmfak45lp1h4 BPSaId230HrmBduO2kVAyrJl8CZKEDR3WxTSmDgsDnQiDwLB9s/wt4MJVNKoQ2F9Rt3SUs yuY4HDl3bizlUQ+xY09j4VUCvkWfeR7Ra6xeb5RwRELebg4cu1tv5kUrgiX10g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=CYiudNcN; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1708415519; a=rsa-sha256; cv=none; b=Lzcn+p1nNisy+8HwKujXHSUgYsa+f6TIF7XJ0u30EjoYKOFhLAs6S52+MaIIsObS3dW4hC eKQN8Qxbk2OTE4pFhytbKaueKh+8BcLVtL2Pzfnyefy2Jeba+/8G2VRJ4654HlqARgawmJ 1ezr1/iPLJSmmcNMKdmmkMhdPL/vPhEEJPdo0N/+FAkqPjXmY/ajOubmlZON7KG0n4mVhO 18GPjFWO56dtBVPh9W3/Urp2TX2ss9tZEodTx1G0tVYRgpMYGDsTYc8h0lr5cPQvPpApBD 3P9zselgbihE+TQ949N6EBvx4ZL/W84sZLD8/VJas4GGUq4hYv5yMNv7cwirvA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B53F73E007 for ; Tue, 20 Feb 2024 08:51:59 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rcKur-000660-KR; Tue, 20 Feb 2024 02:51:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rcKum-000659-Lb for guix-patches@gnu.org; Tue, 20 Feb 2024 02:51:45 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rcKui-0006It-TT for guix-patches@gnu.org; Tue, 20 Feb 2024 02:51:43 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rcKv4-0005sQ-Ah for guix-patches@gnu.org; Tue, 20 Feb 2024 02:52:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#69169] [bug#69170] [PATCH rust-team 00/46] Add netavark Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 20 Feb 2024 07:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69169 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tomas Volf <~@wolfsden.cz> Cc: 69170@debbugs.gnu.org, 69169@debbugs.gnu.org Received: via spool by 69169-submit@debbugs.gnu.org id=B69169.170841551822566 (code B ref 69169); Tue, 20 Feb 2024 07:52:02 +0000 Received: (at 69169) by debbugs.gnu.org; 20 Feb 2024 07:51:58 +0000 Received: from localhost ([127.0.0.1]:44222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcKuz-0005ru-B1 for submit@debbugs.gnu.org; Tue, 20 Feb 2024 02:51:57 -0500 Received: from mail-wr1-f51.google.com ([209.85.221.51]:44247) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcKuw-0005rW-Hl; Tue, 20 Feb 2024 02:51:55 -0500 Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-33d6fe64a9bso81406f8f.0; Mon, 19 Feb 2024 23:51:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708415427; x=1709020227; darn=debbugs.gnu.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date:message-id:reply-to; bh=ceDbWWrol8HlL/fnhBKlmSXo13izBaekTAGo4pVScI4=; b=CYiudNcN+z1eHNoJMfcQFsmf2EW/j/JjCMz6WdgUFFwPcqUe1bWayj0tU2V7FTmQZ5 rUe2EuS5dYCLqGWUdbbvyqRUJZ2oMuyErFKiupMVKyrYnyeEf+BbQkgtyh2Ul8N1pCUW JssMLC/wjEA7wwvaQaA8Do5wNCMHTD5RVNxKMMbKTaoyWf2rvqPVNKCAKoKoJpLVhEWt qqCIclB/8NZjqgT7C6a5So0Mx8G3d9TGJ6AdqwLyJvP1kgnTzwYkjQ8+cmUG5NXVEm0j WwsiustLufz+sZiCJ2IWPouhsq41pF8ODB+ZwDFb69ChhdDpfxSl3vW+3TpElo4wvaMV VLfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708415427; x=1709020227; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ceDbWWrol8HlL/fnhBKlmSXo13izBaekTAGo4pVScI4=; b=OP5BqxmCOhvO09kx6PSGnAQw1X8kKfO+BNOM5rrqu6Fk3oZ0Pluz4C+U14Z7dAHTil 0tr04RRMWSUQOUOoC0a/DZQ3vqBsd6+kuH10bTzB7x7Jh0yJiMV3RuCjM3Vc7G4ByU5N i212z9Q5BaCf3fFS6oWmoqaZKOp+vvIt15ReuXLE1w8AHST9OJAPyhe9DQ1QRwr8GwrC AU9NOnazul5hwQWTgkjZ4KrYRzx4F54O4ntaF3rlOOHA9uQbD+gtlr1Rv+DVmnxSJrD2 iRGW87KiD/Fm1CjgqNP3O0tQtK1nJ5FuG5XaJ7NE263iYWGYElxJPJlHhhD/rr4tFYHx 4mMg== X-Forwarded-Encrypted: i=1; AJvYcCWVegwNLpPUSqeUVwKScFeVAoODoKiWQZM9rODIT7hl02I9TRgtAg2QYqKzMH7MxTQa6aStfVF3tIvRGd1K374yVEPxTaY= X-Gm-Message-State: AOJu0YxsAZoaosiK0XNUQk8suimnxiRqnGMZOLLVUOh8SAPVfRV0bj03 CpJ4fmv75vDed3J91xQLa9ON0ykdUJTggnT1X3+gRinW/KUe4wKxYTy+Ch/zuTg= X-Google-Smtp-Source: AGHT+IHHJe+0M8OgZ1ROuIJxcRl+aNa22FtpASB7rYBHXm0exnGfn6fBE/8AqE1ON3vMAkZL3k+tcg== X-Received: by 2002:adf:efc6:0:b0:33b:237b:22c2 with SMTP id i6-20020adfefc6000000b0033b237b22c2mr10356146wrp.21.1708415426819; Mon, 19 Feb 2024 23:50:26 -0800 (PST) Received: from localhost ([141.226.12.177]) by smtp.gmail.com with ESMTPSA id g16-20020adfa490000000b00337d6f0013esm12620408wrb.107.2024.02.19.23.50.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 23:50:25 -0800 (PST) Date: Tue, 20 Feb 2024 09:50:23 +0200 From: Efraim Flashner Message-ID: Mail-Followup-To: Efraim Flashner , Tomas Volf <~@wolfsden.cz>, 69169@debbugs.gnu.org, 69170@debbugs.gnu.org References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DxNa715VJd30CHi4" Content-Disposition: inline In-Reply-To: X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -7.08 X-Spam-Score: -7.08 X-Migadu-Queue-Id: B53F73E007 X-Migadu-Scanner: mx11.migadu.com X-TUID: zrJoP18jkOXQ --DxNa715VJd30CHi4 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 18, 2024 at 03:04:12PM +0100, Tomas Volf wrote: > On 2024-02-18 14:39:23 +0200, Efraim Flashner wrote: > > I pushed the patches to the rust-team branch without the change for > > cargo-native-inputs and without the snippet for prost-build. I also > > adjusted some of the patches so that the packages built. >=20 > Well I am just happy it was merged, so no complains here, but I have to a= dmit I > am curious. Is it really expected that every user of prost-build will ne= ed to > add protobuf into native-inputs? Only in situations where it is needed. In actuality we only needed it in prost-build itself and in netavark. > What if, in some new version, it starts requiring some-other-package inst= ead of > protobuf? All the downstream users will need to be adjusted as well. Th= at > seems somewhat sub-optimal. So I am trying to understand the reasoning h= ere. The patch you sent hardcoded the path to protobuf into the source of prost-build, which we try not to do. Also, using something like cargo-native-inputs is (to me) a little "too magical" to make sure that we have the required native-inputs in future builds. However! Don't let me nay-say it, if you feel strongly about it then do continue to push for it. Ideally we'd have a true graph of the dependencies among the rust packages rather than cargo-inputs and cargo-development-inputs, but we still don't have anything like the antioxidant-build-system yet. Another package which had to have an included perl dependency everywhere was the rust-ring packages. In the end I ended up going and rebuilding nearly all the pre-generated files in the sources so that we would have a ready-to-use source tarball without the need for perl everywhere. Seeing that protobuf was only needed in these two packages I don't think prost-build needs that currently, but it's also an option. > Thanks and have a nice day, > Tomas Volf >=20 > -- > There are only two hard things in Computer Science: > cache invalidation, naming things and off-by-one errors. --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --DxNa715VJd30CHi4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmXUWb0ACgkQQarn3Mo9 g1HEshAAr/IVSYxWrdaQt3YQpibBL1rHSghteijZ0aijZviFUeFmZANfkBbQ9w2B XLfThD8sZGPdzMa7DZOVlregtS/Kpy+qNgqst/9/3fMqS3JUSRRRYqt6ipp6UIML MPpb+boP3PQkUu9nj5LvOohYooNWxUymIY3BoMdfGyCbwyNA0qJsuwohTMn9SCn/ 0jZTNztfsBHCeod6b3VxD5i5DxWwj0wSsVgG8VHxMdSMy0hZZz7s+3WgNf8tJhQ0 OK1QZfyPeWknKwr1jV0eSkCDyQNF6Q1FCJYA0YKyurCTDhbdYx4WvC+6SelTr1mF 2nyJPBYTPz1mYMGluzgXFAf+4s8lXK3RguaQlXfY2HSMXe4RjxL3ILM8bMKaVwlM WiB2A28jgZX5J1Dy0L8HIkkOZUO2z6WGjEYaRcKRuAzklIgr05ZGtbisJqxsnLgk YKlQveJCTgpXls3UuC7mlaxODWKQDAFUhihYEuIIOHWWwoQCW2INQ101Y5u+C8rv GHrwjx0QMwtOeAypE+gYIFq7X6UlR2vQlWGQo1dI8M+8I2ZwOgJCipPBbCtmMkAL 0jycmUNd+H7lcnSXqKujQ1chDsRsqW2wmIgNUGVhrX2zyaK1UM8dPn9ZXfwliCgw ke0kgEuV1Vuaew4A7/Okco8k9Tf6yRJm61zZrS+EZjliRVi6EHk= =vjmC -----END PGP SIGNATURE----- --DxNa715VJd30CHi4--