[bug#69355] [PATCH] gnu: Add libgrapheme.

[cage <cage-dev@twistfold.it>]

On Mon, Feb 26, 2024 at 11:24:42AM -0500, Maxim Cournoyer wrote:
> Hi,

Hi!

[...]

> We strive to enable test suites of packages in Guix, as this gives us a
> chance to detect breakage across updates.  Its page mentions a 'test'
> target to run the conformance and unit tests of libgrapheme.  Did you
> try it, via #:test-target "test" ?  (the default is "check", which is
> most common).

I did not  payed the right attention while reading  the README file of
the  package and  I missed  the mentions  of the  tests target  in the
makefile. ^^;

>
> > +           #:phases #~(modify-phases %standard-phases
> > +                        (add-after 'configure 'post-configure
> > +                          (lambda _
> > +                            (substitute* "config.mk"
>
> Please leave an explanatory comment mentioning that running ldconfig is
> not needed on Guix.

sure!

>
> > +                              (("ldconfig") "")))))
> > +           #:make-flags
> > +           #~(list (string-append "CC=" #$(cc-for-target))
> > +                   (string-append "PREFIX=" #$output))))
> > +    (home-page "https://libs.suckless.org/libgrapheme/")
> > +    (synopsis "Library to handle string according to Unicode standard")
> > +    (description "Libgrapheme is an extremely simple freestanding C99 library
> > +providing utilities for properly handling strings
> > +according to the latest Unicode standard 15.0.0.")
>
> nitpick: The paragraph flow seems broken after 'handling strings' --
> "M-;" in Emacs would help.

For some reasons this command does not work for me, i used to use M-q,
i hope the results is acceptable. ^^;

> I'd also drop the exact Unicode standard currently targeted, as this
> would probably become outdated information soon.

Good idea!

> Could you send a v2 with the above changes?

Sure! The new patch is attached below.

Thanks for your comments, let me know if I have addressed, or not, all the issues.
Bye!
C.

---
 gnu/packages/suckless.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
index 81e2151854..b89b3be961 100644
--- a/gnu/packages/suckless.scm
+++ b/gnu/packages/suckless.scm
@@ -1393,3 +1393,36 @@ (define-public 9base
     (description
      "This package provides ported versions of various Plan 9 userland tools
 for Unix.")))
+
+(define-public libgrapheme
+  (package
+    (name "libgrapheme")
+    (version "2.0.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://dl.suckless.org/libgrapheme/libgrapheme-"
+                           version
+                           ".tar.gz"))
+       (sha256
+        (base32 "099i2jm9c25nkbg5420wr12z0gd189gcw5j1ssjmpmbbwzfvv2x6"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list #:tests? #true
+           #:test-target "test"
+           #:phases #~(modify-phases %standard-phases
+                        (add-after 'configure 'post-configure
+                          (lambda _
+                            ;; removing call of ldconfing in makefile as it is
+                            ;; not actually needed in guix
+                            (substitute* "config.mk"
+                              (("ldconfig") "")))))
+           #:make-flags
+           #~(list (string-append "CC=" #$(cc-for-target))
+                   (string-append "PREFIX=" #$output))))
+    (home-page "https://libs.suckless.org/libgrapheme/")
+    (synopsis "Library to handle string according to Unicode standard.")
+    (description "Libgrapheme is an extremely simple freestanding C99 library
+providing utilities for properly handling strings according to the latest
+Unicode standard.")
+    (license license:isc)))

base-commit: de24aaf13b17d6c019f3f240fd0eb0e1b8654970
prerequisite-patch-id: aa0b913d42bee51002e7243019d5529984321e91
--
2.41.0