From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 0EwgGBsTymWFbgEAqHPOHw:P1 (envelope-from ) for ; Mon, 12 Feb 2024 13:46:19 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id 0EwgGBsTymWFbgEAqHPOHw (envelope-from ) for ; Mon, 12 Feb 2024 13:46:19 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=ljSd02SA; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1707741979; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=HTzX2l24DIe4wEzfA3ZcPxU//Sm2aOnp7mN586BpB7I=; b=DBJkDHFSX0FVMSGOkuet3llI3tJlrYw0pDNLbRZPUGRd3WermAicUAqDsrJROCp8kyxtIJ f6M4VCpTWVLW+8cor9g0aRsT9ZtFKP/3QEoSqN7W5WhhA52Rv1WXR2R3WkDxIaV1HXRaNR 4bdVtC/DubaC8sL15Vvd244F5/u7Uh5NOCJHkMSbngZX0TI/CpZaWhPBnmCCzJ7bEZLqXZ KzGfdp+eSWSFyyXZh6q0PsjSLCOTNUEC1cQgzXdBuNUqwTy5gENbnqEC9zizBqqTe1Bo5P BSbZlNWu2EpNJ+sw64nP+77kqnRGsfFNAE3FyfiKdgeEEGLBZFh9J2SqqR8/rQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=ljSd02SA; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1707741979; a=rsa-sha256; cv=none; b=mt/BiS0v03P6T89lffHMPRaExZoYpmIn3fWaPtAVvWcJenCN3OW5nIh+I0JRv3zNcBKIhl zmyFkAVl3NW0+yJ/nljsNS/+bYQllMb6/se0WSfHxOp2DzbTspPSEsHyYn4RNxMwXFb5uS xV6rG9/jPIJXwGLz0FAiGVqyHdV3v5oXoa0oLvW/vw5N/8i8nKiGl0a6YaSO0YeA6yWdhZ PFs33ShTqwxBjEijr5YnNVjOiF9sRl/YxROhz5K0kK1Dw1M8n9UP6ELBWZFGspmwJPUv7m G5dPFVViYGI8k1Ds7zut9QRuO4kUH8HvCJL9MkaJNE9t0hjz8gPez9hEWRlLSg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D36F63F75B for ; Mon, 12 Feb 2024 13:46:18 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZVgz-0002nX-5W; Mon, 12 Feb 2024 07:45:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZVgw-0002nG-UD for guix-patches@gnu.org; Mon, 12 Feb 2024 07:45:47 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rZVgw-0008Ew-72 for guix-patches@gnu.org; Mon, 12 Feb 2024 07:45:46 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rZVhC-000253-Oe for guix-patches@gnu.org; Mon, 12 Feb 2024 07:46:02 -0500 Subject: bug#68819: [PATCH 00/49 rust-team] Update i3status-rust to 0.32.3. Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Mon, 12 Feb 2024 12:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 68819 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Herman Rimm Cc: 68819-done@debbugs.gnu.org Received: via spool by 68819-done@debbugs.gnu.org id=D68819.17077419137785 (code D ref 68819); Mon, 12 Feb 2024 12:46:02 +0000 Received: (at 68819-done) by debbugs.gnu.org; 12 Feb 2024 12:45:13 +0000 Received: from localhost ([127.0.0.1]:54488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZVgN-00021S-UW for submit@debbugs.gnu.org; Mon, 12 Feb 2024 07:45:12 -0500 Received: from mail-wm1-f53.google.com ([209.85.128.53]:42072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZVgL-00020l-HJ for 68819-done@debbugs.gnu.org; Mon, 12 Feb 2024 07:45:10 -0500 Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-411a6dee71fso353265e9.0 for <68819-done@debbugs.gnu.org>; Mon, 12 Feb 2024 04:44:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707741886; x=1708346686; darn=debbugs.gnu.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date:message-id:reply-to; bh=HTzX2l24DIe4wEzfA3ZcPxU//Sm2aOnp7mN586BpB7I=; b=ljSd02SA8x3dxuxEV3OXV6jTrB3TI1H01kt6sHhkFgIXCu47gXzeNGgrAmJcG46IFb DNmHg+n0/sWQvvgILtK8EqI5ZFxoIQ9ClOuJnCqXNpwyNiWuYvPtR4O6PQGraDrm26MJ +mFgE49PMPOR9bk2Tt+NUvmfyAVPj7ts+93xyDc9a9+/MPIuiQjaepRHIiMKvEHJQGJ8 8C+cyzv7rX2C/8vULa3soYJFW5ax0VCfkpNjQjQSvYjyNT4EvZoIe5FmZhxukLJNVQj1 Cucaq0IwNy9knD/zdQeSqPqp7WibZgfh5CyWCN+hwHMXf5P/8LX9CP1Z/GJjXvatoRbV cI8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707741886; x=1708346686; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HTzX2l24DIe4wEzfA3ZcPxU//Sm2aOnp7mN586BpB7I=; b=I2eEykfJRIf0OaP3h92Wc1q3G79wYbrnuMZ6nlbas3DAmXFZo17E+xluIZO/RIG0QO L/hkRJ4W870ODZ/XnVacIqE+h/bkEZeEz35nFB2Ua/BqZ9GxZ8N/cdDZHj+8jDrIXem7 gJW2uDrnSyP3Mz4WeEg7Qmp5QMQGVu19hVmaKhmf4IDwa5PKZe0+2HWQCU82y83qgAko MVsCl8nwqRsKrsK+szrJSflGVUz54PoHfjllxtxE6xqJrdnebHpaY+zzxMWrG45ujHQk yQrlAAEw8T0bxF3MT7qeIm1HuDodlLTt2w/KGbos20YWsltqgzu/+K0+uzPrSp1sdjUO J+nQ== X-Gm-Message-State: AOJu0YxB6wM1c5+yZD/di16DsajFVHH9zTHBAzMIBn5S0/RmQxlPl14+ vX2ktsdw0tRlnq0e5cA133Ofyby+OmgC0D/Wc0lSH/2sbR5TN/Ga7DwtWijMVEA= X-Google-Smtp-Source: AGHT+IHatkNZzqtHrTbIO4AYABAON3hBqnPqt56FzA+DKJhlf4OYXi0erZ+WxXTf/fZ28SMdRdDYrw== X-Received: by 2002:a05:600c:4f4b:b0:410:ce61:8609 with SMTP id m11-20020a05600c4f4b00b00410ce618609mr2532918wmq.11.1707741886267; Mon, 12 Feb 2024 04:44:46 -0800 (PST) Received: from localhost ([141.226.12.177]) by smtp.gmail.com with ESMTPSA id fa26-20020a05600c519a00b00410dad58533sm2452797wmb.1.2024.02.12.04.44.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 04:44:45 -0800 (PST) Date: Mon, 12 Feb 2024 14:44:44 +0200 From: Efraim Flashner Message-ID: Mail-Followup-To: Efraim Flashner , Herman Rimm , 68819-done@debbugs.gnu.org References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FtRWwFvyEJPPYTyR" Content-Disposition: inline In-Reply-To: X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -4.27 X-Migadu-Queue-Id: D36F63F75B X-Spam-Score: -4.27 X-Migadu-Scanner: mx11.migadu.com X-TUID: kFbttbTyFZHJ --FtRWwFvyEJPPYTyR Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Patches pushed to the rust-team branch with a few changes. I'll answer your questions inline. On Tue, Jan 30, 2024 at 04:03:34PM +0100, Herman Rimm wrote: > Hi rust-team, >=20 > When I started using Guix, my i3status-rust config was for a newer > version, now I got around to updating the package. I understand why > noone had updated it, as it was quite tedious. Anyway, I added the > dependencies required for the new version. Some notes: >=20 > I shortened synopses and punctuated descriptions, but mostly left the > #:cargo-inputs indentation as guix import had generated it. I want guix > import crate to generate appropriate indentation. >=20 > rust-arrow2 and rust-tera are patched and build with rust-chrono-tz-0.8 > so that it can replace rust-chrono-tz-0.6 in a single commit. >=20 > rust-zbus-3 and rust-zbus-macros-3 dependency are updated in a single > commit, instead of relaxing rust-zbus-3 dependency versioning. Probably could have updated rust-zbus-macros-3 first and then rust-zbus-3, but if the two commits are next to each other its generally fine. Or doing both in one commit is also fine. > Enabled tests on rust-notmuch. >=20 > Although ordered-stream-0.2 is not adjacent to ordered-stream-0.1, the > latter is removed in a later commit. >=20 > Lastly, i3status-rust is updated and any dependencies that become unused > are removed recursively. >=20 > Assorted questions: >=20 > 1. Should rust-from-variants-impl-0.6 be public? Yes, we have (almost?) all the rust packages as public. > 2. I updated wayrs-client to 1.0, because adding a #[macro_use] made > the wayrs-scanner-0.12 generate! macro available, so wayrs-client 0.12 > would build in isolation, but not as a dependency of i3status-rust. > Adding #[macro_export] to the macro in wayrs-scanner-0.12 did not have > any effect. Does this issue seem familiar? I tried to build i3status-rust with the 0.12 versions but ran into build issues so I left it as you have it. That issue specifically I don't remember seeing, but I haven't played around with it as much as I could have. > 3. rust-async-io-2 and rust-async-net-2 form a cyclical dependency, > should they be added as separate packages anyway? I would generally do it as two separate commits, even though each depends on the other. Doing both in one commit is technically more correct. > 4. When to #:skip-build? I generally do it when a package actually doesn't build (like if it only builds on macOS or on Windows) or if we can't get all the dependencies packaged, like rust-clap-derive-4 (I think) which has a dependency which wants a newer version of nushell. Most of the time I leave a comment about cutting the dependency chain. There was a period where intermediate crates which were imported defaulted to '#:skip-build? #t' but it made it harder to check that the inputs were correct. > 5. Why is a rust package name defined when inheriting the same name? We use the name field as part of the source file-name, and if we leave it as inherited then the name field shows up as undeclared. > Cheers, > Herman >=20 > Herman Rimm (49): > gnu: Add rust-async-once-cell-0.5. > gnu: Add rust-backon-0.4. > gnu: Add rust-calibright-0.1. > gnu: Add rust-neli-proc-macros-0.1. > gnu: Add rust-neli-0.6. > gnu: Add rust-neli-wifi-0.6. > gnu: Add rust-chrono-tz-build-0.2. > gnu: Replace rust-chrono-tz-0.6 with rust-chrono-tz-0.8. > gnu: Add rust-from-variants-impl-0.6. > gnu: Add rust-from-variants-0.6. > gnu: Add rust-notmuch-0.8. > gnu: rust-gethostname-0.2: Update to 0.2.3. > gnu: Add rust-maildir-0.6. > gnu: Add rust-libsensors-sys-0.2. > gnu: Add rust-sensors-0.2. > gnu: Add rust-signal-hook-tokio-0.3. > gnu: rust-swayipc-types-1: Update to 1.3.1. > gnu: Add rust-async-pidfd-0.1. > gnu: rust-parking-2: Update to 2.2.0. > gnu: Add rust-futures-lite-2. > gnu: Add rust-swayipc-async-2. > gnu: Add rust-proc-macro-crate-3. > gnu: Add rust-wayrs-proto-parser-2 > gnu: Add rust-wayrs-scanner-0.13. > gnu: Add rust-wayrs-client-1. > gnu: Add rust-wayrs-protocols-0.13. > gnu: Add rust-event-listener-4. > gnu: Add rust-event-listener-strategy-0.4. > gnu: Add rust-async-channel-2. > gnu: Add rust-async-lock-3. > gnu: Add rust-async-io-2 and rust-async-net-2 cyclical dependency. > gnu: Add rust-ordered-stream-0.2. > gnu: Add rust-xdg-home-1. > gnu: Add rust-async-signal-0.2. > gnu: Add rust-event-listener-3. > gnu: rust-async-process-1: Update to 1.8.1. > gnu: rust-async-fs-1: Update to 1.6.0. > gnu: rust-zbus-3: Update to 3.14.1. > gnu: Add rust-pandoc-0.8. > gnu: i3status-rust: Update to 0.32.3. These ones I left for now in case another package later needs them. > gnu: Deprecate rust-nl80211-0.0.2. > gnu: Remove rust-neli-0.4. > gnu: Remove rust-notmuch-0.6. > gnu: Remove rust-cpuprofiler-0.0. > gnu: Remove rust-progress-0.2. > gnu: Remove rust-buffering-0.3. > gnu: Remove rust-supercow-0.1. > gnu: Remove rust-buffering-nocopy-macro-0.1. > gnu: Remove rust-ordered-stream-0.1. >=20 > gnu/local.mk | 1 - > gnu/packages/crates-graphics.scm | 88 ++ > gnu/packages/crates-io.scm | 1133 ++++++++++++----- > ...status-rust-enable-unstable-features.patch | 20 - > gnu/packages/rust-apps.scm | 100 +- > 5 files changed, 959 insertions(+), 383 deletions(-) > delete mode 100644 gnu/packages/patches/i3status-rust-enable-unstable-fe= atures.patch >=20 >=20 > base-commit: 36315bde09efa660d38198f666b4e1582cb71db3 > --=20 > 2.41.0 >=20 >=20 >=20 --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --FtRWwFvyEJPPYTyR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmXKErwACgkQQarn3Mo9 g1HA5A/9GWU8aMZ9PtiO9EVOXQ8+dGUFqYk8Y+px+IqyBjlnIbas7xRL88vROxpP aQUPQ0/kRm16YO0T14h8kGE4ndXErY0MNYkr9g5ufgrtL/7jx7XLL5OsUosEKceZ o10MUGla2LCE5J3A6usDoL2Db4lXvUcEEP5XDw6rqM7lkQuZWUkkq+tTls2kQmwh mfMasqRX7uWdiB8ONkqUlYL80TuD/aCtcq6duo0l5nEO6Ksnbb3XzcZuDuZxrXbC qqQhNNt16D7qlaebJ/2VDZm4uybQqY3/sjzBrl6HHksSWOU1suLqfGV6pFnoJtvh n2mIIY7Ne6KROikaz1D3O9I1njRcPvVymb4DrkLnAGdn+b1Y7Zagn5FDBZTrE1W8 j9ihbEFev+kO7uoPSC53z961aBcP2boVH8/fENdl5WXkmMgT2dDyvmXDXx55WpLI e4BdfnHObwjqnxQzhdou/gI5qVxC9uWOCzW3ByFmEgS5xdQ1C+cmLY4aPtUuSb9t auNBao0d3+iWkOx7d/OYd78NofYFrcMp7SH8eolK87JJOSDq4Y9vpVqMlX2v00Az dOIIataAI/ziH9Kf41ZAKzZcQwBAHRd5Ls5hK1HzwqE3Jwqx0lMRLaFHiGHPE0ia AJFLmGaOG+15yLH48NAFFNf0uT788kIXSDitWv6XJCEsLmmI668= =f4PI -----END PGP SIGNATURE----- --FtRWwFvyEJPPYTyR--