From: Tomas Volf <~@wolfsden.cz>
To: Fredrik Salomonsson <plattfot@posteo.net>
Cc: Simon Tournier <zimon.toutoune@gmail.com>,
Felix Lechner <felix.lechner@lease-up.com>,
help-guix <help-guix@gnu.org>
Subject: Re: Best practice when dealing with a broken package for guix home?
Date: Thu, 18 Jan 2024 20:18:27 +0100 [thread overview]
Message-ID: <Zal5g7uhT-PBgsuJ@ws> (raw)
In-Reply-To: <875xzq4j5w.fsf@d2.com>
[-- Attachment #1: Type: text/plain, Size: 2181 bytes --]
On 2024-01-18 17:59:23 +0000, Fredrik Salomonsson wrote:
> Hi,
>
> Simon Tournier <zimon.toutoune@gmail.com> writes:
>
> > Hi,
> >
> > On mar., 16 janv. 2024 at 18:41, Felix Lechner via <help-guix@gnu.org> wrote:
> >> On Tue, Jan 16 2024, Fredrik Salomonsson wrote:
> >>
> >>> Or how do you deal with cases when they happen?
> >>
> >> I maintain a custom Guix with patches on top, plus my own channel.
> >
> > Well, for what it is worth, I think the good practise is to send
> > contributions when something broken on master is fixed and not keep the
> > fix in your own patched Guix version.
>
> Agreed. I should have probably worded my initial question a bit better.
> I assumed that the package has already been reported by either myself or
> someone else and that patches for it to be fixed was already submitted.
> What prompted me to ask this question was [mpv-mpris][0]. Since it's
> been broken since at least Dec 26 2023 and is the one that is holding up
> my upgrade. And I'm not trying to single anyone out, I totally
> understand things take time especially during holidays. I just got
> thinking if there is a good practice to workaround it while I wait for
> it to be fixed. As doing any of my usual workarounds would require a
> bit of work as it was mpv that changed and broke mpv-mpris.
>
> [0] https://issues.guix.gnu.org/68044
Especially for cases like this, just having your fork into which you
periodically merge from upstream works fairly well. You can apply the patch
directly to the fork without waiting for upstream to act, and git is smart
enough to handle the merge well.
Creating the fork is bit involved, since guix git authenticated is designed in a
way to make authenticated forks pretty much impossible (assuming you want to git
merge), but after the initial setup (for which scripting exists) there really is
not much work required to maintain it (just occasionally merging the upstream).
So that seems like your best option (and what I do).
Have a nice day,
Tomas Volf
--
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-01-18 19:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-14 23:11 Best practice when dealing with a broken package for guix home? Fredrik Salomonsson
2024-01-15 1:21 ` Felix Lechner via
2024-01-16 17:50 ` Fredrik Salomonsson
2024-01-17 2:41 ` Felix Lechner via
2024-01-18 11:28 ` Simon Tournier
2024-01-18 17:59 ` Fredrik Salomonsson
2024-01-18 19:18 ` Tomas Volf [this message]
2024-01-18 21:54 ` Felix Lechner via
2024-01-15 4:55 ` Carlo Zancanaro
2024-01-16 17:53 ` Fredrik Salomonsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zal5g7uhT-PBgsuJ@ws \
--to=~@wolfsden.cz \
--cc=felix.lechner@lease-up.com \
--cc=help-guix@gnu.org \
--cc=plattfot@posteo.net \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.