From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:700:3204::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id eNEeBlzSnWWMFgEAkFu2QA (envelope-from ) for ; Wed, 10 Jan 2024 00:10:20 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 2AUpOlvSnWWJOAEAe85BDQ (envelope-from ) for ; Wed, 10 Jan 2024 00:10:20 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=wolfsden.cz header.s=mail header.b=LiWtiaCL; dkim=pass header.d=wolfsden.cz header.s=mail header.b=LiWtiaCL; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=wolfsden.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1704841819; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=HxiqEApl9XmYWfVaF3yIM61KysyUrwCWU478fFuyJFE=; b=iriWPBS9JdPr6PdbAcN8vXAhIUX5/uzmJZ9eZB67mFTO1BhueiigrP0mVLuV5bQjXyFITa piY36rQbWTe7Xehjbh0PBBcTXQLx7oxGKyHJBnTAA5X98HJwZZx0eA8LzBfTZatRDFuof9 wwEt27FN42iwz+r6mk7VT5wfwCg4wfLPl5UwxYNa4qnBDBXiyKS7hDYVnia2O/roS3uCyW CZsJtdQD71QB5oU0uANNKKriUL1tsdVldyd0Veuog+WNvRVjNXIIw21RWo7m6JoVhKVwP4 E9Xwo5vrkqQstARfxszYoB+PXbVz9LbZg7x/wdCVUw163W2s41BkAG+ewFDC0g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1704841819; a=rsa-sha256; cv=none; b=kvg/ZCe6aHNJO86n5a02+zIjF/td7xqg2aNd4//nfaxCvi+NzOSyct7smGIqt99mgS3vu6 PeKjbCYRSB8fDdPd4UE24aQbqJTOlsLcsr3IaZMJO3B/UU3Q8DCa5c8Q7/z8s2PS2VoeIZ 3Z704ZZH+sPAkG+JAYLiKGl1Wz5ycLaSqq9IHgkrAGwXSMmOIkCLxmLRk5ILHT9wKeBue5 /MmZqaa1iPuMhSe5+Ph7BGVxoCsn0iDGk4GXf6eY1tB8rfnFiCYJ5pMNDkFv6DrtUIpJdH VUc1VyIA5Qb+MhPKWalFlXQwZ6K7ykh32+P0bLpKI+GTS+xJtXOUs+CixAIPLw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=wolfsden.cz header.s=mail header.b=LiWtiaCL; dkim=pass header.d=wolfsden.cz header.s=mail header.b=LiWtiaCL; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=wolfsden.cz Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CA32A3AD2B for ; Wed, 10 Jan 2024 00:10:19 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNLDo-0004C6-GM; Tue, 09 Jan 2024 18:09:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1rNLDl-00049W-7o for guix-devel@gnu.org; Tue, 09 Jan 2024 18:09:21 -0500 Received: from wolfsden.cz ([37.205.8.62]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1rNLDg-0006nU-9h; Tue, 09 Jan 2024 18:09:20 -0500 Received: by wolfsden.cz (Postfix, from userid 104) id C8EAA24E881; Tue, 9 Jan 2024 23:09:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1704841749; bh=bzlUfuuFge0e2Xqs/ZcxDLxw70D9g/uD9BLi9wzEGGg=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=LiWtiaCLj86mJE4e6zP7ynIqmzjK+rOX9MuqyjubIyD/PpNClbpPdzgPKYnFsQgIX YU2nzVKVinv9gSpNYBd4wKD89gQXn0jlK3npkhx4W9I+M8dJKOyEZnWjjkApyYwRNf ZT8U5U2O3dpSXe/Ol85BNXcfPLPo5bVctjxn3FfMGmcwvDh57aRDMFBDtrgi1UkOmf SYUSrrMkOhN3f21f/LCdPC0wlM4D3J/QErwmHk+ofTbdOOzeFQs5KCE1kbJeMJJK1g AcoMEV1jfvrv3bD3ds3hoOgsqgViuvve8lcQYsJByKZiFWJJWKATnbmi7DBhTe9/n+ kHFyb2mlbTUTq00kvw4tq5/TkPPynpFhR9ulk422Wo2tRHlquotzNZsmS5pf93MJYx ARimnwy4NrxaPywutJwDdsIC9I5g1qNThWMKPlgY+uGI13of6PVqgD83Iy080+0A2e clQcp/xWIKNAawihOvek8W9xpmp+hhOn2ZzLrYTTz+oac5O78PkN5xWezOtwFWkmgO 1ldP/WMg+LX7JAY/onvws9353oajRS76o2APANqfb3Hlqfa8ZFUKHlKZvqAAwVb6xq 8nE5ycw1ZAUo63mJMKiPdMY7Hcd9sDnM/OOtCXJkBIJ3IzdMCc/q3F7y33adgXu5DO UOS9sRvyGrkMvegD1fnDAw08= Received: from localhost (unknown [146.70.134.143]) by wolfsden.cz (Postfix) with ESMTPSA id 1846A24E41B; Tue, 9 Jan 2024 23:09:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1704841749; bh=bzlUfuuFge0e2Xqs/ZcxDLxw70D9g/uD9BLi9wzEGGg=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=LiWtiaCLj86mJE4e6zP7ynIqmzjK+rOX9MuqyjubIyD/PpNClbpPdzgPKYnFsQgIX YU2nzVKVinv9gSpNYBd4wKD89gQXn0jlK3npkhx4W9I+M8dJKOyEZnWjjkApyYwRNf ZT8U5U2O3dpSXe/Ol85BNXcfPLPo5bVctjxn3FfMGmcwvDh57aRDMFBDtrgi1UkOmf SYUSrrMkOhN3f21f/LCdPC0wlM4D3J/QErwmHk+ofTbdOOzeFQs5KCE1kbJeMJJK1g AcoMEV1jfvrv3bD3ds3hoOgsqgViuvve8lcQYsJByKZiFWJJWKATnbmi7DBhTe9/n+ kHFyb2mlbTUTq00kvw4tq5/TkPPynpFhR9ulk422Wo2tRHlquotzNZsmS5pf93MJYx ARimnwy4NrxaPywutJwDdsIC9I5g1qNThWMKPlgY+uGI13of6PVqgD83Iy080+0A2e clQcp/xWIKNAawihOvek8W9xpmp+hhOn2ZzLrYTTz+oac5O78PkN5xWezOtwFWkmgO 1ldP/WMg+LX7JAY/onvws9353oajRS76o2APANqfb3Hlqfa8ZFUKHlKZvqAAwVb6xq 8nE5ycw1ZAUo63mJMKiPdMY7Hcd9sDnM/OOtCXJkBIJ3IzdMCc/q3F7y33adgXu5DO UOS9sRvyGrkMvegD1fnDAw08= Date: Wed, 10 Jan 2024 00:09:08 +0100 From: Tomas Volf <~@wolfsden.cz> To: Ludovic =?iso-8859-1?Q?Court=E8s?= Cc: guix-devel@gnu.org Subject: Re: #:modules and #:imported-modules, and more Message-ID: Mail-Followup-To: Ludovic =?iso-8859-1?Q?Court=E8s?= , guix-devel@gnu.org References: <878r4yxgua.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="BllGaYTOQnwPCW7D" Content-Disposition: inline In-Reply-To: <878r4yxgua.fsf@gnu.org> Received-SPF: pass client-ip=37.205.8.62; envelope-from=~@wolfsden.cz; helo=wolfsden.cz X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -9.97 X-Spam-Score: -9.97 X-Migadu-Queue-Id: CA32A3AD2B X-Migadu-Scanner: mx11.migadu.com X-TUID: v5q3k7WP4y5+ --BllGaYTOQnwPCW7D Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2024-01-09 23:49:33 +0100, Ludovic Court=C3=A8s wrote: > Hello! > > Tomas Volf <~@wolfsden.cz> skribis: > > > As seen in the example above, currently there is a need to manually > > merge the list of additional modules with the original one. Failing > > to use the correct base can lead to issues (like crash in netsurf). > > > > I would like to propose adding two new fields into the build system, > > `#:extra-modules' and `#:extra-imported-modules'. Those would be > > automatically appended to the `#:modules' and `#:imported-modules', > > removing the need to merge the lists in the package definition. > > Therefore the example above would turn into: > > As a rule of thumb, I personally always avoid the #:extra-things > pattern, instead letting users pass #:things in their entirety and > documenting the default value. > > I believe (1) this is clearer (when I see =E2=80=9Cextra=E2=80=9D, I=E2= =80=99m always like =E2=80=9Cextra > compared to what?=E2=80=9D), and (2) it gives more control over the thing= s in > question (since one can also remove stuff from the default value). Well you could still remove the default stuff, since the "non-extra" would = not be going anywhere. > > So yes, that=E2=80=99s a bit more boilerplate when all you want is import= one > additional module, but I think it=E2=80=99s overall a better interface th= an > #:extra. > > I hope this makes sense! I see your point. Not sure I fully agree, but do understand what you mean = and will not push on it further. However even in that light, I still consider the 3 and 4 to be worth considering. Aaand even without 3, at least doing 4 in some shape or form = would be in my opinion useful. Current situation is bit... copy&pasty. Tomas -- There are only two hard things in Computer Science: cache invalidation, naming things and off-by-one errors. --BllGaYTOQnwPCW7D Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmWd0hQACgkQL7/ufbZ/ wakgww//aROy1QI/sHM9AZnK2P0dfUlKONmUgDuzp+yX3ne1ZYjOWyTqd0MO77cW xYLPOdlVQVEvLSZ9+hOfKA1Gz1i/ZM0ayKphjy1UWi49vpWFCnsuH4wqu8avGiTM KJ221o228IovduO+rWRlQ/b4DJ2T8uu5EWKjIUmMgTfpSmYVgJ8jnNo8jkF1X0lk +gsOgiGTDaf8+R3nInyqSdi7Ji4TaYYf3NpjO4U0r9vQS7wxh0Asrd2WoXla3yGY 2gZLzhcAgD69zERsguRvIKLhZKJjl7oILvhJ/PQFBruZM6KqyvKBsGw/sdj6sMJB HxmUbb7eCDiVbD1KqMYps5loiYIIR/IRCjoecv1EY6sO5HCrJ8mmaofg0nY9kfEt sIF3fT5DGNM0dUczSlS65qXTontQabaIPOy1FYR4uklXhU+f9e8CXIUkcHkafMWQ yGRXL9ALz3QegaR8/OiEAOqkcBVqbW8RjS0kkF2sW3aNgnDSB1NDWsEVYS0ruVpy geC8e+lXn/x7gap0koBgQzDuEZZd94FSFgpAeSBlrd0MevMADTzJKMU46aj5Yv9w NUETOPUIj/J6pfcKKf2O76cOumFgAgUTyAi/YIfM/r7VXdPlpFzfZ8Kx45Bsz023 S4BamBNU0EuS/JX3loMkDkuJYksqQjp2i/9qiF/t2u3b0WQCG6o= =Rm+8 -----END PGP SIGNATURE----- --BllGaYTOQnwPCW7D--