From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id qD7SGQ1DcmVrSAAAG6o9tA:P1 (envelope-from ) for ; Thu, 07 Dec 2023 23:11:25 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id qD7SGQ1DcmVrSAAAG6o9tA (envelope-from ) for ; Thu, 07 Dec 2023 23:11:25 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 344DB60ABF for ; Thu, 7 Dec 2023 23:11:25 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=wolfsden.cz header.s=mail header.b=CBziv2TS; dkim=fail ("headers rsa verify failed") header.d=wolfsden.cz header.s=mail header.b=lvNfrysg; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=wolfsden.cz (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1701987085; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Ysv0Zvci+jzya5MUGWM52Nz92s85oo3FHBiConJTC3E=; b=ouE5usRsyrj8pgViZDvHzYgFYvMOmG5fxVqafpNazom8x7q5nZSWk4CQT/d3cQaW2ObPCk yYsuOBVm8gVNfxIspPWb0ODB/pFaVfU+IFiSnBhEjgXeLg/Xrp86uqFTNCB1VkqKUWVepl zMQJxjXcxRp9JDa9nFQGUlHS4VXrldv3vjMRZLvo6vP7DVYlKUKXm6sGTO34fppMb1bRz2 GQMZ4+i/NdV4hDQ//AJx3Dd1hlZgJRTs+46nMtM6ja+Hffjrxf8/sUykwd1DL5jrOgoFSD YLOIENMA4VN2L/uWVbSP1FcntiZGgxPZAPfRtRz7v+QW1dkDgzIUieCofzkN9Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=wolfsden.cz header.s=mail header.b=CBziv2TS; dkim=fail ("headers rsa verify failed") header.d=wolfsden.cz header.s=mail header.b=lvNfrysg; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=wolfsden.cz (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1701987085; a=rsa-sha256; cv=none; b=u4k+3jj/HjQrGENUxayVR1Tp1KEamUIy4BHy2qZjF0Wo/TDP1HKHbr1OIn0UDgxeGz948x NZUWG66zTcQ0wDSe2iQauPWTN7pTnI7JAHw/aSujx5O2Kkr/yS4hK5xhphAanVW8kcZcj+ 2NypGY2fWxPeI458g86xuunAOdRoaq8yY6cuACZpBT45v9O31+p8AhUsrzw5TKUpoemnS2 zgITCyPf5mbTuOEN6pqvA1SgsCcb2RObfbm5OBIyYhcctKwciyqQqri90icLggaAtmJp+u 8vyAMftqu8qcey9hNnLvyZbuvsFc5nACrhz/3wF98wGKtNPCl+th9DKl+XVV/w== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rBMaB-0000mz-Fl; Thu, 07 Dec 2023 17:10:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rBMa2-0000jI-Kq for guix-patches@gnu.org; Thu, 07 Dec 2023 17:10:54 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rBMa2-0002Oe-Cy for guix-patches@gnu.org; Thu, 07 Dec 2023 17:10:50 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rBMaE-0005C3-UG for guix-patches@gnu.org; Thu, 07 Dec 2023 17:11:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#67686] bug#67044: C.utf8 locale cannot be built Resent-From: Tomas Volf <~@wolfsden.cz> Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 07 Dec 2023 22:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67686 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 67044@debbugs.gnu.org, 67686@debbugs.gnu.org Received: via spool by 67686-submit@debbugs.gnu.org id=B67686.170198700319870 (code B ref 67686); Thu, 07 Dec 2023 22:11:02 +0000 Received: (at 67686) by debbugs.gnu.org; 7 Dec 2023 22:10:03 +0000 Received: from localhost ([127.0.0.1]:43294 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBMZH-0005AL-5P for submit@debbugs.gnu.org; Thu, 07 Dec 2023 17:10:03 -0500 Received: from wolfsden.cz ([37.205.8.62]:37578) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBMZA-00059J-Uz; Thu, 07 Dec 2023 17:10:01 -0500 Received: by wolfsden.cz (Postfix, from userid 104) id AF5AC25BA0C; Thu, 7 Dec 2023 22:09:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1701986982; bh=WZsl582T5KvQmRx1U/BBg9YbKjbIfThkskuLf5mHBjA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=CBziv2TSKuCbUZ1G+mkSolUch7AuEA/408imXZhS1fZmugNb31bYuoSkZsz2PoqZZ YkMr+HCiPUnjMua0vjebYdUgiDsW/7+HaygOvruNLJ34s9XM1ZfmjA5SSQj4Me+ZtQ 3g5e94CENz3xvUXW810nYdKBC+9myl8WOdFuzy4olkvb6uePiuuMrmKKO5GG0hrObx 67BisVsj8lC28dkVnYvJ9WIAxbMF9Y0S4Shm8UCiwLSCAySex32IEaeNkCreJ9OrPf Llv5g36/MFrWkNBX2uLNOq+hC4LYEKjXQnlje6JdDtpTHnlvYF3wzwZMMCc8FQ9Wr6 3QvDJAojb+NV6lcVlglPjw8cZ8lHS/zeND4N83HkQrhQ+mIX2HO2rdONqPv639ZuCh 2fhBrwYpTvExDlEdmuSrCbNcMnk94hyGobJF/0TqiA1QorzeiXwDAcoDwxCmFkcxjW sNJ2Ot6qsmTgpz+z2Yemb5XtfQWFIo6seUfN/ecfBPcbrXUigWnexWKqIP04S0VmD6 GsccmcHyKKUtg2xSGyHBvbGr/9gSXYwMkftSW5yaDvOS27+VPseXkSYMV/eu9TsV6m d9mxYXOPUrgWR3MR1Dg68+QaKbMnPBu+3wHPNZpeWMqsqL+WmbLaTeWycz6+xZAyDN FuGIJWSKUQ8ZcJJ5GwzXgR+M= Received: from localhost (unknown [146.70.134.143]) by wolfsden.cz (Postfix) with ESMTPSA id 776D825B2C8; Thu, 7 Dec 2023 22:09:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1701986981; bh=WZsl582T5KvQmRx1U/BBg9YbKjbIfThkskuLf5mHBjA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=lvNfrysgLEEhNIpcfIoq3LJBsfJ7CuI0R/1s5ZtRpx0V8rR5tJYzi7Xzjy1sCgO6/ L1VQYpC1J8/+dRRxSXB/zuoTaQBKElkDrjYbu8nfgemk+jZA0HS2JKNycMnO6anGef ePMADphNCzNy7kKsi2ST/GUyy8L3rP9ZDQ50gu6BLQlzhMvYg3LHdFGX5ag73uWJxJ QM8YYzBB4AMgYX13lbVg8iX90WEDQPSIN0KJcp9hITkpO0gs7OU2zqsqLPwaWDOrHu EEhGrc5Z0EdgPar9p1CLhIZ7cyuIE2CrjETZB0HLUovI6tVDkilD1fH5iNITowpBK8 XMT63fvre2zmL2/sel6iyUjhn1Jw1a+K3aQ2aCQyWLg6hvmd5Aumt9Om+OgJfkK3GL LH8YHP801F2mlrypZ4sqTGp84QyQdpwMtsfKV15+q9iBKdwHY8ei6UHC6da6f81w6p wQsr/eNVGQOhD2GrrARe+nAt2zvw1KCYLX4F0bHsF2n41kzMI0h8x1PK575kB+O1+v vL0YC7BZpoh9+TG7wb/JZ24dpdiQTYPjOlgC2dMuR+/QqRAR15Rymt379FZ9eaWkay NDy+qL43Lf9fiuny6lQiSL3AP25TJbDsZ8Jnmf9uplgrDc5UDm0wSpNcGPywfu5esM AuD9DXA/insHT5xX82ErVYnM= Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 93edc5b3; Thu, 7 Dec 2023 22:09:40 +0000 (UTC) Date: Thu, 7 Dec 2023 23:09:40 +0100 From: Tomas Volf <~@wolfsden.cz> Message-ID: References: <87bkbex3bh.fsf@gnu.org> <87zfyme29z.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="IzmMhgESxZ6g9MVl" Content-Disposition: inline In-Reply-To: <87zfyme29z.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 344DB60ABF X-Spam-Score: -6.65 X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -6.65 X-TUID: RH/tuvN6J562 --IzmMhgESxZ6g9MVl Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi :) On 2023-12-07 11:27:04 +0100, Ludovic Court=C3=A8s wrote: > [..] > > I decided to give it a go: > > https://issues.guix.gnu.org/67686 > > Please do chime in and let me know what you think! Thanks to the detailed cover letter, now I understand the benefit, so I agr= ee it would make sense. I looked over the implementation, and it looks fine to m= e (I am not sure if I am qualified to do the review though :) ). I just have few notes: 1. > (glibc-2.35)[arguments]: Delete =E2=80=98install-utf8-c-locale=E2=80=99 p= hase. I do think 2.35 should install the locale as well. That would require to c= hange (invoke (string-append bin "/localedef") "--no-archive" "--prefix" locale "-i" "C" "-f" "UTF-8" (string-append locale "/C.UTF-8"))))) into (invoke (string-append bin "/localedef") "-c" "--no-archive" "--prefix" locale "-i" "C" "-f" "UTF-8" (string-append locale "/C.UTF-8"))))) however I think that is fine. I am using locale built like that and it wor= ks well. What is more, from the discussion under the other issue[0], that is exactly what is done during normal glibc build: > It turns out we ignore errors during the glibc build (--quiet -c). After that the drop of 'install-utf8-c-locale can be moved into some other version < 2.35. 2. I still believe it makes sense to add the -c also into the locale builder, because my understanding is that this change will not allow using (locale "C.utf8") in the operating-system definition (since that would still try to build it, and fail). If you are not opposed to the idea, I can send a patch if you would prefer = not to do it yourself. 3. > I suspect libc builds an additional =E2=80=98localedef=E2=80=99 for the b= uild machine but I=E2=80=99m > not sure where it is, hmm=E2=80=A6 I looked around a bit, and I am not sure that is true. There seems to be o= nly =2E/locale/localedef created. However, there is localedef inside gcc-toolc= hain's bin directory, and, of course, in the build glibc. I am not sure what are = the version requirements here, but I would expect at least the one provided by = glibc to be usable. Have a nice day, Tomas 0: https://sourceware.org/bugzilla/show_bug.cgi?id=3D28845 -- There are only two hard things in Computer Science: cache invalidation, naming things and off-by-one errors. --IzmMhgESxZ6g9MVl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmVyQqQACgkQL7/ufbZ/ wan7vA//RKpYBFeFpE6FNHWrCZwPhxNy/d/lna/1TCPdf1smFe1cwvkwGthh0DJF l8sqd9U5faEUeY58vpzZRHZ0kUJHfMKbzEzzCrB1OV8uw6fkY8RYVy9rRdSS8vrZ R3SKbFcYo8zHBcVGE2pve1MAY48TyqJY+EHOfz7XAb3osOMJt8E/JjSSmhBB8k8c 9cY0wUbACuTmViFagniR27/y3n3TAr3BHRDWRCXLtQx24/JjcQw8uWKFljemTwSk BHiNyzXxv1ajr63Bfy5txFSRmn2MkubOmohFjkTwD9ApG/J7VMPiRLS22mPgSv98 1qB9/BzQ/s/4ktP+V2+jqrvZRe33b8b6brHpwd9P7eNKvjcERiG6kyu0d3Otmbnc MsoCChne0Ao9gdKfkwJZq16aktpDCuyHXAP8jdvy1xLjREMInM2lmV+yR7EJJ7vE Srt05ckoFoPAvPSUEyCJNPC5i07nmEn9oODSXuZHpDWd1I1n1m27jgRzIT69j8Ua l3Hfi4xruGX+FsMaltrqPKnjRNyfseOp0CXhddZv8Lo8XPKh7wrdHG/7o8PF3pN1 KLbZFEXU9F8bAkK0DV3UNdDIKAH7R131ZsyjvPhG0UFknEXCbUJy1wLxiqlwYaJd yD++ZP+ZN4s+jtqmjUlbP1cEZFyffmYc1R3JQ8+mIHa2FcD515Q= =o7Za -----END PGP SIGNATURE----- --IzmMhgESxZ6g9MVl--