From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id KFMmIt5ocGWd7AAAauVa8A:P1 (envelope-from ) for ; Wed, 06 Dec 2023 13:28:14 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id KFMmIt5ocGWd7AAAauVa8A (envelope-from ) for ; Wed, 06 Dec 2023 13:28:14 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5227D58C1F for ; Wed, 6 Dec 2023 13:28:14 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=fvIImndK; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1701865694; a=rsa-sha256; cv=none; b=Hh6BPyk/jSxFQEgxpZjPwuDVunqISwBs6TN/2ipOyadTpj4XsML+1njUhyZ+8qkGYMGPrA g7pzMhdFt//uiNkoU240M2kNU0pi6byWEWtb+llxuFyhQU2XSAfHXusr3M2Xn25bS7Z4Us OdBVYF+y5tBnHmeNenSNjI7kRsz3kIyRPEOkvozFJxBvMo3ZIcvciYDErd7maeGAcqVXWq 5GeDRb82TvsFDZoLYgrEkCj1dBIRwv6S1RflaZ00Z2pXbY15CVRse6rt+6NhAUTXii6fhV F5kRv4rrRFAWE4nvq2DrhPnGElo0nCHFSw0xGPx/kBEW/2TjlBcbEbr4zuxJIw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=fvIImndK; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1701865694; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=tmt0jQ98c89F8LAuMUZJFmC3nCBudQNV0b94uySDIS0=; b=KZJRfz25SgQ6MugM6Uvj7jLjhUWwQcQ1p1JurvUKR6Pxf2f1+83jD6cDzCfwVefKU5gF5T cREWSc26n7Hn5mHn0nFw/qSRn7xmEIiudA1tI6wsvS/mqukTzjTwRLNfpTPPiRk2PQek5k KRqhLBfPviCYsanpfS1+haEKKTz3vFM3phSbxtvOFzvqJAJBK4ysR8i3oSUzHN/U25WVsZ SZmwEhefmftknXZO77Mnj/DZcGWR13alszA0Pnc//zRUr8IdOb7vxVOORnKwEofLEhww9O SSjXXbs9lv81/Mm5upPmol/O4jLpCXWRGIGWk23NUTYWzGaSmgEJjtBoj753Iw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rAr0K-0000zA-U7; Wed, 06 Dec 2023 07:27:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rAr0I-0000z2-Tp for guix-patches@gnu.org; Wed, 06 Dec 2023 07:27:50 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rAr0I-0004tY-L2 for guix-patches@gnu.org; Wed, 06 Dec 2023 07:27:50 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rAr0U-000747-8Q for guix-patches@gnu.org; Wed, 06 Dec 2023 07:28:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#67505] [PATCH] build/go: Don't use set! Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 06 Dec 2023 12:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67505 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 67505@debbugs.gnu.org, Katherine Cox-Buday Received: via spool by 67505-submit@debbugs.gnu.org id=B67505.170186566327131 (code B ref 67505); Wed, 06 Dec 2023 12:28:02 +0000 Received: (at 67505) by debbugs.gnu.org; 6 Dec 2023 12:27:43 +0000 Received: from localhost ([127.0.0.1]:39019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rAr0A-00073W-QY for submit@debbugs.gnu.org; Wed, 06 Dec 2023 07:27:43 -0500 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]:58628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rAr08-00073J-Id for 67505@debbugs.gnu.org; Wed, 06 Dec 2023 07:27:41 -0500 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-40c0f3a7717so28328145e9.1 for <67505@debbugs.gnu.org>; Wed, 06 Dec 2023 04:27:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701865643; x=1702470443; darn=debbugs.gnu.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:sender:from:to:cc :subject:date:message-id:reply-to; bh=tmt0jQ98c89F8LAuMUZJFmC3nCBudQNV0b94uySDIS0=; b=fvIImndK3B3kgtV2TnKpV7iRzsRQESq8V2IG2X6VoE7mo4W/quBFXXWzpIjDvtgMkI 6O1WvlELOUa+yheGIamKf7GyZpS2JXPE6dTb9Rs4kASbOE5Y4bkHfTDc3oRvP7EYm7mR r1ZP4z96Q0uwWYH41YjkSN9M3jyoKoKzMv8R1fmon4PW+XxXRD+UgZac4o70/QLVurTI bISVzLbj9aKpLUrTggqjyekVyIKzUdwp4GJn+pTFW1UQAjFydMb40k6qCpJruZu0fbMD xP8GJgiI9odDT8K8xMsvKN8cq/PvMfJitnOYMJt70TwKaijlZ7fGgx76sHtwKzT9KkAY w3yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701865643; x=1702470443; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tmt0jQ98c89F8LAuMUZJFmC3nCBudQNV0b94uySDIS0=; b=iz3GZGHWQ/GlXMYZsO9frAFqM2LpIJXugUW9kosxJHqsqDsZaueHL1lGTn9D8XHk9K +vaa9F7JSSwpkaXFNXtsLJLtQZCFNle+fC8MsB5sSnzgas2h5GaAUiP8asJEQAiJramL FcRR5F/I1sYs+2dEkY6QhP3sdIIEjrw6INRIfUDV9HCch4a/0LBbT0pa5uda9WKprBzx rzdNB45pjtv8677iJ1xP9pncTuAxcvA1xg8kBKNTrh5cTXDCu9YKT9CxIQY+/s8TmNvV BHVvUSerayHOQwzIH6S+h2dKwghM7kxbZQYjrSl37cPanpBagqPE3Om6Jj6wyBPA9u3n zSTw== X-Gm-Message-State: AOJu0Yw3C8XuP12y61+sYjr87H7MQwZZjfX0J4pvTratW5WiRlbpnpyr zkFR7Y4QafuY9Pt6yrNELGc= X-Google-Smtp-Source: AGHT+IENzx6FCQhbIj6niqkDWO6G1coXGa4Mlhv184DowJo1v5xWhD4XetKF4esPqISdpbERRSRQ/A== X-Received: by 2002:a05:600c:4a83:b0:40c:2061:dee7 with SMTP id b3-20020a05600c4a8300b0040c2061dee7mr223474wmp.130.1701865642753; Wed, 06 Dec 2023 04:27:22 -0800 (PST) Received: from localhost ([188.120.129.233]) by smtp.gmail.com with ESMTPSA id hg10-20020a05600c538a00b0040b398f0585sm22058031wmb.9.2023.12.06.04.27.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 04:27:22 -0800 (PST) Date: Wed, 6 Dec 2023 14:27:20 +0200 From: Efraim Flashner Message-ID: Mail-Followup-To: Efraim Flashner , Ludovic =?UTF-8?Q?Court=C3=A8s?= , 67505@debbugs.gnu.org, Katherine Cox-Buday References: <92508cd851b013f54a799350082f49b157c7aebf.1701167049.git.efraim@flashner.co.il> <87jzpuewbk.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RkHi6oTk7q4pYf68" Content-Disposition: inline In-Reply-To: X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -3.75 X-Spam-Score: -3.75 X-Migadu-Queue-Id: 5227D58C1F X-TUID: e6BF3SyM8QGx --RkHi6oTk7q4pYf68 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 04, 2023 at 11:53:58AM +0200, Efraim Flashner wrote: > On Sun, Dec 03, 2023 at 11:49:03PM +0100, Ludovic Court=C3=A8s wrote: > > Efraim Flashner skribis: > >=20 > > > This causes build failures on powerpc-linux. > > > > > > * guix/build/go-build-system.scm (unpack): When the unpack-path is un= set > > > use the import-path but don't redefine the unpack-path. > > > > > > Change-Id: I2b5a36eb738abb14307941d388038139dbaf2bdf > >=20 > > [...] > >=20 > > > - (when (string-null? unpack-path) > > > - (set! unpack-path import-path)) > > > - (let ((dest (string-append (getenv "GOPATH") "/src/" unpack-path))) > > > + (let ((dest (string-append (getenv "GOPATH") "/src/" > > > + (if (string-null? unpack-path) > > > + import-path > > > + unpack-path)))) > >=20 > > Could you adjust indentation of the =E2=80=98if=E2=80=99 arms? > >=20 > > Otherwise LGTM, thanks! >=20 > Done. Patch pushed! Patch re-opened. I reverted it since it caused ~4800 package builds on Berlin. I'll probably carry it locally for now (I'm almost certainly the only one affected) and we can apply it another time something touches go. --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --RkHi6oTk7q4pYf68 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmVwaKgACgkQQarn3Mo9 g1FL0RAAnZOeJIhtF3EHus3PNv7fwqnY5ItE0L0XBGzf4cpnMegnjQ4n3K6hje5Y j5PfnTnUNHC7zKbqXrum/lpQEAI7WfG4vow2i2ejEh95vrxLBujbC0ccqd+8rZBp TZtd3C+Vltyz+fPoBe0xz9DP1JRtsCQtJIocHJssGc9n1JQOZerMMyJG9R+kxXkl gadsF3BHb5+wjB91dMRKGGhto0iJ0xISh9/U/62qaY74tvERcTRB3CHgeS/2HyrH i0TYmaieFw3GX3BUH7dCa6TYE1jH7t6lxcYX/4Y692XoWr/+6/rHLvufKSbWTrw2 0puiM1GKYwT4E5fsfY8VUkE0YrolploE3kksw1VOJ+8VsNOdSOmmutdkAQxKfHWo /gluuWVv33L3XPR4XWrasLg5kRPah7+ILm0xNs1VrXC2Xacat0nYiWYvfsuMbixi AwcF0hOMtIv4H/iCO8vHgH/NF7mKhzjIn3UQqEkpo2W5S95H2Qg5orffyM8BLlJ/ jzcptpAhEXLckvOMlJNZI4b95+5uBVAsSIFPK69lN4XYbeLBi+OJAI2ALwBEpWpG XQM24yBbp5IN3EQsuAN/P8b4pcM8OWeks/QOQYVmG4ALB7qgYomEixr/Jhq99uoH 63GmA0YLds20PeHAG3CwT4zghlHYw/Qde4DdHgPFCojBG0yoDzM= =U2NR -----END PGP SIGNATURE----- --RkHi6oTk7q4pYf68--