From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:700:3204::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id eIMYHoQefWVESwAAkFu2QA (envelope-from ) for ; Sat, 16 Dec 2023 04:50:28 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id WFHeGIQefWX18gAAe85BDQ (envelope-from ) for ; Sat, 16 Dec 2023 04:50:28 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=riseup.net header.s=squak header.b=QVFH09dL; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=riseup.net (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1702698628; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=iGt31b4051XQYCqd82zoYW5IYk+ryJAwQbWhnw59Bcw=; b=Sp265TlKaEJoLdNgM2rUJKkhNkZNlcV+F5J8C3tbo73dNE5BFblvNph+BqQLyNSfa1Iaeo +lCG3QZ1Ba4DSsuyQiMk4OtJTdGGw36IlUgxz/mWqToAFuCCiO8rflRpEQIkOcOFLFdqoY jERFDLA5PRwXgsxHKrgW9vQ/J+rbazUVDzZY0vTNpQ39nPu4quwGA6+yFem6Mls2+oiEOb 5WSL+VL7915Ufbm3LKOEKu9QFNdOQ3cDoD6ov4/h9aaiV/Awwl0mqY05iIfLZx4ZQ3y9SB WeN+y7W3zwwTZFH0Qmrs8LDD9zRxK+AJSpt7L9O38nm6hXT4SZ9ExbciGCPBNg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1702698628; a=rsa-sha256; cv=none; b=HCrPOllWg6XsRMpO8xDNkonhpXugOOW4C2rB4kW65DFqbSpdjD8W175OxmwuQX5ItXVPu0 JXazDkM4ob5evqgENHSXv5REdsNmFfGvEx6/a27JnaNoLfVFV7qA0JsbSF0bi9/V1owj+B 41jMiyuLSB6DVpCkdX7ioofMK7wcYCee0k8X8FDPzNbGExjJPOQGGlSZbkcTXqxeOOYaeV D6MyDJgzOE+9gJ1uq3SSGWiGEVJ1kgHg+bRWUaCmL6lERsRyWuDF3Zo/uGQ4fPxRwemV9T +ekHHOd6Rlieno2YHLSV2CIm9/808yWZ0i9PWQO823IAGNx9tdBtOaoy7SHu+Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=riseup.net header.s=squak header.b=QVFH09dL; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=riseup.net (policy=none) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0B6B211B51 for ; Sat, 16 Dec 2023 04:50:28 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rELgk-000667-6W; Fri, 15 Dec 2023 22:50:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rELgg-00065g-TR for guix-patches@gnu.org; Fri, 15 Dec 2023 22:50:02 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rELgg-0000ms-Kf for guix-patches@gnu.org; Fri, 15 Dec 2023 22:50:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rELgg-0008QH-EA for guix-patches@gnu.org; Fri, 15 Dec 2023 22:50:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#42380] [PATCH] gnu: Add torbrowser. Resent-From: =?UTF-8?Q?Andr=C3=A9?= Batista Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 16 Dec 2023 03:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42380 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Cc: Raghav Gururajan , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Maxime Devos , Efraim Flashner , Leo Famulari , 42380@debbugs.gnu.org Received: via spool by 42380-submit@debbugs.gnu.org id=B42380.170269856532283 (code B ref 42380); Sat, 16 Dec 2023 03:50:02 +0000 Received: (at 42380) by debbugs.gnu.org; 16 Dec 2023 03:49:25 +0000 Received: from localhost ([127.0.0.1]:53834 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rELg4-0008Oc-Ky for submit@debbugs.gnu.org; Fri, 15 Dec 2023 22:49:24 -0500 Received: from mx1.riseup.net ([198.252.153.129]:33980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rELg1-0008OM-MC for 42380@debbugs.gnu.org; Fri, 15 Dec 2023 22:49:22 -0500 Received: from fews02-sea.riseup.net (fews02-sea-pn.riseup.net [10.0.1.112]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx1.riseup.net (Postfix) with ESMTPS id 4SsXBz2nGxzDqPQ; Sat, 16 Dec 2023 03:49:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1702698555; bh=xz7iZ4q+G/Zme1ZkdgkwJCHvV6j3UWrVSYNNGc7mCJQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QVFH09dL9LK6YHV+D0qqmc7EO3PvDqB4WtOBz0zTXuLxZ4Z+y+TzZ+plPDrnj8kbS c7Ud7AKoZ7dwjC5ezU4QcCS6FNJ5yKcWcmZ72NZoQqekIarw2ogdC1asJ2sDnGmdAk tq+yEhUcq8Chnwb0pabYA5jE3b0J4QtqrDnVPArQ= X-Riseup-User-ID: BA0E67D8A8DA44901F1114C53CCEF82D516E4C57A831C1BEC7AD5300FE61F903 Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews02-sea.riseup.net (Postfix) with ESMTPSA id 4SsXBy1BSKzFs1M; Sat, 16 Dec 2023 03:49:14 +0000 (UTC) Date: Sat, 16 Dec 2023 00:49:08 -0300 From: =?UTF-8?Q?Andr=C3=A9?= Batista Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -4.70 X-Spam-Score: -4.70 X-Migadu-Queue-Id: 0B6B211B51 X-Migadu-Scanner: mx12.migadu.com X-TUID: gfOm283apBzq Hi again! qui 14 dez 2023 ās 18:54:48 (1702590888), nandre@riseup.net enviou: > > Other than that, the current recipe is not deterministic. This is > probably due to the 'BuildID' which is a timestamp. > > See: (#$output)/lib/torbrowser/platform.ini This was it. I've just set MOZ_BUILD_DATE environment variable to a fixed timestamp (yyyymmddhhmmss) and now the build successfully checks. It's not much, but it's honest computer work! :) Now the question is: do we just set a fixed timestamp and forget it until the sun burns out or do we change it each and everytime when updating the browser so as to mimick the upstream one? Even though it is a bit of a hassle, I'd vote for mimicking upstream. > > + ((#:phases phases) > > + #~(modify-phases #$phases > > + (add-before 'configure 'setenv > > + (lambda _ > > + (setenv "CONFIG_SHELL" (which "bash")) > > + ;; Install location is prefix/lib/$MOZ_APP_NAME. Also > > + ;; $MOZ_APP_NAME is the executable name. Default is > > + ;; "firefox". > > + (setenv "MOZ_APP_NAME" "torbrowser") > > + ;; Profile location (relative to "~/."). Default is > > + ;; lower($MOZ_APP_VENDOR/$MOZ_APP_BASENAME), which is: > > + ;; ~/.tor project/firefox. > > + (setenv "MOZ_APP_PROFILE" "torbrowser/browser") > > + ;; WM_CLASS (default is "$MOZ_APP_NAME-$MOZ_UPDATE_CHANNEL").