From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id WA/vF+BHbGWPXwEAG6o9tA:P1 (envelope-from ) for ; Sun, 03 Dec 2023 10:18:24 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id WA/vF+BHbGWPXwEAG6o9tA (envelope-from ) for ; Sun, 03 Dec 2023 10:18:24 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A62A222985 for ; Sun, 3 Dec 2023 10:18:23 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=Ey8blcrt; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1701595104; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=uiP6bpNRlBd/oV/YiJ1tf2eFOmi8zkkpa4KzmvFypLk=; b=fOiZEobE76JZEtSmrLj3mIwK8TbiBZ52UBVrwSv6YRVilLRnshYaJfSAjQ9ElNhuqjoZq6 C8ibzBdoEHxJEHI6jdt/qbkjHC9DaAbCADYkhUvr5hIRZVWWeC1A7kD9y6UBl11rfQKTKw z7xL3EEhxuw8lfryEKjZwbW1LUz7K20JMXN4GDa1GSUsWBH4aRYj4xb2oyyCatjczlkxBx vjBRQTSHfi+xUIAJkYFMmP34ZKbXb0zBoYV2xvNIcOEbNf1JBwaQ1vly4yMUppcyDGCvgn tXO9VyN/MFmG76FQk2NBgKXlNhzMT9CYK4ltOJUHlsatpxaGlfuE2bB/RQJqqw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=Ey8blcrt; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1701595104; a=rsa-sha256; cv=none; b=ln8klQfsOP1zCyAFamBzby7VCEuuyIk5H/LFEPHCuSYLVHMDqopjPdqx5n6rvEP0tX2j08 uQBYC4+sn6yoky25C0fjw/a8XS9gKRNxeZzUDEt47uXgENk/7GPIznmVA83mNOt4kmvhT1 cnsSHNP3wm10eqrLlv8R99c6J00pX0cvkaU2MZCJnTf81THet5gqEWdHCi2cdP1gL9AWZt WRsZJtM4cn7h8m0aC4LF+vq7kAGFeXCcp//ZaFKjhe6P/18Tqjt1iDU9unAxvl6PSVBOE8 HTBnuXhfHw6yJMyCuiMVfazDVncSf8fg7+1m3OwZ3pjk8Y72xX/fqnievMS3vA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r9ic0-0006Jc-Im; Sun, 03 Dec 2023 04:18:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r9ibq-0006I2-Ko for guix-patches@gnu.org; Sun, 03 Dec 2023 04:17:54 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r9ibo-0006Jj-Pk for guix-patches@gnu.org; Sun, 03 Dec 2023 04:17:54 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r9iby-0004hA-8q for guix-patches@gnu.org; Sun, 03 Dec 2023 04:18:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#58365] [PATCH 0/6] Support #:tests? in guile-build-system Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 03 Dec 2023 09:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58365 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 58365@debbugs.gnu.org Received: via spool by 58365-submit@debbugs.gnu.org id=B58365.170159506118020 (code B ref 58365); Sun, 03 Dec 2023 09:18:02 +0000 Received: (at 58365) by debbugs.gnu.org; 3 Dec 2023 09:17:41 +0000 Received: from localhost ([127.0.0.1]:59116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9ibd-0004gZ-48 for submit@debbugs.gnu.org; Sun, 03 Dec 2023 04:17:41 -0500 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]:51509) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9ibb-0004gK-A5 for 58365@debbugs.gnu.org; Sun, 03 Dec 2023 04:17:40 -0500 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-332f90a375eso2784462f8f.3 for <58365@debbugs.gnu.org>; Sun, 03 Dec 2023 01:17:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701595043; x=1702199843; darn=debbugs.gnu.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date:message-id:reply-to; bh=uiP6bpNRlBd/oV/YiJ1tf2eFOmi8zkkpa4KzmvFypLk=; b=Ey8blcrtnMG4At0MBftoq9ydRbcly+CCbJNL85gnAEp1EPKZThh7B97RJ5uu0fAsc3 pi0tvIyxuahpZZoNpOiqV5zeTSkgClRXHvGnfryIAAp2KbTPIUs6Kji+3dCd/fFWXc8v uDymWI3gmbnSf+1MXVdQVIRC4mxRzepXfsblXdGTU4xCyHkBz9bh5chSu7N5H9H/cbzc sUnq9U267Q8hiwymGj6e4FGuYhPQ8w/2aYMNxKebJkwPoIulxSZyTC/QIJIJ95kjswMp gG3RG0mkFgEpL1oNjhpAAXDHRo+UIT849q15F15wKTQTF7Gc7hDijovSX9xHDlgr3jV2 /xeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701595043; x=1702199843; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uiP6bpNRlBd/oV/YiJ1tf2eFOmi8zkkpa4KzmvFypLk=; b=aJfD9u0zwoXyqGw8lr/7QbajkI3CbcKkM3Xm0as2VGVbkGrfibG/JPTwuiagFa2CKw 5YAOP7H7/BU7ZqNo20SVIN9lQWXecLvsfRqNaRdDdAKouNcvXtpddQnv4vkVq7t9CeKo Iad59670DGUu3on1qJS9VhYJHTKLxrArYTX9g3wE4lzhALSDNEnnNkpSewef6EvMAtCr PaulWcapzrIyCT7AlS35UX4QsEIPNgSCTnd08+NXm95bT7Fw2dIuUq+FqLDTwJs+8jU5 HtpgayxqjmQOHsymm4upo/UYBqfvcRRAx7orFcLsTpn9aZRziKbAsTH9ea6DVvk7/sbd FSew== X-Gm-Message-State: AOJu0Yxswc1svWHlrP7UVqiQ9VrHs7tjQViGaSpSQCeMjgk/qJZ/ksnT zD823fAYJ7s3odw9QqVmlc0= X-Google-Smtp-Source: AGHT+IHylWbsRi74D0MPWP2z+Nuksohtt+tpkggPWo47x86KlfHs5kkzf/mzHdgq8UdP7//2qr8HrA== X-Received: by 2002:a5d:674c:0:b0:333:152d:641c with SMTP id l12-20020a5d674c000000b00333152d641cmr2271733wrw.26.1701595043347; Sun, 03 Dec 2023 01:17:23 -0800 (PST) Received: from localhost ([188.120.129.233]) by smtp.gmail.com with ESMTPSA id cp6-20020a056000400600b003334520e49bsm799426wrb.53.2023.12.03.01.17.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Dec 2023 01:17:22 -0800 (PST) Date: Sun, 3 Dec 2023 11:17:21 +0200 From: Efraim Flashner Message-ID: Mail-Followup-To: Efraim Flashner , Maxime Devos , Ludovic =?UTF-8?Q?Court=C3=A8s?= , 58365@debbugs.gnu.org References: <20221007205352.1282-1-maximedevos@telenet.be> <87sfjlnw9r.fsf_-_@gnu.org> <878rldkufc.fsf@gnu.org> <8a38968e-e3bb-9444-8b98-756f0178fe42@telenet.be> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mKiFUPDel/W6m6K7" Content-Disposition: inline In-Reply-To: <8a38968e-e3bb-9444-8b98-756f0178fe42@telenet.be> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -3.75 X-Spam-Score: -3.75 X-Migadu-Queue-Id: A62A222985 X-Migadu-Scanner: mx12.migadu.com X-TUID: lPyhRI1syiin --mKiFUPDel/W6m6K7 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Top posting to make sure it is read: Maxime: I understand this has been going back and forth for over a year now and has been very frustrating, but parts of this email are unnecessary. As a maintainer I haven't done enough to try to ease tensions and find an equitable solution and for that I apologize. Ludo: Based on the publicly available emails I'm not seeing why this was held in limbo for so long. For plenty of packages we have a policy of writing a patch, submitting it upstream if possible, and carrying it until we can drop it. Currently I'm not seeing this as so much different as either that case or some of the other files we carry in gnu/packages/aux-files. To everyone: Please keep in mind if you feel the need to remove the mailing list from the reply chain if it is because it is something that really, truly, doesn't need to be sent to everyone or because you'd rather have it hidden from view. I am liberally removing parts of the email as I respond below: On Mon, Nov 20, 2023 at 01:34:12AM +0100, Maxime Devos wrote: > Hi, >=20 > Op 18-10-2022 om 17:44 schreef Ludovic Court=C3=A8s: > > Let me try to clarify what I think can be a fruitful way forward. > > Again, I agree with the goal you have here, I=E2=80=99m just proposing a > > different strategy. Noted > > To me, the problem that we have is lack of a standard way to run tests > > in Guile packages that don=E2=80=99t use Autotools. That, in turn, lea= ds to > > duplication in package definitions=E2=80=94whether it=E2=80=99s =E2=80= =98check=E2=80=99 phases in Guix > > or something similar in Debian and other distros. Noted > Err, this is the same for Autotools Guile packages -- Autotools Guile > packages have to copy test-driver.scm too (or do (exit 1)-style tests, but > those aren't really the tests this patch series). You can drop the > qualifier =E2=80=98 >=20 > Also, there is, in fact a standard way to run tests in Guile packages: co= py > the test-driver.scm (and in case of Autotools, parts of the Makefile.am f= rom > another Guile package). >=20 > While this does sound like _a_ problem, it is not a problem this patch > series is about and hence not _the_ problem (see later for details). Noted. Referring back to duplicated code above from Ludo, I wonder about using the test-driver script by default vs adding it per-package, but I don't have a good handle on how many packages are waiting to use it. > > Instead of addressing it downstream (in Guix), my suggestion would be to > > address it upstream=E2=80=94that is, to promote one way to run SRFI-64 = test > > suites, for example with a new =E2=80=9Cguild test=E2=80=9D command. >=20 > But Guix is the upstream (I mentioned this in the first e-mail *) -- AFAI= CT, > Guix has the latest version of test-driver.scm, and AFAICT Guix is where > test-driver.scm + parts of Makefile.am is copied from. >=20 > (*) and also right in the e-mail you were responding to: Sounds like Guix is the upstream of test-driver.scm and guile, as the upstream language in this build-system, could absorb it and make it available through 'guild test'. > > Going by "git log build-aux/test-driver.scm", Guix is the upstream, not > > Guile, though I suppose it could eventually be moved to Guile if desired > > by both. > > > That =E2=80=9Cguild test=E2=80=9D command would probably be very simila= r to > > =E2=80=98build-aux/test-driver.scm=E2=80=99. As you note, this script = is battle-tested > > and provides useful functionality. If we would turn it into a (scripts > > test) module, that =E2=80=98guild=E2=80=99 would pick up, then we=E2=80= =99d have a good start. > > With proper documentation, programmers who use Guile would have an > > incentive to use this method; packagers would benefit because the > > default =E2=80=98check=E2=80=99 phase would boil down to invoking =E2= =80=9Cguild test=E2=80=9D. > >=20 > > I hope this clarifies my proposal. WDYT? Sounds like a good long-term plan. That said, it is something to work out at a later date, not in this patch series. > I think that is a clear proposal, I'm not interested in implementing it, I > consider it out-of-scope and something that could be done separately from > this patch series. Noted > Finding who should be the upstream of test-driver.scm or finding a new ho= me > for test-driver.scm is not at all the point of this patch series -- the > point is to support #:tests? in guile-build-system, and for that a test > driver is needed, and look, there is a test driver right here in the Guix > repo, let's package it so that it becomes available to the build/test code > of guile-build-system (and as a bonus, it makes test-driver.scm more > discoverable). Sounds reasonable. > IOW, going back to your =E2=80=98I'm just proposing a different strategy= =E2=80=99 comment -- > you aren't proposing a different strategy for the patch series, you are > proposing something supplemental, and that =E2=80=98something supplementa= l=E2=80=99 is > something for guile-devel@, not guix@. I ignored this the first time through because it has to do with the guile-build-system and that's not something I've ever looked at. It sounds like the best *long term* option is to move this upstream to guile or to package it separately in its own repository. Seeing as it's been a year since this thread started I don't see that as a reason to hold anything up. In the immediate term, it looks like this patch set (which I haven't tested, but noticed the patches seem to be in the wrong order) would bring testing to the guile packages, which everyone agrees is a Good Thing=E2=84=A2. Lets get it fixed up and merged and any other bits can be worked on at a later date. If no one else comes forward to make sure that all the pieces work the way they're supposed to I will take care of it myself in about a week. In the mean time, please try to keep the conversation at least civil, and remember that we're all bound by the Code of Conduct while involved with Guix. --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --mKiFUPDel/W6m6K7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmVsR50ACgkQQarn3Mo9 g1HOdg//Q2/tJdMWSDlzw/xQujuqJ6EBEoI406Z/XvYNbIQxmMUwOPiJNFbyooKi r5T068KUGpvRCsg61hW8JrkFaEhCGic33irwyC70SlPiDKodEDnYl6GMk/+4ggOg PoS/Q1/MucnBWIT4cj1fPKqlbHq2Umtgl0YKjd8E94zJeYaQX6C3OBgW/CVn4eKs TR3iI+jDCEXkwClGFDwysbZsLQfY1kNgFVFI3A7mumZLbc+zw5zEA+xC57uzT0CQ Y4IFQU9saQLUCwjeIwFepBo6Ofz+8T9fXB30jPQ7Ako7nP6wAG0R8QL/SL6M058G UnL+sj83eMjvMiOR30XN6Abuo7yEWgFnYV3G7kr0Y+R+Im1k/4AU0O9a4c6zfPop PO5U0735gPX2nfT+C0DfCYcsiuBfzEIc9UAIxw3mXT+s6kGpPMJRuW6dqNBeecV5 QjzV5qANYNH1CoT4CfJhs4HQXo1ojMacTPRivlFkhnfcVMLy8v6WN19Gr7TK2vbG Umfkzdq+7HShRGKAVqyTbTNogqThIslLikshJERafq68oOt8L4eqLaVXlEkP889Z b3WxsxErd0Uqg7ELIAZYr8rcEumLoCqfFurjtQHW/3D5cSkaDUFxWsfwVR5vpXUi lkgxVkXuuiDx2+Zk2Ekj4FTir4N22f9UK9aW5C509VIM/Htx9p4= =bK7B -----END PGP SIGNATURE----- --mKiFUPDel/W6m6K7--