From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 8FquEBqibWVkVAAAauVa8A:P1 (envelope-from ) for ; Mon, 04 Dec 2023 10:55:38 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 8FquEBqibWVkVAAAauVa8A (envelope-from ) for ; Mon, 04 Dec 2023 10:55:38 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 059F65994A for ; Mon, 4 Dec 2023 10:55:37 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=lein5DRD; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1701683738; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=WANtWGzJjwMB/sSBQjS0qHeL4lzbykYu1i/iG9j7xy0=; b=MsB3ViahiUsg+oofVC7281tFewiiIWYrd8xlQxPGuHa6zcd4+G9vShjw6eIoX4Nn6t6SiF 5DvhM5Pg2RIMb43c/mTg7+ESaVdO0RlCCwB3BpcNJZ/OPU/jPWnnB8EkwF0Z2WzQVcvXFU pJtcxvIUgchgwegWMSgZRyzhDhbVrPMGAI6YfETVrlOy6ZIzdfJ4lK0wjmFC0zHdM6LihM WE6mcM6gx98sSS6DtXG9H7/KSLCNQpkYHHYRZ1Y30xoHBNK7MQRFSen+3dOOgc3bLWdLfe GNlfEhaExVpjVobTWivZroeW+VEs5JNlgqNwlXjmcTKczq9cKDV7TNA64Sq9mw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=lein5DRD; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1701683738; a=rsa-sha256; cv=none; b=etKhV6RQVOFQXF0ZQnlGmsMmGyxcwuqyBiiwrFRHKO9tog8FWOhPbuOk6n8airpVJX0hCX PDlM3ADyBnLsCrKFhIuDuLnqPsIFT0t6A4J24uaKV5UjOiryiTSIkg1YvJNqgDsBZaUTGA U09s2J4m8K9iQ/Extj6Xa4W2iQR9/68bQifwzuLviTL59cUxUPI7+IXbMypFYG1nTEHudl 5qjsrkNvB/lXQ51pn/H4H1rMry/f/K0jqA751qnPUvUh+/fv/Ebu0FjWbYtuDB3yWj5LQo Rcd0IFcKpDupawshZZujf5moRfpVMXY0LmhAUB6/nL4nV/NYIBG/csIDnI7JBQ== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rA5fE-0007Xy-F5; Mon, 04 Dec 2023 04:54:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rA5fB-0007W7-J6 for guix-patches@gnu.org; Mon, 04 Dec 2023 04:54:53 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rA5fB-00005l-AB for guix-patches@gnu.org; Mon, 04 Dec 2023 04:54:53 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rA5fL-00064W-N6 for guix-patches@gnu.org; Mon, 04 Dec 2023 04:55:03 -0500 Subject: bug#67505: [PATCH] build/go: Don't use set! Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Mon, 04 Dec 2023 09:55:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 67505 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 67505-done@debbugs.gnu.org, Katherine Cox-Buday Received: via spool by 67505-done@debbugs.gnu.org id=D67505.170168366123205 (code D ref 67505); Mon, 04 Dec 2023 09:55:03 +0000 Received: (at 67505-done) by debbugs.gnu.org; 4 Dec 2023 09:54:21 +0000 Received: from localhost ([127.0.0.1]:33498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rA5ef-00062D-Fa for submit@debbugs.gnu.org; Mon, 04 Dec 2023 04:54:21 -0500 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:52657) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rA5eb-00061w-HI for 67505-done@debbugs.gnu.org; Mon, 04 Dec 2023 04:54:20 -0500 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-40c09f4814eso12580865e9.1 for <67505-done@debbugs.gnu.org>; Mon, 04 Dec 2023 01:54:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701683641; x=1702288441; darn=debbugs.gnu.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date:message-id:reply-to; bh=WANtWGzJjwMB/sSBQjS0qHeL4lzbykYu1i/iG9j7xy0=; b=lein5DRD8ah8bXaNk6//i2GuJ0zzLzb7XBNbnoqvnGXAcylhja45MfY3fjHvD/Vuo0 9Wx8iiimLzutH+5ZQ2+Q8GQ/2Ni+7MU0TyXy1DmviNGvHMczk3Jb38cqAE0r0kAQbyzC 0YJhEhI6i4CYPR5j1+pMTvgProw3THyL/3/Nirf3VB6GZZZhENRyBQW1dQVGdPuxkDts LeSlFX/kRApIbYUgBfJmELlFyFU8VrZoznLVKcUez6HzpB/N+mgCiee8KYXPwFWfZh2b DuV3m62cxskxjNd2BxSyNdjcIsOtekiIBPgCk7bq0pY8xeK1h07L+21PCZ+0hQ1NeOGC 4zag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701683641; x=1702288441; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WANtWGzJjwMB/sSBQjS0qHeL4lzbykYu1i/iG9j7xy0=; b=NmtuYuiuf3o3tstnePwiHMkoTFU5lXPGr2K2K0XnofvBFZzobeMzD2K3yKrbsQbG/W UOnYOovKjc8ZgGK+XNgM+1oYr5p/WqDdh34n5gF8yatCas13c0Rd7NlbW7bNLX+gpZ36 9tLESS0ENveFNJXnVtD5L+H3lCYj5W9r1I8+tiW0+ipPqVT7xIw9/1fEK3FeHvOru3Vp CfrAK+K1/mXqsne9jm8/AUnlY5ocUoNTq9pEc0iRIQ0bjrvJuEyvnund0oaGAMlgUFcm w3Z4IpQSacdE3AvuCFH+tclEoFmrUao7Wqaf5nVDMVr46NfSL32yHGx7jba/tfIlh/i7 QQwg== X-Gm-Message-State: AOJu0Yz44OVRHPkbIh0jBqf8VhzUagd+VAFLMGUexwYwzeXiu7igzgJ4 1X0g5P3gdA6B3sYyXyeKR/o= X-Google-Smtp-Source: AGHT+IHDFX0H5Hpn3sFFcP4VVqrRa6s9+avauW7s7IooGxuE+5HyQa5FbtmWubJ+MlGFGyLz7ppGUw== X-Received: by 2002:a05:600c:3585:b0:408:3f61:cb4f with SMTP id p5-20020a05600c358500b004083f61cb4fmr2436509wmq.23.1701683640872; Mon, 04 Dec 2023 01:54:00 -0800 (PST) Received: from localhost ([188.120.129.233]) by smtp.gmail.com with ESMTPSA id p36-20020a05600c1da400b0040b478da760sm14472637wms.48.2023.12.04.01.53.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 01:53:59 -0800 (PST) Date: Mon, 4 Dec 2023 11:53:58 +0200 From: Efraim Flashner Message-ID: Mail-Followup-To: Efraim Flashner , Ludovic =?UTF-8?Q?Court=C3=A8s?= , 67505-done@debbugs.gnu.org, Katherine Cox-Buday References: <92508cd851b013f54a799350082f49b157c7aebf.1701167049.git.efraim@flashner.co.il> <87jzpuewbk.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rheOYXulewIPgN3G" Content-Disposition: inline In-Reply-To: <87jzpuewbk.fsf@gnu.org> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 059F65994A X-Spam-Score: -6.74 X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -6.74 X-TUID: bMqATHfji1fe --rheOYXulewIPgN3G Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Dec 03, 2023 at 11:49:03PM +0100, Ludovic Court=C3=A8s wrote: > Efraim Flashner skribis: >=20 > > This causes build failures on powerpc-linux. > > > > * guix/build/go-build-system.scm (unpack): When the unpack-path is unset > > use the import-path but don't redefine the unpack-path. > > > > Change-Id: I2b5a36eb738abb14307941d388038139dbaf2bdf >=20 > [...] >=20 > > - (when (string-null? unpack-path) > > - (set! unpack-path import-path)) > > - (let ((dest (string-append (getenv "GOPATH") "/src/" unpack-path))) > > + (let ((dest (string-append (getenv "GOPATH") "/src/" > > + (if (string-null? unpack-path) > > + import-path > > + unpack-path)))) >=20 > Could you adjust indentation of the =E2=80=98if=E2=80=99 arms? >=20 > Otherwise LGTM, thanks! Done. Patch pushed! --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --rheOYXulewIPgN3G Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmVtobYACgkQQarn3Mo9 g1E25xAAlEKqSolqlZkPM3XELAwj4J66kCCAdaT7O7gUs2Tv+AOfRQws9eHCHu1v POOFNF+MY4I/lYMkhFMvbMp/71MxwJiHU8nFdpUEK7pRWzx+Ia4f+kTkTf2deyDz gyFTIZ0F9RRKLqYv4TsahW4WHgd/iDWPQzAt2ndUHnbYVufgMP1Jn8mwQcGzQhT0 fvqpSjohDsPvpZT5eHeUMQ4ajA6CySLm6OSWecWt7hYu4d8/A/Y/yY0I905zxfzi c8f8HhEdFJMjqxlVkOR7ZBttl1zj9Lj/Y8fIDnjMrgcT1adhAmhqYCVRri8nW2cP 5+0n8apBJs6S9GX7z5wDY4QJcGPulEuY57KELesDSYX614sAR/I6QoY+pW0/8QIU bbmjzwFLpNeog4+OAkYx6+KGDUq9jrh/FA+SeVFU69PA7SWWXCeO0cuJOkUan0Td 3stqHN4hdeqtBed+2zw6eSbjG0V4gf/brY7BXgwUoCzAYLy+NrQi3KGJvpLOHKUS bjf3n2xayhwIKLYtlrfj0AfURUMuP13ngycWbOT46zq5E4bLxy+X5IatQvGhWCIJ LWg8ZSlD29keBqAqn6gpq01SVLUvmki14l/kXrYOsJPR/ca44bNf9GW2uWz864cJ J50z0AL1V3g3V3gCzG/ju4FtDL6wjUj1FnsFyERWiia294hGJp0= =PuSU -----END PGP SIGNATURE----- --rheOYXulewIPgN3G--