bug#67156: Build insight-toolkit.x86_64-linux.skylake on master is broken.

[Efraim Flashner <efraim@flashner.co.il>]

[-- Attachment #1: Type: text/plain, Size: 4681 bytes --]

On Mon, Nov 13, 2023 at 11:21:53PM -0500, Maxim Cournoyer wrote:
> Hello!
> 
> Apparently, the recently pushed LLVM/Clang update broke this package,
> according to the Cuirass notifications:
> 
> cuirass@gnu.org (Cuirass) writes:
> 
> > <p>The build <b>insight-toolkit.x86_64-linux.skylake</b> for specification <b>master</b> is
> > broken. You can find the detailed information about this build <a
> > href="https://ci.guix.gnu.org/build/2602507/details">here</a>.</p>
> >
> > https://ci.guix.gnu.org/build/2602507/details
> 
> I haven't investigated it, but this appears to be where it fails:
> 
> --8<---------------cut here---------------start------------->8---
> cd /tmp/guix-build-insight-toolkit-4.12.2.drv-0/build/Modules/Video/Core/src && /gnu/store/q2qlfc0997p1zfqcil8c5raklqkq1214-tuning-compiler-skylake/bin/c++  -I/tmp/guix-build-insight-toolkit-4.12.2.drv-0/build/Modules/ThirdParty/KWIML/src -I/tmp/guix-build-insight-toolkit-4.12.2.drv-0/InsightToolkit-4.12.2/Modules/ThirdParty/KWIML/src -I/tmp/guix-build-insight-toolkit-4.12.2.drv-0/build/Modules/ThirdParty/KWSys/src -I/gnu/store/av2gd2fdg2llv3rpwlacskc1v2mh44c5-vxl-1.18.0/include/vxl/v3p/netlib -I/gnu/store/av2gd2fdg2llv3rpwlacskc1v2mh44c5-vxl-1.18.0/include/vxl/vcl -I/gnu/store/av2gd2fdg2llv3rpwlacskc1v2mh44c5-vxl-1.18.0/include/vxl/core -I/tmp/guix-build-insight-toolkit-4.12.2.drv-0/InsightToolkit-4.12.2/Modules/ThirdParty/VNLInstantiation/include -I/tmp/guix-build-insight-toolkit-4.12.2.drv-0/build/Modules/Core/Common -I/tmp/guix-build-insight-toolkit-4.12.2.drv-0/InsightToolkit-4.12.2/Modules/Core/Common/include -I/tmp/guix-build-insight-toolkit-4.12.2.drv-0/InsightToolkit-4.12.2/Modules/Video/Core/include -Wall -Wcast-align -Wdisabled-optimization -Wextra -Wformat=2 -Winvalid-pch -Wno-format-nonliteral -Wpointer-arith -Wshadow -Wunused -Wwrite-strings -funit-at-a-time -Wno-strict-overflow -Wno-deprecated -Wno-invalid-offsetof -Woverloaded-virtual -Wstrict-null-sentinel  -O2 -g -DNDEBUG -fPIC -MD -MT Modules/Video/Core/src/CMakeFiles/ITKVideoCore.dir/itkTemporalProcessObject.cxx.o -MF CMakeFiles/ITKVideoCore.dir/itkTemporalProcessObject.cxx.o.d -o CMakeFiles/ITKVideoCore.dir/itkTemporalProcessObject.cxx.o -c /tmp/guix-build-insight-toolkit-4.12.2.drv-0/InsightToolkit-4.12.2/Modules/Video/Core/src/itkTemporalProcessObject.cxx
> In file included from /tmp/guix-build-insight-toolkit-4.12.2.drv-0/InsightToolkit-4.12.2/Modules/Numerics/Polynomials/src/itkMultivariateLegendrePolynomial.cxx:18:
> /tmp/guix-build-insight-toolkit-4.12.2.drv-0/InsightToolkit-4.12.2/Modules/Numerics/Polynomials/include/itkMultivariateLegendrePolynomial.h:145:3: error: ISO C++17 does not allow dynamic exception specifications
>   145 |   throw ( CoefficientVectorSizeMismatch );
>       |   ^~~~~
> /tmp/guix-build-insight-toolkit-4.12.2.drv-0/InsightToolkit-4.12.2/Modules/Numerics/Polynomials/include/itkMultivariateLegendrePolynomial.h:148:3: error: ISO C++17 does not allow dynamic exception specifications
>   148 |   throw ( CoefficientVectorSizeMismatch );
>       |   ^~~~~
> /tmp/guix-build-insight-toolkit-4.12.2.drv-0/InsightToolkit-4.12.2/Modules/Numerics/Polynomials/src/itkMultivariateLegendrePolynomial.cxx:126:1: error: ISO C++17 does not allow dynamic exception specifications
>   126 | throw ( MultivariateLegendrePolynomial::CoefficientVectorSizeMismatch )
>       | ^~~~~
> /tmp/guix-build-insight-toolkit-4.12.2.drv-0/InsightToolkit-4.12.2/Modules/Numerics/Polynomials/src/itkMultivariateLegendrePolynomial.cxx:149:1: error: ISO C++17 does not allow dynamic exception specifications
>   149 | throw ( MultivariateLegendrePolynomial::CoefficientVectorSizeMismatch )
>       | ^~~~~
> make[2]: *** [Modules/Numerics/Polynomials/src/CMakeFiles/ITKPolynomials.dir/build.make:79: Modules/Numerics/Polynomials/src/CMakeFiles/ITKPolynomials.dir/itkMultivariateLegendrePolynomial.cxx.o] Error 1
> make[2]: Leaving directory '/tmp/guix-build-insight-toolkit-4.12.2.drv-0/build'
> make[1]: *** [CMakeFiles/Makefile2:5804: Modules/Numerics/Polynomials/src/CMakeFiles/ITKPolynomials.dir/all] Error 2
> make[1]: *** Waiting for unfinished jobs....
> --8<---------------cut here---------------end--------------->8---

It looks like insight-toolkit-4.12 was failing for a while and now the
optimized versions were starting to fail too.  I added a configure-flag
to insight-toolkit-4.12 to specifically used C++14 and then the build
succeeded.

-- 
Efraim Flashner   <efraim@flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]