From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id oIFAB4CQHWFG5QAAgWs5BA (envelope-from ) for ; Thu, 19 Aug 2021 00:58:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id oDH5AoCQHWGKNQAA1q6Kng (envelope-from ) for ; Wed, 18 Aug 2021 22:58:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C6A7BB517 for ; Thu, 19 Aug 2021 00:58:07 +0200 (CEST) Received: from localhost ([::1]:56798 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mGUVa-0001KG-Ry for larch@yhetil.org; Wed, 18 Aug 2021 18:58:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48348) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mGUVW-0001Jr-Fg for guix-patches@gnu.org; Wed, 18 Aug 2021 18:58:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46227) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mGUVW-0000sA-9L for guix-patches@gnu.org; Wed, 18 Aug 2021 18:58:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mGUVW-0003MK-3P for guix-patches@gnu.org; Wed, 18 Aug 2021 18:58:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50084] [PATCH] gnu: Add waypipe. References: <20210817015308.353224-1-contact@robbyzambito.me> In-Reply-To: <20210817015308.353224-1-contact@robbyzambito.me> Resent-From: "Paul A. Patience" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 18 Aug 2021 22:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50084 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "50084@debbugs.gnu.org" <50084@debbugs.gnu.org> Received: via spool by 50084-submit@debbugs.gnu.org id=B50084.162932743912856 (code B ref 50084); Wed, 18 Aug 2021 22:58:02 +0000 Received: (at 50084) by debbugs.gnu.org; 18 Aug 2021 22:57:19 +0000 Received: from localhost ([127.0.0.1]:57772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGUUl-0003LD-47 for submit@debbugs.gnu.org; Wed, 18 Aug 2021 18:57:19 -0400 Received: from mail-4317.protonmail.ch ([185.70.43.17]:50658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGUUe-0003Ks-10 for 50084@debbugs.gnu.org; Wed, 18 Aug 2021 18:57:14 -0400 Date: Wed, 18 Aug 2021 22:56:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apatience.com; s=protonmail3; t=1629327421; bh=YKAOTt1kou8HkGbtxf9+dJvBWWRRrcr3rCQ7IzFrcak=; h=Date:To:From:Reply-To:Subject:From; b=fdWsh9ZaxGuAqPZE2s+W23hwNeSeU/XUT1YGpAKU2mgbnm9KKqWjNna7kLP1Cgbn/ 6aL0R5cbc3pYBz3Gmc929nRot3J32LhECmWhic1pGZ0vEa6HLr6BWYWfToGAfpiWRS PDjO5h1plWFvcZj04QL7rzn8QExNSOanCJEWYZiklofFC6KdTs5qOd6Qfzr/QBISLo KezfdhHnvvlBPd4E9UJ2oy64D6IaxTpxQ0/jwOXMM7K/9X8wAZXxGTfYjjZatG+Ngc TzcJmF39yLY8QI32gu8kRmgyqhFTxoME+m/29pLGfrUpC5KBrew9MGPpRoPg1KBJka wIp1XWJ8Rt1xQ== From: "Paul A. Patience" Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: "Paul A. Patience" Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1629327487; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=YKAOTt1kou8HkGbtxf9+dJvBWWRRrcr3rCQ7IzFrcak=; b=rrW4rBKEDAk1aFbpGfZfJ/q1SyFqsUlQsQEKH7SkGzsBf080SOjy0sGPP0z5pw2l0uG6go 0T64ZcaG1RFtRST4frtECWe4iP5QiCZqfWnDlw/roVTacB7gJKXLkRPyFgg96jK//OimBO XcDUnxQGDsjtEaLjcQ+HjYSZ7GhdKRRAH2KLzLyyXHbBq0snOpq8SZrPHIFzcAJG51tpDw 3VkqPucxQ5jtuGdKSZ3/AQXNXdp+wyRbsjIOmUK7n074gy8xfIQbuzir/CIxMDe77FpTdO +JchevcQJpgR/+3Hm8of9IO637xeBMGbjDgouLGyx2mj8SkPnHs22akuchebjQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1629327487; a=rsa-sha256; cv=none; b=qv1Ea2Al7QYU9HQJLx/UwbKoxBoH5pOJFYlLlEwfdEXHJQdU13mk4Zy8LSwSgibUdE/IcW 779vFlmIcGw7c3Q6s+6pW0yBEsym1NWL2RPgzH3nVFWB/SkRh1Jdfy4rKdLgSPB9XQjsvk sLsJ0NT1hLrPUueBgf6iRNOxd7Bp4Jjq71xLZRruULXT6xq5N720oZ64McQTswY3aVVu5n oh38Fc7ZFT4XFiVWGSk0F0+v1rXTn3c5jeCb6n81tJ2OXBCxX0gb31SbplCA2MVf98K7g8 C5e8lc+SLcOGznyGzeQu4zVD3rzhbtOPqCKCwobTyfVUXrkGpMIDEke/LsxarQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=apatience.com header.s=protonmail3 header.b=fdWsh9Za; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.42 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=apatience.com header.s=protonmail3 header.b=fdWsh9Za; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: C6A7BB517 X-Spam-Score: -1.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: ihlMHkHcCKcb Hi, > + (add-after 'unpack 'fix-sleep-path > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (let ((out (assoc-ref outputs "out")) out is not used anywhere, so you can remove it, along with the outputs argument of the lambda. > + (coreutils (assoc-ref inputs "coreutils"))) > + (substitute* "./test/startup_failure.py" > + (("sleep") > + (string-append coreutils "/bin/sleep"))) > + #t)))))) > + (native-inputs > + `(("pkg-config" ,pkg-config) > + ("scdoc" ,scdoc))) > + (inputs > + ;; For tests > + `(("python" ,python) > + ("coreutils" ,coreutils))) I haven't tried building this or anything, but if python and coreutils are really only needed for tests, then they need not be in inputs (and the fact that the initial version of this patch didn't have them at all supports this thesis). In other words, I'd put everything in native-inputs. Also (and this is really minor), arguments normally follows the inputs sections. Best regards, Paul