From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id CACmM6KGDmWKNwEAG6o9tA:P1 (envelope-from ) for ; Sat, 23 Sep 2023 08:33:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id CACmM6KGDmWKNwEAG6o9tA (envelope-from ) for ; Sat, 23 Sep 2023 08:33:06 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2EA1439837 for ; Sat, 23 Sep 2023 08:33:06 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=6xq.net header.s=MBO0001 header.b=J32bHjqm; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=6xq.net (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1695450786; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=CziliB4TDoZxbi/Jpi+uD7D6VQ3MUXVfSnS4wT+ZdzM=; b=o4vUR3nxiGv7rjuuy7XnaEaKACMFWVYCQCet6RVj1EEl06fId8ON1VHx/6QSI9hNrvEbEZ Ko06S01k5Ta9CYNiQLqzWNwjqZeQdlduYHDQDg+LVkYfB/ULiAnaTU4wxL7E7Dk3arJ7aI VQxyUJ9un5jjRd0vTWpuFpsLksyFV0nS1PkQgt+L90F4pOqOmfEGsi6f0+T69vjyGHYhur YaXvE1dKgM8tznGF9ANl0pOJAswPKa1Mgya+qCC00r/WQ0e0PMaqrmLXa4Y4zvUubPbFB0 407SeW7XIRWngEBzlR8W1P2yK0SEuT1D96g/00je8vs2z+91EGXdSA8X98LUcg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1695450786; a=rsa-sha256; cv=none; b=pY2/GwS8brry8Rdpb4WiK4LXn9J/5MqfcQvIxfl/ifrWFZ4nGEk3mGdnzmXQOGskOU5FjH caJat4SgwLrC/Llcb5Wz5vpBIlX4V069xyAnGxbqlBBM1Uc4Ldr+3qi1ZEc+T9+UwPpACH 4dTnYoCdU6AY/8MNr6uv5RTQrG51nsDtLnj/DsbHfTLBKsj5kZ9NTIxR2o3gW9iATWzjpk p5bZojfUq5qsnBd/uDi9VubDs5LR2Tw+ch4hD+Jg5izE2N93eUK8NIFV/EZEbQMGHKUIA6 d0Vnkv4bxBEL48Dk2Dxg5GtWHA1ZJG2IVxX41uX2GEmKIgg90gMa2wvrUNPnOA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=6xq.net header.s=MBO0001 header.b=J32bHjqm; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=6xq.net (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qjwCF-0004M7-7F; Sat, 23 Sep 2023 02:32:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjwCC-0004Ly-Pe for guix-patches@gnu.org; Sat, 23 Sep 2023 02:32:52 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qjwCB-0008WN-U5 for guix-patches@gnu.org; Sat, 23 Sep 2023 02:32:52 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qjwCM-0002mf-IZ for guix-patches@gnu.org; Sat, 23 Sep 2023 02:33:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65010] [PATCH 0/8] Misc Python build system improvements Resent-From: Lars-Dominik Braun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 23 Sep 2023 06:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65010 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke Cc: jgart@dismail.de, 65010@debbugs.gnu.org Received: via spool by 65010-submit@debbugs.gnu.org id=B65010.169545073110636 (code B ref 65010); Sat, 23 Sep 2023 06:33:02 +0000 Received: (at 65010) by debbugs.gnu.org; 23 Sep 2023 06:32:11 +0000 Received: from localhost ([127.0.0.1]:37650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjwBW-0002lU-UC for submit@debbugs.gnu.org; Sat, 23 Sep 2023 02:32:11 -0400 Received: from mout-p-202.mailbox.org ([2001:67c:2050:0:465::202]:45490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjwBT-0002l0-8Z for 65010@debbugs.gnu.org; Sat, 23 Sep 2023 02:32:10 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4RsznK0kpfz9sdD; Sat, 23 Sep 2023 08:31:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6xq.net; s=MBO0001; t=1695450709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CziliB4TDoZxbi/Jpi+uD7D6VQ3MUXVfSnS4wT+ZdzM=; b=J32bHjqmYY0kMOrifykYmAd3n3TozburKf/y9k/2lPjVgEwP9Tkk0kzBOd3cjx/pQlj3dW ZJA9MZOrwn90mFJOcvJZ1Esud8NBno4ddTtk0czWu+K064ufNlDhNCQ+oCBtfywn2W3xs5 tlUABChWk2E+d1R2tk7NcdvwOXR922tfh3zhJ5wnXCbXrdbKyxnRHc1tEwCPvgLm3styOm 8LQXfwqpVFsi0bT2mLXSbRkSRHzhAGJIAbpkt3oSgYHMGxxpnsR6m5hK6ZGQ+f9AWxrF/S Kgfs8HfrLUtPPyo770GOAzN3q8OuBxCw5JPe5+fL4q9seNGK88ZGFcErNdu46A== Date: Sat, 23 Sep 2023 08:31:47 +0200 From: Lars-Dominik Braun Message-ID: References: <874jjm97pm.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <874jjm97pm.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: 2.63 X-Migadu-Spam-Score: 2.63 X-Migadu-Scanner: mx1.migadu.com X-Migadu-Queue-Id: 2EA1439837 X-TUID: 0Op6nWgfx5Re Hi Marius, > About 'wheel': that package *is* actually required by the build system > (as opposed to pypa-build!): I think we should make it available by > default (e.g. with a #:wheel argument), or propagate it from the build > systems. It makes no sense to add it to _all_ pyproject-build-system > consumers. it’s not added to all of them. After submitting this patch I realized it’s actually a dependency of setuptools (bdist_wheel), which otherwise cannot create wheels. Other backends afaik have their own method of building wheels or depend on a wheel-generating library. So it might make sense to add python-wheel as a propagated input to python-setuptools. I didn’t have time to try it yet though. > This commit title is weird. The build is already working, but using a > workaround that is no longer needed. Probably a leftover from all the rebasing. > > + #:use-module (ice-9 textual-ports) > This import seems unused? Yeah, possibly a leftover from previous experiments. > Perhaps this should also be documented in the manual. Indeed. I didn’t know we had separate documentation in the manual. > > - (configure-flags ''()) > > + (configure-flags ''(@)) > > I don't understand how the @ makes it a dictionary. Can you enlighten > me? Either here, or in a comment? :-) It’s an implementation detail of our JSON library. The configure-flags are directly passed to it. Lars