From: Andreas Enge <andreas@enge.fr>
To: Sharlatan Hellseher <sharlatanus@gmail.com>
Cc: 64504@debbugs.gnu.org, Efraim Flashner <efraim@flashner.co.il>,
Iliya Tikhonenko <tikhonenko@mpe.mpg.de>,
Eric Bavier <bavier@posteo.net>
Subject: [bug#64504] [PATCH] gnu: Add unsio.
Date: Tue, 8 Aug 2023 11:29:34 +0200 [thread overview]
Message-ID: <ZNIK_kKc2ud4iJpQ@jurong> (raw)
In-Reply-To: <521af611d0794672c19a4899e42eb5e448ab1c1f.1688681498.git.sharlatanus@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 580 bytes --]
Hello,
thanks for the patch! I tried to remove the marketing speech out of the
description. For the #:build-type, the default value (release with debug
information) also works and results in a package of the same size. Is there
a reason to change it? Modified patch attached.
I can also compile the package without the configure flags, are they
useful?
In the end dynamic and static libraries end up in a directory lib64/.
Should this not be lib/?
And there are lots of warnings about 34 bit shifts in a 32 bit type.
But I suppose you tested that the library works.
Andreas
[-- Attachment #2: 0001-gnu-Add-unsio.patch --]
[-- Type: text/plain, Size: 2892 bytes --]
From f5401b0abbe58aa473738dc58d541e2bece9db65 Mon Sep 17 00:00:00 2001
Message-ID: <f5401b0abbe58aa473738dc58d541e2bece9db65.1691486728.git.andreas@enge.fr>
From: Sharlatan Hellseher <sharlatanus@gmail.com>
Date: Thu, 6 Jul 2023 23:13:05 +0100
Subject: [PATCH] gnu: Add unsio.
* gnu/packages/astronomy.scm (unsio): New variable.
Co-Authored-By: Iliya Tikhonenko <tikhonenko@mpe.mpg.de>
Signed-off-by: Andreas Enge <andreas@enge.fr>
---
gnu/packages/astronomy.scm | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm
index e5c318c8bf..7e047d4ad7 100644
--- a/gnu/packages/astronomy.scm
+++ b/gnu/packages/astronomy.scm
@@ -9,6 +9,7 @@
;;; Copyright © 2021, 2022 Vinicius Monego <monego@posteo.net>
;;; Copyright © 2021 Greg Hogan <code@greghogan.com>
;;; Copyright © 2021 Foo Chuan Wei <chuanwei.foo@hotmail.com>
+;;; Copyright © 2023 Iliya Tikhonenko <tikhonenko@mpe.mpg.de>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -75,6 +76,7 @@ (define-module (gnu packages astronomy)
#:use-module (gnu packages python-xyz)
#:use-module (gnu packages qt)
#:use-module (gnu packages readline)
+ #:use-module (gnu packages sqlite)
#:use-module (gnu packages sphinx)
#:use-module (gnu packages textutils)
#:use-module (gnu packages time)
@@ -3951,3 +3953,32 @@ (define-public python-wiimatch
for optimal @code{matching} of weighted N-dimensional image intensity data
using (multivariate) polynomials.")
(license license:bsd-3)))
+
+(define-public unsio
+ ;; There is no versioned tag, use the latest commit.
+ (let ((commit "25e52468298e1194c9726ef5dba9d5fbb46870f5")
+ (revision "0"))
+ (package
+ (name "unsio")
+ (version (git-version "1.3.3" revision commit))
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://gitlab.lam.fr/infrastructure/unsio")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "110i2p5608zhh5w3pf3b5r2651hykw2ayspgq6vpqsffhya1p170"))))
+ (build-system cmake-build-system)
+ (arguments
+ (list #:tests? #f ;No tests
+ #:configure-flags #~(list "-DCMAKE_CXX_STANDARD=14")))
+ (inputs (list gfortran hdf5 perl sqlite zlib))
+ (home-page "https://projets.lam.fr/projects/unsio/wiki")
+ (synopsis "Input and output routines for n-body file formats")
+ (description
+ "@acronym{UNSIO, Universal Nbody Snapshot Input Output} provides
+an API for performing input and output operations on different kinds of
+n-body file formats (nemo, Gadget binaries 1 and 2, Gadget hdf5, Ramses).")
+ (license license:cecill))))
base-commit: f19736e62f9ab5fba0ac5fe184a221c2a5d374c6
--
2.41.0
next prev parent reply other threads:[~2023-08-08 9:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 22:13 [bug#64504] [PATCH] gnu: Add unsio Sharlatan Hellseher
2023-08-08 9:29 ` Andreas Enge [this message]
2023-08-08 11:37 ` Iliya Tikhonenko
2023-08-08 15:49 ` Andreas Enge
2023-08-14 12:41 ` Iliya Tikhonenko
2023-08-17 18:10 ` bug#64504: " Andreas Enge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNIK_kKc2ud4iJpQ@jurong \
--to=andreas@enge.fr \
--cc=64504@debbugs.gnu.org \
--cc=bavier@posteo.net \
--cc=efraim@flashner.co.il \
--cc=sharlatanus@gmail.com \
--cc=tikhonenko@mpe.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.