From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id SK25Hldq3mRiDwAASxT56A (envelope-from ) for ; Thu, 17 Aug 2023 20:43:35 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id KGj2Hldq3mRiBgEA9RJhRA (envelope-from ) for ; Thu, 17 Aug 2023 20:43:35 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1B1024BA97 for ; Thu, 17 Aug 2023 20:43:35 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1692297815; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=mWAxnFEEPlm6v0zpHw7CiSP1KnrhO+/t/JR24gzJcts=; b=F3OSkvRRnhGu/q0QZzT4JiJHtWvnsXQxMIgkMateC1LR6mOB0PWiu+YfQ5EXWKWAe45eET OL2PoE+3l53L9SVsOxVq+hcnfkt2KD4RleC+gR2DiguSPQFzx+rkCVkMc/3ZIGJpf7NY1/ 9F0swhGi07an7XUJst51vMauiz6NoC7pxFqAG+v484Av0QpRR6k0v/J3cjycIWJTYLb+YO toGzY4wo1Uw4tF9Ec8Sv+HnYDmi5zQaLLFo4Ctnd29WeDZa4VJBQucYoAiShjia3vqr+8Z uYZEvzUE0U93cIO7FASUV9YiRq/YdxIWccnZnN7aTZEMvzyiVfEosJFyzYLSLw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1692297815; a=rsa-sha256; cv=none; b=iziu/soGkYrCZgDOilLk33LlEjq8USfZ8yhRL+5iAN7eiuJkhOSf9unYdU63pl+BROfeCS o9DDp/ML5X8ETvuJf140yplPns1+ecLAoma81toFgwZy+61H+itc2lKR/FgwEAs6wCB5PH FwlIYRF8vaqnQ49Q/7+GvEbT0dwAAfI0Ed7OAI7GGUcDQYkz0tF3QLIk3xL1rr/fi8lCH6 VwmcFrmijewEnQaJN01EkMB0Jkixv8PD1gnYPxhZullFe2C6Gmz3B/dQ8OLM3oEGRQgFb/ S9OrXZEQifgafV9ks5rdHIjzGYibsVIEgEXSh+nFpahDhunJM90kTK99Qfd7EA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qWhxj-0003mP-15; Thu, 17 Aug 2023 14:43:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWhxW-0003lw-Kd for guix-patches@gnu.org; Thu, 17 Aug 2023 14:43:03 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qWhxW-0007Nt-DK for guix-patches@gnu.org; Thu, 17 Aug 2023 14:43:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qWhxW-0003ot-Aq for guix-patches@gnu.org; Thu, 17 Aug 2023 14:43:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65357] [PATCH] gnu: scilab: Fix compilation error. Resent-From: Andreas Enge Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 17 Aug 2023 18:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65357 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Graves Cc: Eric Bavier , 65357@debbugs.gnu.org, Efraim Flashner Received: via spool by 65357-submit@debbugs.gnu.org id=B65357.169229774614641 (code B ref 65357); Thu, 17 Aug 2023 18:43:02 +0000 Received: (at 65357) by debbugs.gnu.org; 17 Aug 2023 18:42:26 +0000 Received: from localhost ([127.0.0.1]:45618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWhwv-0003o4-MR for submit@debbugs.gnu.org; Thu, 17 Aug 2023 14:42:25 -0400 Received: from hera.aquilenet.fr ([2a0c:e300::1]:58162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWhws-0003no-Pr for 65357@debbugs.gnu.org; Thu, 17 Aug 2023 14:42:23 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id CC80E51D; Thu, 17 Aug 2023 20:42:14 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Zop_aApKqNkX; Thu, 17 Aug 2023 20:42:14 +0200 (CEST) Received: from jurong (unknown [IPv6:2001:861:c4:f2f0::c64]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 4D3453AA; Thu, 17 Aug 2023 20:42:14 +0200 (CEST) Date: Thu, 17 Aug 2023 20:42:12 +0200 From: Andreas Enge Message-ID: References: <03a288df56dc60850e6a8c0fc2785949e209f33a.1692296107.git.ngraves@ngraves.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <03a288df56dc60850e6a8c0fc2785949e209f33a.1692296107.git.ngraves@ngraves.fr> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.46 X-Spam-Score: -5.46 X-Migadu-Queue-Id: 1B1024BA97 X-Migadu-Scanner: mx1.migadu.com X-TUID: mkf+tKuFZcp6 Hello Nicolas, Am Thu, Aug 17, 2023 at 08:15:07PM +0200 schrieb Nicolas Graves: > + (substitute* "modules/output_stream/src/cpp/diary_manager.cpp" > + (("if \\(array_size > 0\\)") > + "if (*array_size > 0)")) the fix looks right to me. But our scilab version is 8 years old, while there are newer versions around. Would it make sense to rather update the package to a newer version? (I had a look at 5.2.2, 6.0.0 and 6.1.1, but all of them would still require your suggested fix.) Andreas