From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id YANMGe1NmWRZFQEASxT56A (envelope-from ) for ; Mon, 26 Jun 2023 10:35:57 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id gG5iGO1NmWQqwAAAG6o9tA (envelope-from ) for ; Mon, 26 Jun 2023 10:35:57 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E0912D0C5 for ; Mon, 26 Jun 2023 10:35:56 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=FfOpvQEZ; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1687768557; a=rsa-sha256; cv=none; b=XD+lyvOC2fvLBw5mUAmo9aKWHoQ0b6Zyi7TlYPwrO4TgWeH8tSUMogh7zX8NOxtRW6fkyj kN6jK/gEB1VNcn4+LEab7pygD9Xyl+ndYTk03Xg2KExZXho+FbNApuRRkclLvI5EljCvNC Tcw74AAKoMqPGIKGoiTO7zsdCaFP3XU5555KO3elXx9zgZuWPX3kcE5GSOkpwo0BDXDa9b UOeEJDnTrggvngBdYS0FS3nEEhn/ExdKId+LatDst4Sk1x3/GeRqe6IMcxp8yf/aDYvg2b 0y4oBWiGd9fV5qgoTZc8FWgaShahxH8Klx2kDTK9+ir55bWssHvvZl8itTNsLw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=FfOpvQEZ; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1687768557; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Jh4bHbnaivWy9+Xjp+BeWbtiuvYVaPCMWBmnGKac6wE=; b=C1BA18jQP3dZZeBbXIpAa0Omy+nOhih0KB9T6vj6fYunj60Fy+fiQkvr2VpJouy/3bmnDl sfycp7orkmkQVblUmE2LKxwqf4mjSjSabDw60z5sP8zD5Occ0jpxOfAiAQOZyZFgdthXj7 ng5lfNCoVSrD19Qgir/X5iO9WovLSGzVlSvs3XKz6IN2d/TPqvaWWmUU+sgHYujUnOk9r4 SDpmi8qBup5A7/uoLv4L7jywsbUDkwE6oH8RpjSV6ftZBxq+TzOeOSB6lkaHz8i/0BX2Y8 4KSkOP+zI1GJUN74I80nr7+YnvX/XqF2H0AOfwHni7ytk8uCdJY1A3Cyciod2g== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qDhhA-0007hq-ED; Mon, 26 Jun 2023 04:35:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDhge-0006zy-1b for guix-patches@gnu.org; Mon, 26 Jun 2023 04:35:20 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qDhgd-0005wK-2G for guix-patches@gnu.org; Mon, 26 Jun 2023 04:35:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qDhgc-0000r9-Td for guix-patches@gnu.org; Mon, 26 Jun 2023 04:35:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64188] [PATCH 0/8] More package tuning Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 26 Jun 2023 08:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64188 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Josselin Poiret , Tobias Geerinckx-Rice , Simon Tournier , Mathieu Othacehe , Christopher Baines , 64188@debbugs.gnu.org, Ricardo Wurmus Received: via spool by 64188-submit@debbugs.gnu.org id=B64188.16877684843242 (code B ref 64188); Mon, 26 Jun 2023 08:35:02 +0000 Received: (at 64188) by debbugs.gnu.org; 26 Jun 2023 08:34:44 +0000 Received: from localhost ([127.0.0.1]:44406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDhgJ-0000qD-T1 for submit@debbugs.gnu.org; Mon, 26 Jun 2023 04:34:44 -0400 Received: from mail-wm1-f48.google.com ([209.85.128.48]:45089) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDhgG-0000pl-AO for 64188@debbugs.gnu.org; Mon, 26 Jun 2023 04:34:40 -0400 Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-3fa96fd7a04so7808525e9.2 for <64188@debbugs.gnu.org>; Mon, 26 Jun 2023 01:34:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687768474; x=1690360474; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date:message-id:reply-to; bh=Jh4bHbnaivWy9+Xjp+BeWbtiuvYVaPCMWBmnGKac6wE=; b=FfOpvQEZcUzEBqVCwdpdJ7Mb3n0eEQ1z+LzVDnyr542kyRaYTDnPoxqG0l1SdZR3Zh 3N1xjP1u0AE2PF/Ol3PGv3s+QkXF9XPNOofLVZ6mri0VOsYv0bcBPLgJgPaWQKOlZu0J ksDjwXTj94FXciFmVEY0XNS5VPGi7ZB3wxyZLev92rCDL06vg4TvJIY/6XFKS61BwDif SFHvpAvAs66UQlGdOxjEnNCV7F4K5XpYABDT1qyf5xXvZ7hBeAch+9KYqrBIRBCV7d99 2wHdk5jlLOvsN43D+Ui/EnSW57iXjUTxGaRKDCn3zDDOZ3GSLo0r4ALoU15tem/iJuTt plhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687768474; x=1690360474; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Jh4bHbnaivWy9+Xjp+BeWbtiuvYVaPCMWBmnGKac6wE=; b=SkqF4Mhdcjl69FnRgjLBW+b7VNB3QhOtBCKfNbkOkMg1kGLdn7KhXPfXsG8HtZ1WCT kgkFwg4Wpt4mNKrQVL7tpAFIRL64hJTxuDzaICp9zKVMrOnIIhpXDUu/Z9bJ2EyMAHQY F4kBy6//50iKHvvF2lw2x0KyA5PKlGK6S1oK/pMzCcruAXYcsXfN2kBEJVJrYGL6IETK BKilPd1sCShOVa8+qAfdLfzTRrzWCA8pASmKUF+SyOiK6cgixgWM7mbXUfai0BQC+XJg RoJLtlJWHb6j7GjFK6WepPATKwBbiVMN2pu5Z9vvbW0XhJcKAqAnng0kguuc3CL7tMFl 9wOQ== X-Gm-Message-State: AC+VfDxXZgLLg3sJv69ddJ5YJdlnHz0Z4gjNREJzPYR1n92bMNbb1H0i uz30JOSyEA+UzL1T3VG0bT8= X-Google-Smtp-Source: ACHHUZ71gLkEImj699XiwF648qt/bNNppCoJw6HYtVFD6O2NRzjlRz59rbbMf4Au5ev8MBRasBq4xQ== X-Received: by 2002:a05:600c:3647:b0:3fa:770b:366 with SMTP id y7-20020a05600c364700b003fa770b0366mr9568898wmq.27.1687768474434; Mon, 26 Jun 2023 01:34:34 -0700 (PDT) Received: from localhost ([188.120.129.124]) by smtp.gmail.com with ESMTPSA id m14-20020a7bca4e000000b003fa786b5195sm6912360wml.42.2023.06.26.01.34.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jun 2023 01:34:33 -0700 (PDT) Date: Mon, 26 Jun 2023 11:34:32 +0300 From: Efraim Flashner Message-ID: Mail-Followup-To: Efraim Flashner , Ludovic =?UTF-8?Q?Court=C3=A8s?= , 64188@debbugs.gnu.org, Christopher Baines , Josselin Poiret , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice References: <12026d29411b4ef0597d2f40d874ad2fcc49a087.1687247150.git.efraim@flashner.co.il> <87y1k7xnxt.fsf_-_@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Cq/edVlDIT5Ki3/b" Content-Disposition: inline In-Reply-To: <87y1k7xnxt.fsf_-_@gnu.org> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -2.35 X-Migadu-Queue-Id: E0912D0C5 X-Spam-Score: -2.35 X-TUID: 93iZWkC4PKru --Cq/edVlDIT5Ki3/b Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 25, 2023 at 10:54:38PM +0200, Ludovic Court=C3=A8s wrote: > Efraim Flashner skribis: >=20 > > * guix/cpu.scm (gcc-architecture->generic-architecture): New variable. >=20 > [...] >=20 > > +(define (gcc-architecture->generic-architecture gcc-architecture) > > + "Return a generalized micro-architecture, using an inexact matching = to provide > > +'good enough' optimizations." > > + (match gcc-architecture >=20 > Let=E2=80=99s call it =E2=80=98gcc-architecture->micro-architecture-level= =E2=80=99, with a > docstring that makes it=E2=80=99s clear that this is about x86_64 > micro-architecture levels. Sounds good to me. We can change the docstring if we end up adding support for more architectures (ie ppc64le). > Please also add a comment stating how to figure out what goes where so > we can more easily keep it up-to-date. >=20 > I guess this procedure is good enough for Go support, right? It would be better if we could populate x86_64-v4 and x86_64-v2, but I really didn't feel like I could comfortably draw the line anywhere and be sure I had the correct CPUs. If someone comes along and says they're sure their CPU should be in -v2 or -v4 then I/someone can check the gcc sources to make sure that's the case. I'm pretty sure there's other compilers out there that also use the psABI for tuning, my first look would be GHC. From my testing it does work for Go, and since we're using an official definition for the psABIs and not just Go's definitions I'm pretty confident it'll be useful for something else, somewhere. > Thanks, > Ludo=E2=80=99. Thanks for your review! --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --Cq/edVlDIT5Ki3/b Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmSZTZgACgkQQarn3Mo9 g1GWeBAAldzyvWXXb2F38Vgkdu0r5LBX2ZZnnZM+nQbupDDlKEV0iq0xjU2RbPeq 6IyQ8H1D6uo3qpmpIz9FfNsjtySw6QiiLgW7TrjEUnWt5gW7YzPmAwCM4tTuHSxC SeiCGdii36E0CRXUbhfmDIrFCPjpRvuUxeFBGZu8Ow/jmbwV9htpdFO+RkX/gSEP ee0NOPsVu9wgiQH1B5H3/mIjR/K9ZIVvz7zLAUBroqwKOip0rxUNEvJeSHWoz6Sy Ymg9dRfJTPPj5vPiG9E+90cOxExc4VXCnYm0KUL8tAzU67GHoRVfMlhsbJHoSf1D ZB6ufvuqg+H8A/+ILgeb+MIeEmYJProgdOuqzupCGfJ4Wif/3J3j3p/cJgfy7FSI 1n5xXSI3dHzdDa5vOrlAVF0FUh4FwQYfV+D5VmNNKNwXiU5EnNtReQhBZvsCi/qx Epcrkb/0GAh8WySAx2ULBM7ps/G0r8Jsvgc+26muGra1B/l6UJ7EdE+hkdGkHo93 oex4v3aiK5VseFDPYr0f1FfyP7kZUAMX7eSh45RhUQ0fHD9ymsHb/zvWUi7vDoHJ gvcrNdxzFYV0DFWTcQQW8lbZjSxQfqXhMrfTStjWzzvMrsFg0EsVw+W74j50dPln o8MznsFsLcwf/zZCtsJMYEJYnCYPbwMo15GGqPI6X3Xi+ktSBJ4= =sfUe -----END PGP SIGNATURE----- --Cq/edVlDIT5Ki3/b--