From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id cNdXAeZNmWQ7BgEASxT56A (envelope-from ) for ; Mon, 26 Jun 2023 10:35:50 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 2DZuAOZNmWTSvwAAG6o9tA (envelope-from ) for ; Mon, 26 Jun 2023 10:35:50 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A4F20D581 for ; Mon, 26 Jun 2023 10:35:49 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=cTnqN3QD; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1687768549; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=cXw5p1xY/vCxhn0hFFzXKc6RhA/Pt+6McItm98GWR7Y=; b=tySEenW/AmjDUoL2iOzH3IX9SimgTPTuQg7TMB1Qc2C7M3N/ONDj2MS1NHAvMlskgIRItb vhxy+j4dwQFuT3u3tDVlT/RJvkWbQzGZ+zFfASErHEPYENZPmZCvdJlPckTrkAYHeCKxVu KfMPaR0veoisxPP6qv85qUWj1B0jlWM2wWUzuuR/VQHqMg/jlweC8o+yqLX9yjaD7CeUzw uG5PtPq02Zw3rJEk8El9vnFDohQcD0iNCle8cB445dbsShitsauWRuCpPa9a+zuhRLm+8y 4iR88WoD/MxB/JGFYOfRqJzHXVZr24nWRAb1JShIbRs+JxNlg4iQWpCVwDpxUw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=cTnqN3QD; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1687768549; a=rsa-sha256; cv=none; b=BOYAe0rHXmdZEfTDdwoxS+FXEHNgIXSIexH0fOCGarl+RZTH0GkFSHOc4pUVjLhQW+EJwU JN+zf2VqyCe0tV7KjKlIqsyaZNxC9iRLlK23NWiJQ1BGmE11SCjF6XPiaFtDrpAM2/WXCZ bi/Dvy0a5J2I8dWPatWfqH5zKwqQOv/S3PnTHlDQLYAT4ilxra4RoaQIZMWwze8OTfUXhk fcgm6k6oUi4ZLbBeted2T63Pot30QfsfWn6YlJICan5yDia6TIqIXFkkkSg7bjJK9LdxVU nYyyF8YXe3v9vmGRhn86oVw2IU9yKsGl4y763sew0eppb3XnnQ23I51f3pM9Og== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qDhhJ-0007qb-L1; Mon, 26 Jun 2023 04:35:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDhge-0006zx-1X for guix-patches@gnu.org; Mon, 26 Jun 2023 04:35:20 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qDhgc-0005wD-UG for guix-patches@gnu.org; Mon, 26 Jun 2023 04:35:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qDhgc-0000r2-Gl for guix-patches@gnu.org; Mon, 26 Jun 2023 04:35:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64188] [PATCH 0/8] More package tuning Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 26 Jun 2023 08:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64188 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Josselin Poiret , Tobias Geerinckx-Rice , Simon Tournier , Mathieu Othacehe , Christopher Baines , 64188@debbugs.gnu.org, Ricardo Wurmus Received: via spool by 64188-submit@debbugs.gnu.org id=B64188.16877684813227 (code B ref 64188); Mon, 26 Jun 2023 08:35:02 +0000 Received: (at 64188) by debbugs.gnu.org; 26 Jun 2023 08:34:41 +0000 Received: from localhost ([127.0.0.1]:44403 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDhgG-0000px-8b for submit@debbugs.gnu.org; Mon, 26 Jun 2023 04:34:40 -0400 Received: from mail-wm1-f52.google.com ([209.85.128.52]:58580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDhgB-0000pd-Nb for 64188@debbugs.gnu.org; Mon, 26 Jun 2023 04:34:39 -0400 Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-3fa9850bfd9so5018025e9.0 for <64188@debbugs.gnu.org>; Mon, 26 Jun 2023 01:34:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687768470; x=1690360470; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date:message-id:reply-to; bh=cXw5p1xY/vCxhn0hFFzXKc6RhA/Pt+6McItm98GWR7Y=; b=cTnqN3QDfBn7aCI4qgfs+OaBHoBTjQaMoZlTkWCfkNPjB82cwAv7B+8jbpGEamH2d6 0sx7bOyuxfRYRDbGcFCJql8mhGgQRYk+8NgWrwQVZxPJhCX6ddGYjkOhCRRWfnL45uJH 1qBXcUhVlT1rwMJOwX9cNiOOsEKbkQJ7HTlEv+0QG8aHp3hociCI3of0ghWBYtBCLqLU pZXoaf1TJsTnYAIV8sis69E6dUgptcy+IFU5CMprIOLzLa5sWIxzSN6RiPdBpkiDHurz ozKN8L5uhEItKUFAcOmbEek329E72Z+/deTMJEsVuWET0CPtCTtWHhffjM0AgVQu500u 0/Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687768470; x=1690360470; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cXw5p1xY/vCxhn0hFFzXKc6RhA/Pt+6McItm98GWR7Y=; b=XN1NS482GYwSRqyDgenX8Bo8Bgk0DkB4X6Nkh8O8kjMV+Ivzq2cgOxxoVZzSq/0GOq CQDfm9xVJZlSaZdXqVUjEvPndX2TuoChdrJPMoCgvOWAPXJNTRkhVXxM/WHFlF4UrgUp dnKjwduAKHoh0YF2QmhsvOLOLnNl1fcshtyJz88J45oAhRoSovtm5qPLSFFgIQwvT6s5 rPUwJgmLlaevmCjhPnbEsgc8IPx4L7hui9km/Lwffb9myGTKZc5+k+YLWDEDupSMlh5j JiQnZfiMngt+/y5dprkmApJDzlNl785cP2MUj9QJghKBTT6VVlWNnn3mpuCAIWhiwTK3 GXSw== X-Gm-Message-State: AC+VfDzckzPKXec3kQXCcDopRr4Xu2R+NcuUMKtXLJg7soMLBFJLjKya A/SAHLBsWXJN4bYBK5hohB0= X-Google-Smtp-Source: ACHHUZ7tXz1QshcDcnNyfDIjXO41bv24dJoZwzegyQkx9dbdNV+h7XR3CLiqL41eKxZeD+TJP0IgTA== X-Received: by 2002:a7b:cd89:0:b0:3fa:7991:52b3 with SMTP id y9-20020a7bcd89000000b003fa799152b3mr5951467wmj.5.1687768469599; Mon, 26 Jun 2023 01:34:29 -0700 (PDT) Received: from localhost ([188.120.129.124]) by smtp.gmail.com with ESMTPSA id k1-20020a05600c0b4100b003fa82210e7asm7028423wmr.14.2023.06.26.01.34.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jun 2023 01:34:28 -0700 (PDT) Date: Mon, 26 Jun 2023 11:34:27 +0300 From: Efraim Flashner Message-ID: Mail-Followup-To: Efraim Flashner , Ludovic =?UTF-8?Q?Court=C3=A8s?= , 64188@debbugs.gnu.org, Christopher Baines , Josselin Poiret , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice References: <87352fz2m9.fsf_-_@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oqbyHUEZ5rohXrvh" Content-Disposition: inline In-Reply-To: <87352fz2m9.fsf_-_@gnu.org> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -3.65 X-Spam-Score: -3.65 X-Migadu-Queue-Id: A4F20D581 X-TUID: 29yXJge0Lw3Q --oqbyHUEZ5rohXrvh Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 25, 2023 at 10:52:14PM +0200, Ludovic Court=C3=A8s wrote: > Efraim Flashner skribis: >=20 > > * guix/transformations.scm (tuned-package)[build-system]: Don't replace > > the build-system if inheriting from the go-build-system. > > [arguments]: If using the go-build-system add a phase to set the > > micro-architecture for Go. >=20 > [...] >=20 > > @@ -570,14 +571,42 @@ (define (tuned-package p micro-architecture) > > (package > > (inherit p) > > (build-system > > - (build-system-with-tuning-compiler (package-build-system p) > > - micro-architecture)) > > + ;; The go compiler doesn't need to be wrapped. > > + ;; XXX: This is where we check for supported micro-architectures. > > + (if (eq? (build-system-name (package-build-system p)) > > + 'go) > > + (package-build-system p) > > + (build-system-with-tuning-compiler (package-build-system p) > > + micro-architecture))) > > (arguments > > ;; The machine building this package may or may not be able to ru= n code > > ;; for MICRO-ARCHITECTURE. Because of that, skip tests; they are= run for > > ;; the "baseline" variant anyway. > > (substitute-keyword-arguments (package-arguments p) > > - ((#:tests? _ #f) #f))) > > + ((#:tests? _ #f) #f) > > + ;; We add the tuning parameter after the default GO flags are s= et. > > + ((#:phases phases '%standard-phases) > > + (if (eq? (build-system-name (package-build-system p)) > > + 'go) > > + #~(modify-phases #$phases > > + (add-after 'setup-go-environment 'set-microarchitecture >=20 > Can we use the same approach as before with > =E2=80=98build-system-with-tuning-compiler=E2=80=99? That seems more rob= ust to me and > it=E2=80=99d be more consistent. I'll look to see how to move this into build-system-with-tuning-compiler. I think I previously got hung-up on the tuning-compiler function which wouldn't work for go. At first glance it looks like I could just lift-and-shift the extra phase over. I'll just have to make sure that either it's only for the go-build-system or occurs sometime after the setup-go-environment phase but before/after a phase which exists in all build systems. Then it's the toss-up between leaving it as-is and only occurring with the go-build-system or also occurring on any tuned package which also has go code. --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --oqbyHUEZ5rohXrvh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmSZTZAACgkQQarn3Mo9 g1GHxQ//cBUnVpVa4hjFh7MDmNLQb8ns9qu6MgkWr3Y1uwyO/QTY42N6yBsfm9or mn2zAfw0NFPNXPmjX3LHC1B5tJ1LKt4cHlK7N6YSu/geR7P921eLLdnYPG84/5JK WbcdlrhW17mj1FaC0vE5vDcOrPsFdKLO5L0qPSed4dS+QDGUq8PaxYcsN8Qw4EXj 62ql5JP6IDxmEY0BFuMN0bFXxvB7vnxdz6i57O1B7gVOdwj3HLL/5gLCovYhbAAk P+5mMocLuFuJF8PL1Dioz5dIdvVyGgjoKhqMoY5Ph9rdLhjeZCCLKYKCOniNOUlH AOsXoeg7gHD1ufi4J1FCTAzXRUNg8V/spJ1kxedJKk95Xvfsn+4HVDOtpOfTADcJ /wfHwAJXyAhRAbzV8UQOrvRalWNKxgpoyTe0JPewcJkYg3hvs9nJ764SDuDZO6ST LUxXvP23TbH9f+IYDQFkuIZ5bb9FJKc5pcyb4+6tkSo2FUgM2Pz5feWNTaTMKfg2 2Glg1qXnvwhOXCTeZIQW6cnOIBg6K5dDzPokct9DickuOHOb8G80n6cP4JO6yToN ZKbBJ21GyGzg2RW4ngRj5hMQGmq88ii447CBCrrkmSQ1+nDKGw3eGokQQnxygewW XCSxmkEAvoWeOQEJZ5oRMYpF6LN5jOAHmwg3cbjVsPMs9uMsxuY= =q4Dn -----END PGP SIGNATURE----- --oqbyHUEZ5rohXrvh--