From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id APDRFSwIg2TMvAAASxT56A (envelope-from ) for ; Fri, 09 Jun 2023 13:08:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id mByBFSwIg2Q30QAAauVa8A (envelope-from ) for ; Fri, 09 Jun 2023 13:08:28 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1EDC13754C for ; Fri, 9 Jun 2023 13:08:28 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1686308908; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=yL/U6rh9bOdGfNYMJBxzl0mM6wJx4On/adeSk/CZMEQ=; b=oN2J6ApcIe13if6FW5kImrQ2G8Lr/+ieElxP/w+TBPKBXX/KpsqheXONSsrh6GGLVIYJqi IFM9z3O0NA+Lac6JbtmWh4XqlwKSRlOSJ18kXDjKKvxYPPXZSPTadwM8Quf8kSYXUi6Ql7 kArQFQPBdN1YRyn/gEFp3NgqqIzX1uCwm03r/EO6GOIRMNu20rlG/fb8mduNMpfGuratw4 cQW4fMtW+EEmfD8dJohCwQdsxcB1RNTTAD7n8G5yUSPixgx+kqU0xwcJciJr3Ic+epBxKU dTtvlkWukRWmPQ4kmFEUCHyRZtxMsc5H4okrqy1BtGk25B3zbGw9Ht2TwnOUrA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1686308908; a=rsa-sha256; cv=none; b=HlyCtY8fCWZvlmurD9vWUDuk4VHS6Ido9f3vE7VrOXr5YesyqndKWRAQPBmQnAinUcFEJQ IpM06aYTg3aeqPT3sUmYmQQgzRCwWKEsshL7BokBDUPVy+tzodJZpuQYUseqnqiNbSM9hb CWei+q2tBlHuY7pQYCBR8t4fkjIX4pDq2RPVHnxIlSDzpflB2X7pw0dtOOB+q14GeYL+jF C7ksKjWTIiPZIMxsElmngaVwkQh1bP2bfrzjOcAxVwS0gAg0L0GaAeQ2dqxnnIAq6qdEUM QdKtn4Lu5u1VT69apn80TI+KrARljvryoKmLlUUxXQM7RpFBEGVhmU2RwlYr6g== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q7Zy1-00062Q-DA; Fri, 09 Jun 2023 07:07:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7Zxz-00061f-A5 for guix-devel@gnu.org; Fri, 09 Jun 2023 07:07:39 -0400 Received: from hera.aquilenet.fr ([2a0c:e300::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7Zxx-0006Wk-7V for guix-devel@gnu.org; Fri, 09 Jun 2023 07:07:39 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 7B9732A2; Fri, 9 Jun 2023 13:07:32 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gwRfxlV6JGfv; Fri, 9 Jun 2023 13:07:31 +0200 (CEST) Received: from jurong (unknown [IPv6:2001:861:c4:f2f0::c64]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 931EC9E; Fri, 9 Jun 2023 13:07:31 +0200 (CEST) Date: Fri, 9 Jun 2023 13:07:30 +0200 From: Andreas Enge To: Andy Tai Cc: 63526-done@debbugs.gnu.org, 63952-done@debbugs.gnu.org, guix-devel@gnu.org Subject: Re: ping on a build fix for a build failure (main branch) Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=2a0c:e300::1; envelope-from=andreas@enge.fr; helo=hera.aquilenet.fr X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: UNKNOWN X-Migadu-Flow: FLOW_IN X-Spam-Score: -1.56 X-Migadu-Queue-Id: 1EDC13754C X-Migadu-Scanner: in3.migadu.com X-Migadu-Spam-Score: -1.56 X-TUID: PbroH8wmqtI+ Hello Andy, Am Tue, May 30, 2023 at 10:54:20AM -0700 schrieb Andy Tai: > Hi, following previous comments (thanks) I have submitted a patch to > correctly fix a build failure due to compiler warnings, instead of > avoiding not building tests, on this Guix bug issue: > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63526 > Please review the patch (which shall be a simple and low risk fix). Thanks! I have reworked a bit the punctuation of the commit message, shortened the patch file name and pushed. By this I am closing the two corresponding bug reports (it would have been enough to send a second version of the patch to the first bug). Did you contact upstream? Looking at the test, it looked wrong before and after your patch... if (len < token->data.character.len) { hubbub_token t = { 0 }; t.type = HUBBUB_TOKEN_CHARACTER; t.data.character.ptr += len; t.data.character.len -= len; ... Adding to a previously undefined, now 0 pointer .ptr raised a warning for a reason, I think; and it looks like the t.data maybe should be token->data. But it is quite possible that this branch is not even reached by the test. Andreas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id QCinGH0+g2RSGwAASxT56A (envelope-from ) for ; Fri, 09 Jun 2023 17:00:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id IHaNGH0+g2SxqQAA9RJhRA (envelope-from ) for ; Fri, 09 Jun 2023 17:00:13 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 559B73ADB6 for ; Fri, 9 Jun 2023 17:00:11 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1686322813; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=yL/U6rh9bOdGfNYMJBxzl0mM6wJx4On/adeSk/CZMEQ=; b=AakrCvg5Z+YgmkDTq7ebY+ypLThj8pJsd+KepZLUVAF51Y/iBljUr8azhy5PvAWX1NFSIg GOYRR0YPhGF6jJubjr6njdV/IXlGa+wH8S6lDZxSY84mrHwA5K1q3ndZmnEKL1DJewda8/ BthiRasDh4cjIDnLsKpxs1wicUL6UMSjoZvdAOiTHvpzL34Fa54c9ZNkZW0N01C5oRwBYy Gf/zWMlHTnQZG6O7yNGxbEpTofjvOMrpUt5AAeefrB4Bc3WWmd5DAwFWgxkL4EwP4Laj85 zWhj70tkE+rwcGElCuIj1V0YuCR2lE82mS1fLJM8GS8zsMqWJNE/wB+cU6xT7w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1686322813; a=rsa-sha256; cv=none; b=cVeR9QWNlCp9ZyD4QV5xyrzxgCTg2DpBo1TrRulYJuVP+ZG7XTkVS3IZp4qX1Aif7sHxvY vo3lfAprf+Cs1UKVEFknH+sBbd4BHa2oL/l4iC7tlqmz//VHJL3Hq4/IeliKOvJb7wHQKs BL0xF+Z+aywveQIS3eKCpppK496wu1dz/ftU2F933D3OIEGY3DXBTmQuGNmRa2PW9pXtBe lDSD8qlQufjo11JXX98vNPv5nAd8o+Toqx1xk9C8t+hiEbW+g9AfEz0+GcGJ2QKvGr2sIQ TssQpMC0ePbq4ZI1dA/NFhLhda3VylLtw4hg2iOZeQQf0Pb9lMOIrNAbRr7vpA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q7Zyp-0006Px-3s; Fri, 09 Jun 2023 07:08:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7ZyN-0006GM-6c for guix-patches@gnu.org; Fri, 09 Jun 2023 07:08:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q7ZyM-0006Yy-UA for guix-patches@gnu.org; Fri, 09 Jun 2023 07:08:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q7ZyM-000427-Ob for guix-patches@gnu.org; Fri, 09 Jun 2023 07:08:02 -0400 Subject: bug#63952: ping on a build fix for a build failure (main branch) Resent-From: Andreas Enge Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Fri, 09 Jun 2023 11:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 63952 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andy Tai Cc: guix-devel@gnu.org, 63526-done@debbugs.gnu.org, 63952-done@debbugs.gnu.org Mail-Followup-To: 63952@debbugs.gnu.org, andreas@enge.fr, atai@atai.org Received: via spool by 63952-done@debbugs.gnu.org id=D63952.168630886015449 (code D ref 63952); Fri, 09 Jun 2023 11:08:02 +0000 Received: (at 63952-done) by debbugs.gnu.org; 9 Jun 2023 11:07:40 +0000 Received: from localhost ([127.0.0.1]:58463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7Zy0-000412-7Z for submit@debbugs.gnu.org; Fri, 09 Jun 2023 07:07:40 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:53740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7Zxy-00040h-5n; Fri, 09 Jun 2023 07:07:38 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 7B9732A2; Fri, 9 Jun 2023 13:07:32 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gwRfxlV6JGfv; Fri, 9 Jun 2023 13:07:31 +0200 (CEST) Received: from jurong (unknown [IPv6:2001:861:c4:f2f0::c64]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 931EC9E; Fri, 9 Jun 2023 13:07:31 +0200 (CEST) Date: Fri, 9 Jun 2023 13:07:30 +0200 From: Andreas Enge Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: UNKNOWN X-Migadu-Flow: FLOW_IN X-Spam-Score: -1.56 X-Migadu-Queue-Id: 559B73ADB6 X-Migadu-Scanner: in3.migadu.com X-Migadu-Spam-Score: -1.56 X-TUID: Tg4ZAq1jbm92 Message-ID: <20230609110730.XuC3tA1V7YguLkJsjdLyUGIUIS4mRHN6kLL3UNh2zOc@z> Hello Andy, Am Tue, May 30, 2023 at 10:54:20AM -0700 schrieb Andy Tai: > Hi, following previous comments (thanks) I have submitted a patch to > correctly fix a build failure due to compiler warnings, instead of > avoiding not building tests, on this Guix bug issue: > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63526 > Please review the patch (which shall be a simple and low risk fix). Thanks! I have reworked a bit the punctuation of the commit message, shortened the patch file name and pushed. By this I am closing the two corresponding bug reports (it would have been enough to send a second version of the patch to the first bug). Did you contact upstream? Looking at the test, it looked wrong before and after your patch... if (len < token->data.character.len) { hubbub_token t = { 0 }; t.type = HUBBUB_TOKEN_CHARACTER; t.data.character.ptr += len; t.data.character.len -= len; ... Adding to a previously undefined, now 0 pointer .ptr raised a warning for a reason, I think; and it looks like the t.data maybe should be token->data. But it is quite possible that this branch is not even reached by the test. Andreas