all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: Carl Dong <contact@carldong.me>
Cc: 64100@debbugs.gnu.org, lists@coryfields.com,
	Cory Fields <cory-nospam-@coryfields.com>
Subject: [bug#64100] [PATCH] gnu: llvm: make clang-make-toolchain public
Date: Sun, 18 Jun 2023 09:38:05 +0300	[thread overview]
Message-ID: <ZI6mTZ56BzJR_Tla@3900XT> (raw)
In-Reply-To: <285400E6-BEC5-4686-B070-FDCD3A1A2599@carldong.me>

[-- Attachment #1: Type: text/plain, Size: 1670 bytes --]

On Fri, Jun 16, 2023 at 04:40:22PM -0400, Carl Dong wrote:
> Simple enough and matches gcc-make-toolchain.
> 
> Allows for more complex manifests and packages to be built with a custom clang toolchains without forking Guix.
> 
> I think I still have push rights so I’ll push in 2 weeks if there are no other objections (this shouldn’t trigger any rebuilds at all).

Sounds good to me

> > On Jun 15, 2023, at 2:05 PM, lists@coryfields.com wrote:
> > 
> > From: Cory Fields <cory-nospam-@coryfields.com>
> > 
> > Matches gcc-make-toolchain. Allow for llvm build to be patched.
> > 
> > * gnu/packages/llvm.scm: make clang-make-toolchain public
> > 
> > Signed-off-by: Cory Fields <cory-nospam-@coryfields.com>
> > ---
> > gnu/packages/llvm.scm | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm
> > index f59c8e9592..6d83313af6 100644
> > --- a/gnu/packages/llvm.scm
> > +++ b/gnu/packages/llvm.scm
> > @@ -502,7 +502,7 @@ code analysis tools.")
> >               "znver3")
> >             '())))))
> > 
> > -(define (make-clang-toolchain clang libomp)
> > +(define-public (make-clang-toolchain clang libomp)
> >   (package
> >     (name (string-append (package-name clang) "-toolchain"))
> >     (version (package-version clang))
> > 
> > base-commit: 6e1215fb9c03ccb4a2d4440990aee5a66a935268
> > -- 
> > 2.25.1
> > 
> > 
> > 
> > 
> 

-- 
Efraim Flashner   <efraim@flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2023-06-18  6:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-15 18:05 [bug#64100] [PATCH] gnu: llvm: make clang-make-toolchain public lists
2023-06-16 20:40 ` Carl Dong
2023-06-18  6:38   ` Efraim Flashner [this message]
2023-07-02 17:16     ` Carl Dong
2023-06-19 13:50 ` Michael Ford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZI6mTZ56BzJR_Tla@3900XT \
    --to=efraim@flashner.co.il \
    --cc=64100@debbugs.gnu.org \
    --cc=contact@carldong.me \
    --cc=cory-nospam-@coryfields.com \
    --cc=lists@coryfields.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.