From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id MJ6yOAEdfmSiewEASxT56A (envelope-from ) for ; Mon, 05 Jun 2023 19:36:01 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id WDK1OAEdfmQkagAA9RJhRA (envelope-from ) for ; Mon, 05 Jun 2023 19:36:01 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 48343F74A for ; Mon, 5 Jun 2023 19:36:01 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q6E7D-0006Nh-Mn; Mon, 05 Jun 2023 13:35:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6E75-0006Mz-Vo for Help-Guix@gnu.org; Mon, 05 Jun 2023 13:35:28 -0400 Received: from wolfsden.cz ([37.205.8.62]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6E71-0004aM-AV for Help-Guix@gnu.org; Mon, 05 Jun 2023 13:35:27 -0400 Received: by wolfsden.cz (Postfix, from userid 104) id ADFA91ED262; Mon, 5 Jun 2023 17:35:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1685986513; bh=+dXBVeMFz1G7xcqLv02jqvVDGSnCK8M5zXGyDDsbyWI=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=nW/dgrTTZT3SupYkCSACLwC4ZrDkhIi2dX8TgVGkwM3SmdoWpChNVyTMbFiAuUyfw FUDt9qDpo92YibqoD8ECA1TncYDN/yyPtmPg1YT2eDLvxuiA15Oirlty5Xb3pVPd6e S0HPwv0g5ZSwJhqZSg368Tx8nKyfYwNMQxkqUzZSza9ISxfCOAhhtRg+YohwQejkX3 VVxNrf3U4UA5d2il6R4ahV7W2FUo0oq2Uhl6o8bk7/VEQ0mkE1KR3mtHuC3o4IYmIX e9jLfKKyVMZPBS86ZZ5weqQIgj1bcijtnrMnKvN6qBQDmcaOIaOcridK2Ciotyb0KR edfjGO2ZKzdqQ48XQkNN7IqRIeQRO9/cZsDtG/X8VoqWz1jbDTFZWezhGaEwsKfoY1 bhv/Z+aamrGwoQgTLGZnHEpwei5E/EYCNKFjvlQGFzJ8dKWcCI6IysWV5Ml7fA+2Eh xbW/wqYeFYVIkArqlMiX94wsBszIFEgkw0F47nsjRcbleOuW9kX1o82t+zMa9ZYwK5 VtxtwQVQ/2TK35mxTEjr2y7dbAVnVOvjtF4VMsQjXdRdriVMwIodyYLlyf3gRJsXmN CReuM5KSgivVKRQWMpn4Kq8BpERS2eWIujq3rRGJoIT2kdfZM8BiSuVA3Kmc2SnbF8 OcOufu4IFoteBy8t7iXVaHrE= Received: from localhost (unknown [128.0.188.242]) by wolfsden.cz (Postfix) with ESMTPSA id CF7521ECC56; Mon, 5 Jun 2023 17:35:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1685986512; bh=+dXBVeMFz1G7xcqLv02jqvVDGSnCK8M5zXGyDDsbyWI=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=OU4GIIo0c1AXxVEmCCtjT0UsYs+zxMTxf1lxls1XnceMs17dnzACRCQ9lR6jI8lx7 nd3yMQcscmXjLymIPVM6Y3gSsDKNE344zhnh7UIVk+WIgrfMCfW7Ou/ahugTxfCy+n PK79+XwNyqGGKs1RESYfjqt4AXYOE+BIvh77xo22nX8V3mHvmXlwXmPoyR+31Ix1fi MawV8qVLGeHsOt5DPeG2OV48QubKT/Hf62U1+wvhFBvN0SaR4AV+4BMliopEuURuPW 0gZrwCXnHS4Y+DZeSTW7R+fcub38ulGF3tD5+iUJ/PgS5jcV99bZtpgOom0EJWqFyK ni4kWx+aQNnFqhMpsTSPxPUZtexxf7dxP06ifLge/IT0cDywQ6UgjXp59yTYEMhn3e uq3jwNs0+QcJDlRTz/Vjdv5z+WUGGhKefKlGHo21kZZA2JHcBFGRzzidBaL3jA0jL9 wYezquNK4JMHGBMCeFCwO0fKLUuMiS9ocpMWVAu/IIvqUQHEAkGFw1F2qRmPZhSZm3 YXkpKps8ZJnrirl07BUpL52lrWiFMeER4QOHfCT943K05adSDCX9OS+JnQSCF9596I 86Cf19Frt+4rCNh+OZJ85Wmaa0doBoh5DLqO4qmWOtXSxqqCJRLGgD7qLHK6/XQdl/ yy9OwI/aqykpaszaXCp5yBDM= Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id a4c082de; Mon, 5 Jun 2023 17:35:11 +0000 (UTC) Date: Mon, 5 Jun 2023 19:35:11 +0200 From: wolf To: Graham Addis Cc: Help-Guix@gnu.org Subject: Re: guix docker on gitlab-ci Message-ID: Mail-Followup-To: Graham Addis , Help-Guix@gnu.org References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2XI3IgQMrkUefLlk" Content-Disposition: inline In-Reply-To: Received-SPF: none client-ip=37.205.8.62; envelope-from=ws@wolfsnet.cz; helo=wolfsden.cz X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_PASS=-0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, UNPARSEABLE_RELAY=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: help-guix@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-guix-bounces+larch=yhetil.org@gnu.org Sender: help-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1685986561; a=rsa-sha256; cv=none; b=cNjAVM0XPk7LafmyaZ4maOTGHskdYsHkSxf7kqRU7FfMakmjzifkkOC3bJI/PSmVla/cip A0C6nVaqNklfve+AOgRSDGCjNfqJUpeflMIFvqzrl5BXDV+3Rm7TUHS0XQvXScl+cqjDRd MYLvCJXdul1i/JZuw97z4qdfJMjkwGQng7PDwigoI0mkMUiyhoi1NYxdIKQPq5RyZE8Rd3 WyIIS6M+X51N9x6gqd1ofVqbVlaN2DQ5npZ+Spe6j5ec1dkfOzVB0OOK136hbuubyePVBB aE2hGLz6HX7aewUN0Qo0m6pLs/LfyYuq2jktkVslzSMxQyjzRwAJiXp0WEyBaw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=wolfsden.cz header.s=mail header.b="nW/dgrTT"; dkim=pass header.d=wolfsden.cz header.s=mail header.b=OU4GIIo0; dmarc=pass (policy=none) header.from=wolfsden.cz; spf=pass (aspmx1.migadu.com: domain of "help-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="help-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1685986561; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ms2TSHoP0gG9821ujU4Evs58Xz7JOBdWbM3FDGNVLtc=; b=DuJ5Fv9D05Mi/tT7OyvgVf/p9ZW4+e85di8obVGVIsHsef7mRzGg4GBYzTbi2psbwsMGmb uQnjPf6Tjcpv4BPM6fdwyCAp5S4tQ8Xv8/2hv5PECukRTtPkp1UOW8HMQOMZB0rpmPl+41 n7DlieXoCa2pEDGgU3chPiBrTZYrVPzAtB1ykZ56qf3q/btqQxGNSQcSMwjCw9xlSKdNlw CEBXgKrFDOtMpsuVlj9cIVEgfI6w1Oz7UExAKSFko3NJc50G5GRfpvVDw4tfJPCdXZZOAP 4d5XUxuBClPp896W1L5HDbMbzizrAjco7/cE8klV9QeksqVD2/nJFQlA95bRbg== Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=wolfsden.cz header.s=mail header.b="nW/dgrTT"; dkim=pass header.d=wolfsden.cz header.s=mail header.b=OU4GIIo0; dmarc=pass (policy=none) header.from=wolfsden.cz; spf=pass (aspmx1.migadu.com: domain of "help-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="help-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -9.25 X-Spam-Score: -9.25 X-Migadu-Queue-Id: 48343F74A X-TUID: 5iMgJUBFL5Gn --2XI3IgQMrkUefLlk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2023-06-05 16:37:50 +0100, Graham Addis wrote: > Hi Wolf, >=20 > Not a particularly successful weekend... >=20 > As --entry-point was used by other pack methods I thought the best > option would be to add a --docker-entry-point just for the docker > format and pass it into the build as an extra-option like for deb and > rpm formats. >=20 > However I couldn't work out how to pass in a list via the > extra-options, so I'm a bit stuck. >=20 > If there is anyone who knows their way around the pack scripts and can > point me in the right direction, that would help, but other than that > I'll probably get some more time next weekend. I did not try to implement this, so my guess might be completely off, but looking at how -S is implemented, I would suggest trying something like: 1. Introducing new %docker-format-options and friends (similar to already existing %deb-format-options and friends), providing the --entry-point-a= rg options, that would be specific to a docker format (although I am not su= re if it needs to be specific, maybe some other formats support arguments as well?). 2. Writing entry-point-arg-spec-option-parser, while taking inspiration from symlink-spec-option-parser. Yours would be much simpler, since you woul= d be just accumulating values into a list. As for the extra-options, I guess modifying current code (by adding the 'do= cker option) into something like: (extra-options (match pack-format ('deb (list #:control-file (process-file-arg opts 'control-file) #:postinst-file (process-file-arg opts 'postinst-file) #:triggers-file (process-file-arg opts 'triggers-file))) ('docker (list #:entry-point-args (process-file-arg opts 'entry-point-arg))) ('rpm (list #:relocatable? relocatable? #:prein-file (process-file-arg opts 'prein-file) #:postin-file (process-file-arg opts 'postin-file) #:preun-file (process-file-arg opts 'preun-file) #:postun-file (process-file-arg opts 'postun-file))) (_ '()))) could work? build-docker-image already accepts a list as an #:entry-point,= so it should be just a matter of properly composing the list. Not sure if this is helpful. W. >=20 > Graham >=20 > On Fri, 2 Jun 2023 at 09:13, Graham Addis wr= ote: > > > > Hi Wolf, > > > > On Thu, 1 Jun 2023 at 22:55, wolf wrote: > > > > > > On 2023-05-31 18:47:03 +0100, Graham Addis wrote: > > > > I could use the equivalent format for --entry-point > > > > > > > > --entry-point executable --entry-point param1 --entry-point param2 > > > > > > > I think that is a reasonable idea. Only downside is that it would no= t be > > > backwards compatible (since currently last --entry-point wins), howev= er I am not > > > sure if someone actually relies on that behavior. > > > > > > Backwards compatible way would be keeping --entry-point as it is and = introducing > > > new argument (--entry-point-arg) that could be used to build the argu= ment list, > > > but I might be overthinking it :). > > > > I'll go with extending --entry-point to accept multiple values and use > > all of them for --format=3Ddocker and simply use the last one provided > > for the other formats. > > > > I'll try to put a patch together at the weekend. > > > > Thanks for all your input, it really helps. > > > > Graham >=20 --=20 There are only two hard things in Computer Science: cache invalidation, naming things and off-by-one errors. --2XI3IgQMrkUefLlk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmR+HM8ACgkQL7/ufbZ/ wakuaQ//Q6AyyWb/wtHR8iNC6YnJRNzgzWYxWBFiYv5uqt1kxBor8eDXVHzfdBeq vndQXm11FHPVvnZyUe5ZqV0G7sTUbNr5CDwtCW1xLkW2YgGn67paSn+PxaK05I9a wBblswb7uWPHROlShXuiH4YAHxXHnqgu7Y0gcY4qj2hTnO3Uxgki6XIctJjbHhxm 71nThE/VhPbqmFABijy44S/yccoPntOAudTlx/zTR5CVl1XSMuMIYIDZVKJ21awl /jtrW6NG5oz7FoE6UXdwlNZhpb5qfYLgW5L1OIsq4vmZe2t4naTvDTYKHBHS78pk d1fr0WGhvtbf3C1c/FFWYr9YlK+RUombUS8Fp2aVyh+kg9N3JRzwMxvjlgj3uys9 TAlRp6EBlU6P8S88iB6W5fVjxQqyZrKHAsBzPdNyPWgLSSWPWC/Wf6TEafqa9a3n zO7jwLDOaBEKg28mDNHOpQo8uP9sDeoyW1q4cwtKz6fTWzgBpxmIIYaIshw/RcFl XN3PJWlkXDfGNNmwGoYIKk1jYge7KMKmALjduvV8WzM/vF5Xvq8sMo0COu0/pROe /zIDnpGEanCK1w91+9iZoOOVrR1GKqcolj/9cNrz9XwNDP4I7eGOGreAWQEnFBL7 CfeaCUwA/H9eLdkzOKZ7eDk8Z8WvRngcKLbPFnYsc4RqRikMXDo= =eBde -----END PGP SIGNATURE----- --2XI3IgQMrkUefLlk--