bug#63280: encfs: Fails to build (test segfaults)

bug#63280: encfs: Fails to build (test segfaults)

[Ivan Vilata i Balaguer]

[-- Attachment #1: Type: text/plain, Size: 2093 bytes --]

Hi!  It looks like one of the tests in package `encfs` consistently segfaults
in the version of Guix shown below:

```
$ LANG=C guix describe
Generation 56   May 02 2023 11:25:26    (current)
  guix 3f8c489
    repository URL: https://git.savannah.gnu.org/git/guix.git
    branch: master
    commit: 3f8c4899a9a67bb509a603bd21dcfcfab88c0e8e
```

This is the final part of the build log:

```
starting phase `check'
Running tests...
/gnu/store/ygab8v4ci9iklaykapq52bfsshpvi8pw-cmake-minimal-3.24.2/bin/ctest --force-new-ctest-process 
Test project /tmp/guix-build-encfs-1.9.5.drv-0/build
    Start 1: unit
1/1 Test #1: unit .............................***Exception: SegFault  0.01 sec
Running main() from /tmp/guix-build-encfs-1.9.5.drv-0/encfs-1.9.5/vendor/github.com/google/googletest/googletest/src/gtest_main.cc
[==========] Running 16 tests from 2 test suites.
[----------] Global test environment set-up.
[----------] 1 test from MemoryPool
[ RUN      ] MemoryPool.Allocate
[       OK ] MemoryPool.Allocate (0 ms)
[----------] 1 test from MemoryPool (0 ms total)

[----------] 15 tests from CipherKey/CipherTest
[ RUN      ] CipherKey/CipherTest.SaveRestoreKey/0
[       OK ] CipherKey/CipherTest.SaveRestoreKey/0 (5 ms)
[ RUN      ] CipherKey/CipherTest.SaveRestoreKey/1


0% tests passed, 1 tests failed out of 1

Total Test time (real) =   0.01 sec

The following tests FAILED:
	  1 - unit (SEGFAULT)
Errors while running CTest
make: *** [Makefile:94: test] Error 8

Test suite failed, dumping logs.
error: in phase 'check': uncaught exception:
%exception #<&invoke-error program: "make" arguments: ("test" "-j" "4") exit-status: 2 term-signal: #f stop-signal: #f> 
phase `check' failed after 0.0 seconds
command "make" "test" "-j" "4" failed with status 2
```

I saw a couple of encfs issues regarding segfaults in tests, but I don't think
they're related: <https://github.com/vgough/encfs/issues/378>
<https://github.com/vgough/encfs/issues/600>

Thanks a lot, and cheers!

-- 
Ivan Vilata i Balaguer -- https://elvil.net/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#63280: encfs: Fails to build (test segfaults)

[Ivan Vilata i Balaguer]

[-- Attachment #1: Type: text/plain, Size: 1417 bytes --]

Ivan Vilata i Balaguer (2023-05-04 18:46:54 +0200) wrote:

> Hi!  It looks like one of the tests in package `encfs` consistently segfaults
> in the version of Guix shown below:
> 
> ```
> […]
>     commit: 3f8c4899a9a67bb509a603bd21dcfcfab88c0e8e
> ```
> 
> This is the final part of the build log:
> 
> ```
> starting phase `check'
> Running tests...
> /gnu/store/ygab8v4ci9iklaykapq52bfsshpvi8pw-cmake-minimal-3.24.2/bin/ctest --force-new-ctest-process 
> Test project /tmp/guix-build-encfs-1.9.5.drv-0/build
>     Start 1: unit
> 1/1 Test #1: unit .............................***Exception: SegFault  0.01 sec
> Running main() from /tmp/guix-build-encfs-1.9.5.drv-0/encfs-1.9.5/vendor/github.com/google/googletest/googletest/src/gtest_main.cc
> […]
> ```
> 
> I saw a couple of encfs issues regarding segfaults in tests, but I don't think
> they're related: <https://github.com/vgough/encfs/issues/378>
> <https://github.com/vgough/encfs/issues/600>

I repeated the build with Guix commit 14c03807 and `encfs` tests failed in the
same way.  I tested the fix in <https://github.com/vgough/encfs/issues/600>,
i.e. `guix build encfs --with-input=openssl=openssl@1.1.1q`, and the build
succeeded, tests and all.  I also tried `--with-graft` instead of
`--with-input`, but the issue happened again.

I hope that this is useful!

-- 
Ivan Vilata i Balaguer -- https://elvil.net/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#63280: encfs: Fails to build (test segfaults)

[Ivan Vilata i Balaguer]

[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]

Ivan Vilata i Balaguer (2023-05-19 13:40:27 +0200) wrote:

> I repeated the build with Guix commit 14c03807 and `encfs` tests failed in the
> same way.  I tested the fix in <https://github.com/vgough/encfs/issues/600>,
> i.e. `guix build encfs --with-input=openssl=openssl@1.1.1q`, and the build
> succeeded, tests and all.  I also tried `--with-graft` instead of
> `--with-input`, but the issue happened again.

I rebuilt `--with-git-url=encfs=https://github.com/vgough/encfs.git` with the
same result.

However, I copied the definition of the `encfs` package to another file,
changed `(inputs (list attr fuse openssl tinyxml2))` to `(inputs (list attr
fuse openssl-1.1 tinyxml2))` (i.e. `openssl -> openssl-1.1`), and the built
succeeded and tests passed.

Please note that
<https://github.com/vgough/encfs/issues/600#issuecomment-950026929> points out
that, around 3 years after the release of EncFS v1.9.5 (the version used in
Guix), OpenSSL v3 was still very recent, so EncFS may have never been
thoroughly tested with it anyway.

Maybe reverting to its dependency to OpenSSL v1.1 would be a good choice
(esp. since v1.1 still receives fixes).

Cheers!

-- 
Ivan Vilata i Balaguer -- https://elvil.net/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#63280: encfs: Fails to build (test segfaults)

[Ivan Vilata i Balaguer]

[-- Attachment #1: Type: text/plain, Size: 934 bytes --]

Ivan Vilata i Balaguer (2023-05-19 14:11:37 +0200) wrote:

> […] I copied the definition of the `encfs` package to another file,
> changed `(inputs (list attr fuse openssl tinyxml2))` to `(inputs (list attr
> fuse openssl-1.1 tinyxml2))` (i.e. `openssl -> openssl-1.1`), and the built
> succeeded and tests passed.
> 
> Please note that
> <https://github.com/vgough/encfs/issues/600#issuecomment-950026929> points out
> that, around 3 years after the release of EncFS v1.9.5 (the version used in
> Guix), OpenSSL v3 was still very recent, so EncFS may have never been
> thoroughly tested with it anyway.
> 
> Maybe reverting to its dependency to OpenSSL v1.1 would be a good choice
> (esp. since v1.1 still receives fixes).

I sent a patch doing that: <https://issues.guix.gnu.org/63593>

(Is it better to send the patch as a reply to this thread?)

Thanks!

-- 
Ivan Vilata i Balaguer -- https://elvil.net/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]