From: Ivan Vilata i Balaguer <ivan@selidor.net>
To: Giovanni Biscuolo <g@xelera.eu>
Cc: 63274@debbugs.gnu.org, Ivan Vilata i Balaguer <ivan@selidor.net>
Subject: bug#63274: dia: Fails to build (Meson: Function does not take positional arguments)
Date: Sat, 20 May 2023 11:58:43 +0200 [thread overview]
Message-ID: <ZGiZ07DLJ66CV05u@sax> (raw)
In-Reply-To: <871qjba05d.fsf@xelera.eu>
[-- Attachment #1: Type: text/plain, Size: 1836 bytes --]
Giovanni Biscuolo (2023-05-20 10:15:58 +0200) wrote:
> Hello Ivan,
>
> Ivan Vilata i Balaguer <ivan@selidor.net> writes:
>
> > The latest commit in Dia's Git repo (just 3 after the one use by Guix) states
> > "build: Fix deprecated positional argument for i18n.merge_file":
> > <https://gitlab.gnome.org/GNOME/dia/-/commit/6ef461d8a04ffcd23df26fc4749cebc6322a5322>
> >
> > Building `--with-commit=dia=6ef461d8a04ffcd23df26fc4749cebc6322a5322` is successful.
> >
> > I'll send a patch to fix this.
>
> I sent a patch on May 5th as #63274 [1] using commit
> b903dd83aa5aab1b41c7864dd5027d1b6a0a190c, please send a V2 patch if you
> think is better
>
> Thanks! Gio'
>
> [1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63274
Thanks Giovanni! Sorry that I didn't know about your patch, it looks like
Guix debbugs doesn't send copies of messages in the bug thread to involved
addresses (not even to the original poster 🙁)… I kinda assumed it behaved
like Debian's. I'll remember to check the issue page and use "reply to all"
next time, just in case.
Yesterday I sent patch <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63592>
(v2), not knowing about yours. I just checked your patch and it points to a
more recent commit than my patch, so I guess it fixes even more stuff, and I
see that Guix' version has anyway been quite ahead 1.9.5 for a while. So I
guess that your patch makes more sense. However, I see that you forgot to add
your copyright entry at the beginning of the file, and you may want to specify
that the patch fixes this issue too (you may want to adapt the commit message
from my v2 patch).
I sent a new version of your patch which just fixes that. I'll ask to close
my other patch issue.
Thanks again!
--
Ivan Vilata i Balaguer -- https://elvil.net/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-05-20 9:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 15:26 bug#63274: dia: Fails to build (Meson: Function does not take positional arguments) Ivan Vilata i Balaguer
2023-05-05 13:39 ` bug#63274: [PATCH] gnu: dia: Update to 0.97.3-4.b903dd8 Giovanni Biscuolo
2023-05-15 14:52 ` Giovanni Biscuolo
2023-05-21 20:40 ` bug#63592: " Liliana Marie Prikler
2023-05-22 14:25 ` [bug#63592] " Maxim Cournoyer
2023-05-20 9:57 ` bug#63274: [PATCH v2] gnu: dia: Update to 0.97.3-4.b903dd8 to fix Meson build Ivan Vilata i Balaguer
2023-05-19 16:06 ` bug#63274: dia: Fails to build (Meson: Function does not take positional arguments) Ivan Vilata i Balaguer
2023-05-20 8:15 ` Giovanni Biscuolo
2023-05-20 9:58 ` Ivan Vilata i Balaguer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGiZ07DLJ66CV05u@sax \
--to=ivan@selidor.net \
--cc=63274@debbugs.gnu.org \
--cc=g@xelera.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.