[gnome-team] gtk+ on core-updates

[gnome-team] gtk+ on core-updates

[Andreas Enge]

Hello Maxim,

your gtk+ update on core-updates broke gnome packages since it somehow
moved the bin/ subdirectory from the bin to the out output, so that
gtk-update-icon-cache is not found any more by packages using gtk+:bin
as input.

Should the split not happen automagically? Maybe this is a deficiency of
the meson build system? I think you or a gnome team member will be much
quicker than me to fix it.

Andreas

Re: [gnome-team] gtk+ on core-updates

[Maxim Cournoyer]

Hi Andreas,

Andreas Enge <andreas@enge.fr> writes:

> Hello Maxim,
>
> your gtk+ update on core-updates broke gnome packages since it somehow
> moved the bin/ subdirectory from the bin to the out output, so that
> gtk-update-icon-cache is not found any more by packages using gtk+:bin
> as input.
>
> Should the split not happen automagically? Maybe this is a deficiency of
> the meson build system? I think you or a gnome team member will be much
> quicker than me to fix it.

I assumed it would happen automagically, like it does for
gnu-build-system, but it doesn't.

I've rectified this locally for our meson-build-system, I'm building a
bunch of packages with the change and if it works, I'll push (probably
in a few hours).

-- 
Thanks,
Maxim

Re: [gnome-team] gtk+ on core-updates

[Maxim Cournoyer]

Hi Andreas,

Andreas Enge <andreas@enge.fr> writes:

> Hello Maxim,
>
> your gtk+ update on core-updates broke gnome packages since it somehow
> moved the bin/ subdirectory from the bin to the out output, so that
> gtk-update-icon-cache is not found any more by packages using gtk+:bin
> as input.
>
> Should the split not happen automagically? Maybe this is a deficiency of
> the meson build system? I think you or a gnome team member will be much
> quicker than me to fix it.

OK, that's been fixed in meson-build-system; I've taken that opportunity
to update our meson package to its latest 1.0.1 release too.

-- 
Thanks,
Maxim

Re: [gnome-team] gtk+ on core-updates

[Andreas Enge]

Am Sun, Apr 09, 2023 at 12:57:34PM -0400 schrieb Maxim Cournoyer:
> OK, that's been fixed in meson-build-system; I've taken that opportunity
> to update our meson package to its latest 1.0.1 release too.

Great, thanks a lot! The KDE package and the Gnome package I have in my
profile now build, and I hope the best for all of Gnome (which is not yet
available on the build farm).

However, there is a problem with meson-python, which for some reason is
needed for my system profile:

tests/test_wheel.py::test_configure_data FAILED                          [ 94%]
=================================== FAILURES ===================================
_____________________________ test_configure_data ______________________________

wheel_configure_data = PosixPath('/tmp/guix-build-meson-python-0.8.1.drv-0/pytest-of-nixbld/pytest-0/test0/mesonpy-test-5dncnze6/configure_data-1.0.0-py3-none-any.whl')

    def test_configure_data(wheel_configure_data):
        artifact = wheel.wheelfile.WheelFile(wheel_configure_data)

>       assert wheel_contents(artifact) == {
            'configure_data-1.0.0.data/platlib/configure_data.py',
            'configure_data-1.0.0.dist-info/METADATA',
            'configure_data-1.0.0.dist-info/RECORD',
            'configure_data-1.0.0.dist-info/WHEEL',
        }
E       AssertionError: assert {'configure_data-1.0.0.dist-info/METADATA',\n 'configure_data-1.0.0.dist-info/RECORD',\n 'configure_data-1.0.0.dist-info/WHEEL',\n 'configure_data.py'} == {'configure_data-1.0.0.data/platlib/configure_data.py',\n 'configure_data-1.0.0.dist-info/METADATA',\n 'configure_data-1.0.0.dist-info/RECORD',\n 'configure_data-1.0.0.dist-info/WHEEL'}
E         Extra items in the left set:
E         'configure_data.py'
E         Extra items in the right set:
E         'configure_data-1.0.0.data/platlib/configure_data.py'
E         Full diff:
E           {
E         -  'configure_data-1.0.0.data/platlib/configure_data.py',
E            'configure_data-1.0.0.dist-info/METADATA',
E            'configure_data-1.0.0.dist-info/RECORD',
E            'configure_data-1.0.0.dist-info/WHEEL',
E         +  'configure_data.py',
E           }

tests/test_wheel.py:103: AssertionError
---------------------------- Captured stdout setup -----------------------------

Not very telling for someone who does not know meson!

Andreas

Re: [gnome-team] gtk+ on core-updates

[Maxim Cournoyer]

Hi Andreas,

Andreas Enge <andreas@enge.fr> writes:

> Am Sun, Apr 09, 2023 at 12:57:34PM -0400 schrieb Maxim Cournoyer:
>> OK, that's been fixed in meson-build-system; I've taken that opportunity
>> to update our meson package to its latest 1.0.1 release too.
>
> Great, thanks a lot! The KDE package and the Gnome package I have in my
> profile now build, and I hope the best for all of Gnome (which is not yet
> available on the build farm).
>
> However, there is a problem with meson-python, which for some reason is
> needed for my system profile:
>
> tests/test_wheel.py::test_configure_data FAILED                          [ 94%]
> =================================== FAILURES ===================================
> _____________________________ test_configure_data ______________________________
>
> wheel_configure_data = PosixPath('/tmp/guix-build-meson-python-0.8.1.drv-0/pytest-of-nixbld/pytest-0/test0/mesonpy-test-5dncnze6/configure_data-1.0.0-py3-none-any.whl')
>
>     def test_configure_data(wheel_configure_data):
>         artifact = wheel.wheelfile.WheelFile(wheel_configure_data)
>
>>       assert wheel_contents(artifact) == {
>             'configure_data-1.0.0.data/platlib/configure_data.py',
>             'configure_data-1.0.0.dist-info/METADATA',
>             'configure_data-1.0.0.dist-info/RECORD',
>             'configure_data-1.0.0.dist-info/WHEEL',
>         }
> E       AssertionError: assert {'configure_data-1.0.0.dist-info/METADATA',\n 'configure_data-1.0.0.dist-info/RECORD',\n 'configure_data-1.0.0.dist-info/WHEEL',\n 'configure_data.py'} == {'configure_data-1.0.0.data/platlib/configure_data.py',\n 'configure_data-1.0.0.dist-info/METADATA',\n 'configure_data-1.0.0.dist-info/RECORD',\n 'configure_data-1.0.0.dist-info/WHEEL'}
> E         Extra items in the left set:
> E         'configure_data.py'
> E         Extra items in the right set:
> E         'configure_data-1.0.0.data/platlib/configure_data.py'
> E         Full diff:
> E           {
> E         -  'configure_data-1.0.0.data/platlib/configure_data.py',
> E            'configure_data-1.0.0.dist-info/METADATA',
> E            'configure_data-1.0.0.dist-info/RECORD',
> E            'configure_data-1.0.0.dist-info/WHEEL',
> E         +  'configure_data.py',
> E           }
>
> tests/test_wheel.py:103: AssertionError
> ---------------------------- Captured stdout setup -----------------------------
>
> Not very telling for someone who does not know meson!

I don't know meson that much either, but I've updated the package to its
latest 0.12.1 version, and it passes it's test suite, so we should be
good!

-- 
Thanks,
Maxim

Re: [gnome-team] gtk+ on core-updates

[Andreas Enge]

Hello!

Am Mon, Apr 10, 2023 at 11:14:52PM -0400 schrieb Maxim Cournoyer:
> I don't know meson that much either, but I've updated the package to its
> latest 0.12.1 version, and it passes it's test suite, so we should be
> good!

Good idea, it is also what I tend to try out first...

Repercussions trickle towards the leaves now. Maybe the Gnome team could
follow suit and fix the build errors for "guix build gnome"?

Currently I see this in python-scipy (!):
+ meson setup --prefix=/gnu/store/i0d555a5fd7isi606aqqmbp5zgy9jh6p-python-3.10.7 /tmp/guix-build-python-scipy-1.9.1.drv-0/scipy-1.9.1 /tmp/guix-build-python-scipy-1.9.1.drv-0/scipy-1.9.1/.mesonpy-sbs19t2c/build --native-file=/tmp/guix-build-python-scipy-1.9.1.drv-0/scipy-1.9.1/.mesonpy-native-file.ini -Ddebug=false -Doptimization=2

ERROR Missing dependencies:
	patchelf >= 0.11.0
	meson-python>=0.8.1
error: in phase 'build': uncaught exception:
%exception #<&invoke-error program: "python" arguments: ("-m" "build" "--wheel" "--no-isolation" ".") exit-status: 1 term-signal: #f stop-signal: #f>
phase `build' failed after 5.8 seconds
command "python" "-m" "build" "--wheel" "--no-isolation" "." failed with status 1
builder for `/gnu/store/fj9pkl2hkbdczrdgjxcs95r26a3xpn68-python-scipy-1.9.1.drv' failed with exit code 1
build of /gnu/store/fj9pkl2hkbdczrdgjxcs95r26a3xpn68-python-scipy-1.9.1.drv failed
View build log at '/var/log/guix/drvs/fj/9pkl2hkbdczrdgjxcs95r26a3xpn68-python-scipy-1.9.1.drv.gz'.
cannot build derivation `/gnu/store/lichx5rphrlaf6frg3pmrr8qdz04w2k6-font-abattis-cantarell-0.303.drv': 1 dependencies couldn't be built
building /gnu/store/skvja3qaqflckk69n0yqs8jjfcrnmpxm-qemu-minimal-7.2.0.drv...
cannot build derivation `/gnu/store/w8dsh12i22hndkm4gk7zv6dbnya6draq-gnome-42.4.drv': 1 dependencies couldn't be built

Maybe an update would be enough here, there is a newer version.

I am also still questioning whether we should include gnome-boxes into the
gnome meta package; it is a bit surprising to have a desktop environment
depend on qemu.

Andreas

Re: [gnome-team] gtk+ on core-updates

[Maxim Cournoyer]

Hi Andreas,

Andreas Enge <andreas@enge.fr> writes:

> Hello!
>
> Am Mon, Apr 10, 2023 at 11:14:52PM -0400 schrieb Maxim Cournoyer:
>> I don't know meson that much either, but I've updated the package to its
>> latest 0.12.1 version, and it passes it's test suite, so we should be
>> good!
>
> Good idea, it is also what I tend to try out first...
>
> Repercussions trickle towards the leaves now. Maybe the Gnome team could
> follow suit and fix the build errors for "guix build gnome"?
>
> Currently I see this in python-scipy (!):
> + meson setup
> --prefix=/gnu/store/i0d555a5fd7isi606aqqmbp5zgy9jh6p-python-3.10.7
> /tmp/guix-build-python-scipy-1.9.1.drv-0/scipy-1.9.1
> /tmp/guix-build-python-scipy-1.9.1.drv-0/scipy-1.9.1/.mesonpy-sbs19t2c/build
> --native-file=/tmp/guix-build-python-scipy-1.9.1.drv-0/scipy-1.9.1/.mesonpy-native-file.ini
> -Ddebug=false -Doptimization=2
>
> ERROR Missing dependencies:
> 	patchelf >= 0.11.0
> 	meson-python>=0.8.1
> error: in phase 'build': uncaught exception:
> %exception #<&invoke-error program: "python" arguments: ("-m" "build"
> "--wheel" "--no-isolation" ".") exit-status: 1 term-signal: #f
> stop-signal: #f>
> phase `build' failed after 5.8 seconds
> command "python" "-m" "build" "--wheel" "--no-isolation" "." failed with status 1
> builder for `/gnu/store/fj9pkl2hkbdczrdgjxcs95r26a3xpn68-python-scipy-1.9.1.drv' failed with exit code 1
> build of /gnu/store/fj9pkl2hkbdczrdgjxcs95r26a3xpn68-python-scipy-1.9.1.drv failed
> View build log at '/var/log/guix/drvs/fj/9pkl2hkbdczrdgjxcs95r26a3xpn68-python-scipy-1.9.1.drv.gz'.
> cannot build derivation
> `/gnu/store/lichx5rphrlaf6frg3pmrr8qdz04w2k6-font-abattis-cantarell-0.303.drv':
> 1 dependencies couldn't be built
> building /gnu/store/skvja3qaqflckk69n0yqs8jjfcrnmpxm-qemu-minimal-7.2.0.drv...
> cannot build derivation
> `/gnu/store/w8dsh12i22hndkm4gk7zv6dbnya6draq-gnome-42.4.drv': 1
> dependencies couldn't be built
>
> Maybe an update would be enough here, there is a newer version.

That'd be what I'd try; meson-python no longer ships its patchelf shim
(it knows to use a system-provided one), which our current python-scipy
seems to still expect.  I can try this if you don't beat me to it.

> I am also still questioning whether we should include gnome-boxes into the
> gnome meta package; it is a bit surprising to have a desktop environment
> depend on qemu.

GNOME Boxes is really part of the default GNOME suite though, I think.
I think it's good to stick to what upstream GNOME thinks should be part
of GNOME (for consistency), even if that may sometimes feel a bit odd.

-- 
Thanks,
Maxim

Re: [gnome-team] gtk+ on core-updates

[Andreas Enge]

Hello!

Am Tue, Apr 11, 2023 at 02:36:13PM -0400 schrieb Maxim Cournoyer:
> > I am also still questioning whether we should include gnome-boxes into the
> > gnome meta package; it is a bit surprising to have a desktop environment
> > depend on qemu.
> GNOME Boxes is really part of the default GNOME suite though, I think.
> I think it's good to stick to what upstream GNOME thinks should be part
> of GNOME (for consistency), even if that may sometimes feel a bit odd.

Indeed, this kind of decisions should be taken at the discretion of the
Gnome team, and following upstream is a reasonable choice.

> I can now build 'gnome', /gnu/store/4gb42b6wfs316z0p1v9m42v1xapw40gx-gnome-42.4.

Excellent! And all substitutes are available from the build farms
for x86_64. Thanks!

Andreas

Re: [gnome-team] gtk+ on core-updates

[Maxim Cournoyer]

Hi,

Andreas Enge <andreas@enge.fr> writes:

> Hello!
>
> Am Mon, Apr 10, 2023 at 11:14:52PM -0400 schrieb Maxim Cournoyer:
>> I don't know meson that much either, but I've updated the package to its
>> latest 0.12.1 version, and it passes it's test suite, so we should be
>> good!
>
> Good idea, it is also what I tend to try out first...
>
> Repercussions trickle towards the leaves now. Maybe the Gnome team could
> follow suit and fix the build errors for "guix build gnome"?

I encountered a problem building qemu-minimal (I had erroneously dropped
meson as a native-input) and python-scipy, fixed by updating it in
a3bfb86738.

I can now build 'gnome', /gnu/store/4gb42b6wfs316z0p1v9m42v1xapw40gx-gnome-42.4.

-- 
Thanks,
Maxim