all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Andreas Enge <andreas@enge.fr>
To: Christopher Baines <mail@cbaines.net>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: How to manage package replacements?
Date: Thu, 30 Mar 2023 12:03:57 +0200	[thread overview]
Message-ID: <ZCVejRIytrLQlsv9@jurong> (raw)
In-Reply-To: <877cv1nl1k.fsf@cbaines.net>

Hello,

Am Tue, Mar 28, 2023 at 12:51:30PM +0100 schrieb Christopher Baines:
> Does anyone know what needs to be done in any/every case when replacing
> a package?

I have no idea, and if the lack of reply means that nobody else does, this
is somewhat worrying ;-)

For python-pillow, I get this:
guix build: warning: ambiguous package specification `python-pillow'
guix build: warning: choosing python-pillow@9.2.0 from gnu/packages/python-xyz.scm:7705:2
Maybe it would already be helpful to also print the other location(s)
for the ambiguous package in the warning message?

The rationale is explained here:
   https://guix.gnu.org/de/manual/devel/en/guix.html#Security-Updates
Replacements work on the level of Scheme variables: Any package having
python-pillow as input will be served with python-pillow/security-fixes
instead, since we have this:
(define-public python-pillow
  (package
    (name "python-pillow")
    (version "9.2.0")
    (replacement python-pillow/security-fixes)
...
(define-public python-pillow/security-fixes
  (package-with-patches python-pillow
                        (search-patches "python-pillow-CVE-2022-45199.patch")))

Here the two packages have the same name field, which confuses the command
line interface. Hiding the first one looks like a solution, or giving them
different names "python-pillow-insecure" for the first one and
"python-pillow" for the second one, for instance, the important point being
that the second one gets the usual name. Hm, the reference to the manual
above mentions that the names must have the same length. So maybe use
"python-pilXXX" for the first one? But then it gets recompiled, which is
exactly what grafting tries to avoid. So hiding seems to be the only option.

Caeterum censeo the solution to everythig is ungrafting :-)

Andreas



  reply	other threads:[~2023-03-30 10:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-28 11:51 How to manage package replacements? Christopher Baines
2023-03-30 10:03 ` Andreas Enge [this message]
2023-04-04 10:19 ` Simon Tournier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZCVejRIytrLQlsv9@jurong \
    --to=andreas@enge.fr \
    --cc=guix-devel@gnu.org \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.