all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Andreas Enge <andreas@enge.fr>
To: guix-devel@gnu.org
Subject: Re: OpenJDK in core-updates
Date: Wed, 5 Apr 2023 14:26:07 +0200	[thread overview]
Message-ID: <ZC1o38Usdu8AflbP@jurong> (raw)
In-Reply-To: <ZC1OunzVIbjzk/Um@jurong>

Next problem, hopefully fixed by the following patch:

diff -u -r openjdk-9.alt/hotspot/test/runtime/StackGuardPages/exeinvoke.c openjdk-9/hotspot/test/runtime/StackGuardPages/exeinvoke.c
--- openjdk-9.alt/hotspot/test/runtime/StackGuardPages/exeinvoke.c	2023-04-05 13:46:58.689964892 +0200
+++ openjdk-9/hotspot/test/runtime/StackGuardPages/exeinvoke.c	2023-04-05 14:15:52.435613325 +0200
@@ -67,8 +67,17 @@
   longjmp(context, 1);
 }

+static char* altstack = NULL;
+
 void set_signal_handler() {
-  static char altstack[SIGSTKSZ];
+  if (altstack == NULL) {
+    // Dynamically allocated in case SIGSTKSZ is not constant
+    altstack = (char*)malloc(SIGSTKSZ);
+    if (altstack == NULL) {
+      fprintf(stderr, "Test ERROR. Unable to malloc altstack space\n");
+      exit(7);
+    }
+  }

   stack_t ss = {
     .ss_size = SIGSTKSZ,

This is related to a change in glibc, and we have seen it in other places.
It is not new, so I do not quite understand how openjdk@9 compiled a few
weeks ago on core-updates and suddenly stopped to compile. At least openjdk@10
is also affected, and maybe later versions.

Andreas



  reply	other threads:[~2023-04-05 12:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-05 10:19 OpenJDK in core-updates Andreas Enge
2023-04-05 10:34 ` Andreas Enge
2023-04-05 12:26   ` Andreas Enge [this message]
2023-04-06 15:28     ` Andreas Enge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZC1o38Usdu8AflbP@jurong \
    --to=andreas@enge.fr \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.