From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id FSRcFbBRCGRl2AAASxT56A (envelope-from ) for ; Wed, 08 Mar 2023 10:13:20 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id COsqFLBRCGTv3QAA9RJhRA (envelope-from ) for ; Wed, 08 Mar 2023 10:13:20 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1CF3E29531 for ; Wed, 8 Mar 2023 10:13:20 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=LmHgWLwZ; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1678266800; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=yPphrj7XSDXM3xcCD5uzvfa2BDEDVNOhqzm5ICu/ENM=; b=PLkcs08wLAzE7juOBFTrigm1V1HIOeMV/AYyOSBNxCAQuIzfedEwMheg+aHSVadgbIO27T E0hSt/fhTFkjxTFKK3ploTXvNG28Ux7whHOlYBwYzAhZU2Ucfx+JqZ/b/0t0UkjGNKfGsZ IX18t3ypBTiL8rBam8WPWVmwOGb9bH5dEcmaKE9HvdNt8Q8ufINnfaExlfRRiT87RPC/tV avw7rd6R0A4AoKC2j7rkxDZLvtQ2jam5Yo0MxHb1ECel2kqXKL33nQbN5rJKIZB+YEWxiy pDWxce1ouYOxUOHQIWbitI05avfXxLsfzragByRJ3nL9JNmqRh89t0Etvc2/8Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1678266800; a=rsa-sha256; cv=none; b=ZNk2tuYqS+HzfL203S7NX3BFpg+eKswLl+vgeVVo0Ao9BuSrVOBVtcRjbGrIVbnj7JebbH jms20TZwgvnxoqbdendxErLgWZ7ftJWyMIzF+Frcn1u18RAE722zxqICfaiUDOivpCaXBx 385eBhlx+39gNTBSufLlRtwxkDj3AV2gDM0gklgrN4nJDKTNtqJkEoygkjOLvUksYVSShw GwZRyqXcktfSmORxeViW/RIRhQx91vyHWIFu+hZnKu/l72+yQ3ncihWLuRyj82BkA6zVgN Mt9w18BQqDaBYjMRlodOttmXrhlTwIKdCiYZ7ORzwxZVl587i2/RRIJ4JKQOWA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=LmHgWLwZ; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZpqu-0001rR-DP; Wed, 08 Mar 2023 04:12:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZpqs-0001rJ-L1 for guix-devel@gnu.org; Wed, 08 Mar 2023 04:12:50 -0500 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZpqj-00026T-7V; Wed, 08 Mar 2023 04:12:50 -0500 Received: by mail-wm1-x336.google.com with SMTP id t25-20020a1c7719000000b003eb052cc5ccso744593wmi.4; Wed, 08 Mar 2023 01:12:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678266758; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date:message-id:reply-to; bh=yPphrj7XSDXM3xcCD5uzvfa2BDEDVNOhqzm5ICu/ENM=; b=LmHgWLwZMiubbTjKhRoXN68nEdssxBTvaGv2hFbE1QWH0XnOoq+Ym5HM3lH4nTrYkj cPCE9EjF1+0jOwuwvBXGtAMQUBnPik0cLRwupUt5qD9ENTOhc3TSl7gsgvACZNqlV9Qb vRpYuaJcFbgOjCtChRkLdCaJpETclWTL1sjomnCsGfMKvTlLryHyuJK/PVXaGVoV1n/J 028S9FTGdRdpSCEEZWoj2sEeb2GbIq/56kWlDttw5qLm4gSj8SKgsFRejC4WwXmqShkO rxzSP7hgKXW57YixiXB/hK+pZ570WtKFcqdnXNFVSH883kD/WcuComFEabkXfF964FQC PtMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678266758; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yPphrj7XSDXM3xcCD5uzvfa2BDEDVNOhqzm5ICu/ENM=; b=izfu5FFEs8NG5/V+agkMpjS/kGeYvFJTkW8lItGYDg13Xfdovghfr/4tebGj3GBpzQ Gujxa4E8ic3jq2fJ7FJx0PMW2QcYO5UeppNqwHrdS7Ghn2b4hN3tnjxH21XIPl8wHJWw lVcJw3FdQD9sntJnHB/+2D275jDfskGgjKdLkShLdx8CJ+coe6qyG3gDqljgVPA6OvGm OsudymSlXZMUQO9HbYOaRH/Hsx3yenZTZYOmG4JaCu30itG/dOO30tVdqNgrIZn+4Wl/ zNOF8K2+X74bEhINc8mBbdv86lh50zDgWOTYjjvaiqOo6VK3q/lCetTUtUc/dkGWBpBJ YK+g== X-Gm-Message-State: AO0yUKWqMm+/blmVidiP7ORGyVGA25j1R+urLe8Xx4rQ3fd2Xa0itT6e SGsagcrmfw3ftvErDmkK3L0= X-Google-Smtp-Source: AK7set9QPq6JTYO+2Qg8BvjXfzbnm4dFn1VI6YbVll+ZZaGCHoiAI/MtIarUmZgg8qyrrd7ZtxrwNA== X-Received: by 2002:a05:600c:1990:b0:3e2:20c7:6553 with SMTP id t16-20020a05600c199000b003e220c76553mr15866454wmq.13.1678266758325; Wed, 08 Mar 2023 01:12:38 -0800 (PST) Received: from localhost ([2a02:ed3:910:9200:b62e:99ff:fef0:7bc0]) by smtp.gmail.com with ESMTPSA id f18-20020a05600c43d200b003dec22de1b1sm14877656wmn.10.2023.03.08.01.12.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Mar 2023 01:12:37 -0800 (PST) Date: Wed, 8 Mar 2023 11:12:35 +0200 From: Efraim Flashner To: Maxim Cournoyer Cc: Simon Tournier , Andreas Enge , =?utf-8?B?5a6L5paH5q2m?= , Ludovic =?utf-8?Q?Court=C3=A8s?= , Christopher Baines , guix-devel@gnu.org, 61894@debbugs.gnu.org, guix-maintainers@gnu.org Subject: Re: bug#61894: [PATCH RFC] Team approval for patches Message-ID: Mail-Followup-To: Maxim Cournoyer , Simon Tournier , Andreas Enge , =?utf-8?B?5a6L5paH5q2m?= , Ludovic =?utf-8?Q?Court=C3=A8s?= , Christopher Baines , guix-devel@gnu.org, 61894@debbugs.gnu.org, guix-maintainers@gnu.org References: <878rgga1qv.fsf@inria.fr> <871qm8wf8e.fsf@cbaines.net> <87r0u86qgo.fsf_-_@gnu.org> <87y1o9mina.fsf_-_@envs.net> <861qm0da4y.fsf@gmail.com> <87sfegwh28.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2NcYJPI+XQbEUpl9" Content-Disposition: inline In-Reply-To: <87sfegwh28.fsf@gmail.com> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=efraim.flashner@gmail.com; helo=mail-wm1-x336.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Scanner: scn0.migadu.com X-Migadu-Queue-Id: 1CF3E29531 X-Spam-Score: 0.10 X-Migadu-Spam-Score: 0.10 List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-TUID: GjD0Kwmo99XX --2NcYJPI+XQbEUpl9 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 07, 2023 at 01:29:51PM -0500, Maxim Cournoyer wrote: > Hi Simon, >=20 > Simon Tournier writes: >=20 > > Hi, > > > > On Tue, 07 Mar 2023 at 11:36, Andreas Enge wrote: > > > >> 1) Every current and potential new package is covered by a team. > >> 2) Every team has at least 3 members, better yet 4 or 5. > >> 3 members would make it possible that even if one of them is on vac= ation > >> or otherwise busy a patch could be pushed without this additional o= ne > >> week if the other 2 agree. > > > > It would help if being committer implies appearing at least in one team, > > no? > > > > Currently in etc/teams.scm.in, I count 26 members and 20 are committers > > over the 48 ones. No blame. :-) >=20 > If most committers end up being team members, aren't we back to where we > currently stand? It seems the original motivation here is to add some > extra control/guards against undesirable commits landing in the core of > Guix. If a committer that previously landed such commits joined the > core team (e.g., myself), it seems to me the situation would be little > changed: My understanding was that it would help people feel more ownership over a portion of the code, allowing others to tag them explicitly for code review touching their area of expertise and allowing them to perhaps "pay less attention" to areas where they are less sure. The second part works better when all areas are covered by a team, but in practice I feel it was already happening, judging by our large backlog of patches. > 1. Our pool of reviewers would likely continue to be spread too thin. >=20 > 2. The 2 weeks time window would quickly slip, even with a team looking > at a more focused backlog, or the reviews would only be of the kind "I > think that's not what we want" without more time or energy to offer the > kind of concrete insights that can be turned into action for the > submitter. >=20 > 3. The team member might be tempted to take their chance and merge their > change with little to no feedback, or feedback they perceived > insufficient or not actionable enough to justify keeping their > submission in limbo for longer. >=20 > I think the main problem we have is social, not organizational. There's > little incentive to jump into the laborious review process compared to > hack on something we like in our free time. We need to promote and > value review work more, without making it feel like a compulsory chore. > That's a great challenge to solve for a project that's driven by > volunteers. >=20 > I'll venture a suggestion to explore: adding enticements to review (some > playful guidelines such as "while waiting for your 2 weeks review > period, please try to review twice as many other submissions that have > been patiently waiting on the patches tracker :-)", or some stats > crunched and advertised periodically to guix-devel or even our to our > blog about our top reviewers, etc.). >=20 > --=20 > Maxim --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --2NcYJPI+XQbEUpl9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmQIUYAACgkQQarn3Mo9 g1GabA/+LdbM9RAD112kpI5IqGPfoB4dLnKOuxtupvmsyOX/UfxuJsW61d37Pyaf GQmwSakLaaoz0o3q+TyyEyTcp4lex/soWMEDdktTJG9GkOAERksTDw8EVPKoz5PQ 37Tm02IinKDBTRB6nXiFHIMReaj/5HXApLFL2n91nNc1+vuI/UYjKvy5MlFtHDmw aUd99qWzegg+YEUmX0UF+1wLFyFY9veou8ADki758v/J4lDpZvFp41bkCmX4R4iX hXhw5FvJ6aKHaDdutrErTtrRxKb8O3HHlNAszYg/zzh3ySsOc8g6eyA+eks5N8up lCu5qHT8xaESKN+YYR26O8wySv4yjVsOL3Pq2cL1UdNDkK1Wvih58XArGjqyDaah GZDhlnfG4RVgLMwWl2sDRqpnp+/VQjK3JyeVFkbTfN5bfxl1uJwwEXwG/+UHIQ9K 9r5pcEoq3xQcASiBxDdpmTqfQ5wKk7ZJ1VxW5qHtPIHbmpLIqj4zbbVLyixdVpBk 1CgAutNAw37N2rZCOoBilrMrPdK4lWGlcZlei1dCYzrMRsT1iQblUO0GSEmttD/A sL2LElfCh3QBa3NaL/JAQrgoAwrLIRpKi3NIGwV8z3VCsm36nSsJJDx9yOQLyDhV 4hJBQW5oKDF/uv2ehOyzXk6/v3SiWG/TQMSTuDiV3g8PB3CySrI= =AQPg -----END PGP SIGNATURE----- --2NcYJPI+XQbEUpl9--