all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#74147] [PATCH] gnu: tree-sitter: Update to 0.24.3.
@ 2024-10-31 22:02 Doğan Çeçen
  2024-10-31 22:02 ` [bug#74148] [PATCH 1/1] " Doğan Çeçen
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Doğan Çeçen @ 2024-10-31 22:02 UTC (permalink / raw)
  To: 74147
  Cc: Doğan Çeçen, Andrew Tropin, Katherine Cox-Buday,
	Liliana Marie Prikler

This is needed to update neovim to a newer version.

Doğan Çeçen (1):
  gnu: tree-sitter: Update to 0.24.3.

 gnu/packages/tree-sitter.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)


base-commit: 6e50b0c56a8cc767bd3acb26638f78c450bde718
prerequisite-patch-id: 92d7009719a2df665b401eb25ee08f8d276be4bb
prerequisite-patch-id: 20902e145fdee43b599da928d596390abaa69805
-- 
2.46.0





^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#74148] [PATCH 1/1] gnu: tree-sitter: Update to 0.24.3.
  2024-10-31 22:02 [bug#74147] [PATCH] gnu: tree-sitter: Update to 0.24.3 Doğan Çeçen
@ 2024-10-31 22:02 ` Doğan Çeçen
  2024-11-27 12:23   ` [bug#74148] Not ready Andreas Enge
  2024-11-01 22:35 ` [bug#74147] [PATCH] gnu: tree-sitter: Update to 0.24.3 Noé Lopez via Guix-patches via
  2024-11-27 12:10 ` bug#74147: Close Andreas Enge
  2 siblings, 1 reply; 5+ messages in thread
From: Doğan Çeçen @ 2024-10-31 22:02 UTC (permalink / raw)
  To: 74148
  Cc: Doğan Çeçen, Andrew Tropin, Katherine Cox-Buday,
	Liliana Marie Prikler

* gnu/packages/tree-sitter.scm (tree-sitter): Update to 0.24.3.

Change-Id: I0f9ae92283af6d4f9ff03d92b263a5d322bf4524
---
 gnu/packages/tree-sitter.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/tree-sitter.scm b/gnu/packages/tree-sitter.scm
index 2f6e6809d7..c5cb1911b8 100644
--- a/gnu/packages/tree-sitter.scm
+++ b/gnu/packages/tree-sitter.scm
@@ -99,16 +99,16 @@ (define-public python-tree-sitter
 (define-public tree-sitter
   (package
     (name "tree-sitter")
-    (version "0.20.10")                 ;untagged
+    (version "0.24.3")
     (source (origin
               (method git-fetch)
               (uri (git-reference
                     (url "https://github.com/tree-sitter/tree-sitter")
-                    (commit "0e4ff0bb27edf37b76fc7d35aa768b02cf4392ad")))
+                    (commit "v0.24.3")))
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "1bai4gdhf8w5p1i9np2kl2ms0jq6rgq98qpiipipzayb9jjjlxcy"))
+                "1pn1k2ch14y48718l7s21rz5alqgdw1bis25r9x4rm6zac7kiy6q"))
               (modules '((guix build utils)))
               (snippet #~(begin
                            ;; Remove bundled ICU parts
-- 
2.46.0





^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#74147] [PATCH] gnu: tree-sitter: Update to 0.24.3.
  2024-10-31 22:02 [bug#74147] [PATCH] gnu: tree-sitter: Update to 0.24.3 Doğan Çeçen
  2024-10-31 22:02 ` [bug#74148] [PATCH 1/1] " Doğan Çeçen
@ 2024-11-01 22:35 ` Noé Lopez via Guix-patches via
  2024-11-27 12:10 ` bug#74147: Close Andreas Enge
  2 siblings, 0 replies; 5+ messages in thread
From: Noé Lopez via Guix-patches via @ 2024-11-01 22:35 UTC (permalink / raw)
  To: 74147

Hi Doğan,

Thank you for your patch, here are a few suggestions:

>               (uri (git-reference
>                     (url "https://github.com/tree-sitter/tree-sitter")
>-                    (commit "0e4ff0bb27edf37b76fc7d35aa768b02cf4392ad")))
>+                    (commit "v0.24.3")))
>               (file-name (git-file-name name version))
>               (sha256

You can use “string-append” to avoid repeating the version:
(commit (string-append "v" commit))

As a result of updating tree-sitter, the ”tree-sitter-cli” package has
stopped building for me, it is recommended that you check that
dependencies of tree-sitter don’t fail to build as a result of the
update, see “info (guix) Submitting Patches” step 9.

Can you send an updated patch?

Thanks for your work,
Noé Lopez

Disclaimer: I am not a guix committer, just a random person trying to help.




^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#74147: Close
  2024-10-31 22:02 [bug#74147] [PATCH] gnu: tree-sitter: Update to 0.24.3 Doğan Çeçen
  2024-10-31 22:02 ` [bug#74148] [PATCH 1/1] " Doğan Çeçen
  2024-11-01 22:35 ` [bug#74147] [PATCH] gnu: tree-sitter: Update to 0.24.3 Noé Lopez via Guix-patches via
@ 2024-11-27 12:10 ` Andreas Enge
  2 siblings, 0 replies; 5+ messages in thread
From: Andreas Enge @ 2024-11-27 12:10 UTC (permalink / raw)
  To: 74147-done

Closing this bug, since 71748 contains the v2.

Thanks, Noé, for the review!

Andreas





^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#74148] Not ready
  2024-10-31 22:02 ` [bug#74148] [PATCH 1/1] " Doğan Çeçen
@ 2024-11-27 12:23   ` Andreas Enge
  0 siblings, 0 replies; 5+ messages in thread
From: Andreas Enge @ 2024-11-27 12:23 UTC (permalink / raw)
  To: 74148

As noticed by Noé for the first version of the commit in issue 74147,
the update prevents the dependent package tree-sitter-cli from building.
So it cannot be applied as is.

Here is the error message for reference:
starting phase `patch-node'
error: in phase 'patch-node': uncaught exception:
system-error "mkstemp" "~A" ("No such file or directory") (2)
phase `patch-node' failed after 0.0 seconds

Andreas





^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-11-27 12:24 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-31 22:02 [bug#74147] [PATCH] gnu: tree-sitter: Update to 0.24.3 Doğan Çeçen
2024-10-31 22:02 ` [bug#74148] [PATCH 1/1] " Doğan Çeçen
2024-11-27 12:23   ` [bug#74148] Not ready Andreas Enge
2024-11-01 22:35 ` [bug#74147] [PATCH] gnu: tree-sitter: Update to 0.24.3 Noé Lopez via Guix-patches via
2024-11-27 12:10 ` bug#74147: Close Andreas Enge

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.