From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id UK8lK+EgQmdmeQEA62LTzQ:P1 (envelope-from ) for ; Sat, 23 Nov 2024 18:37:21 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id UK8lK+EgQmdmeQEA62LTzQ (envelope-from ) for ; Sat, 23 Nov 2024 19:37:21 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="Qdr/hz5K"; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=JL1Rg7ak; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1732387041; a=rsa-sha256; cv=none; b=LUECTeXp8t9MFr3Wuax4MKujaB41bdyUEaa1sbvuNMyQyFz4s9EZPmGihEtjCa6O6uO4LV g/W64p8J2iK2bjHMScM2SFKj7UE12bSRBC7gTiG9IE2ycFizCK8U5G8ujOoRJvaN3Uaihl tSnEaqROg60XbrreiMru7E3Ov4/Q6a34MeGxnsAgICuQnQE+7P+cKRkd1JI/NTvj7CnNE1 8oLpwf+gTNjwZIAycshLApFq/g0R3LXP1YxUSwkoWBLQu4nxgGlmyW9CCrudpdmoGF/fq/ QV9CnAT/vQA1ngpOD3NLVcYefw2+hDtpUFrbcL7L8tt14PvFccGZbAlXsGbRvA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="Qdr/hz5K"; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=JL1Rg7ak; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1732387041; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Px4nHyXQOazETJwBvPcJhoJPHcovYqJp7QOnW/dTLSc=; b=Ux586uQmEkTDP/HQVkUJ4r2Tnl6G2AnTWONMLqPE214gdeCK9z+JhLDObQDt+BMOA8kxdh Q1uhih2e3wTCc3xUNnPPl1O0JK+BILa6ps64EcR4r8m/BvPyeL71WrlL1MZsWxcteqbSDb bP4ftakzGriX3dsEPtUkL09RyZ6+VliX/zgVq7DW/BiB4SLxzcsgDaW47yD2duz0HMev/l OPdSRSsNU6PYCPsjTPdpWycNEMenJ+u/9LE17HONcarcgd457IEGndYZlR6g1mkIGpb0py rjhNZJBrkZZnPpE/TgS7kZp296QEKE/B+ATQUsRdAdBqM08TiKRP6y/1dT7OUA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3976C1ED5D for ; Sat, 23 Nov 2024 19:37:21 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tEv0C-0002AO-0U; Sat, 23 Nov 2024 13:37:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEv0A-00028E-PM for guix-patches@gnu.org; Sat, 23 Nov 2024 13:37:03 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tEv0A-00079C-GV for guix-patches@gnu.org; Sat, 23 Nov 2024 13:37:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:MIME-Version:References:From:Date:To:Subject; bh=Px4nHyXQOazETJwBvPcJhoJPHcovYqJp7QOnW/dTLSc=; b=Qdr/hz5KosdQ3kr9sGEtOiovHhYYljgFATyaYnQZfN4mhCb4K7e2G8ZDnktu+NuTLo7mR5x1kgyv+WfUkXBg2I94siXwh8jg8bmfphLqvor8LVe2AXy/SNCnTYSpUnz4DO/qqHWiYLkdLqQFQQZtRK4LN6eKxOFPLiSvhFyQuBpKyFCajAzjh2kQheAALKJBpqpb5H3vbZgLFF1elDcx+yAp96N8TdySby5RzgLRKeWywAl5EIqG7ekq0tIeV79DTMk0AYERlvUgAp5b/fi11RCRZ3aEWN6qW1JUkQlZx+dUgePiM5t5sctx3tUpx0nPJ3+IV4f9wFYHmKbR1M/Qsw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tEv0A-0006bn-Al for guix-patches@gnu.org; Sat, 23 Nov 2024 13:37:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74253] [PATCH] transformations: Add multituned-package. Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 23 Nov 2024 18:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74253 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Christopher Baines , 74253@debbugs.gnu.org Received: via spool by 74253-submit@debbugs.gnu.org id=B74253.173238698725329 (code B ref 74253); Sat, 23 Nov 2024 18:37:02 +0000 Received: (at 74253) by debbugs.gnu.org; 23 Nov 2024 18:36:27 +0000 Received: from localhost ([127.0.0.1]:59118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEuzb-0006aR-5J for submit@debbugs.gnu.org; Sat, 23 Nov 2024 13:36:27 -0500 Received: from mail-wm1-f46.google.com ([209.85.128.46]:45489) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEuzY-0006aA-Sp for 74253@debbugs.gnu.org; Sat, 23 Nov 2024 13:36:25 -0500 Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4316f3d3c21so28141015e9.3 for <74253@debbugs.gnu.org>; Sat, 23 Nov 2024 10:36:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732386919; x=1732991719; darn=debbugs.gnu.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date:message-id:reply-to; bh=Px4nHyXQOazETJwBvPcJhoJPHcovYqJp7QOnW/dTLSc=; b=JL1Rg7akh5Q2DgCoymJIvJ40EANxlaU4TjTewm9dgtWi/IJkA+1tHiDrML6bSi+TT9 4qwh69c8UfgLhNopIYJpUtmayKecDHck6CV9V1VBCaxfyyD0mH11zk91HtjFLlE+hwsA MmX5w8MLgPBFsS0jUR1XVknEd/kJJMSZQUoPAu5FEgMAAk1OhQRkKotZvyX7m9KkBERn JeoFCl3y9HecZpJ+2k5z2rPX4NMBtMVQ0MaFriJ4xD5LEnf6o1jQOKni6zLNBJL1ei8r E7yyP4qe3x9UrI9ZZgigb/oRTgC62bz8VQ36hc5S1bQSAt6qV9dABm8+ayrICgDqYOFC tLSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732386919; x=1732991719; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Px4nHyXQOazETJwBvPcJhoJPHcovYqJp7QOnW/dTLSc=; b=TKxMaZSVf9DauA6FcLG+r0Z+UqaDTynbsjnDYrba3K3/4khEjQTDCUnjKV9J6qsgeV KcWPm3X8aIv4kGXrC6RpiLOZykNv1dR3FzPc7evs91eDD1hiSvU/bc/Gr+kaioLdEwBe pndZ0kHQzkggTffMRPNO29wQodfHFAttXRzyOxBZTcIxG9CYU6E7NFg57wkgPX9zPYID 9jjOoeXjV68k44ygrCmFNkeSpK5e3TUrOZnQQzLs123yQME5wWaHvUUeZngePaOWr2mi EEc8wpzAaOtyn3Uxi0I50dcvPlUebmLedNQH/7OKwc/ZOCuYyCCOCSv0ePVMs66VXhBL 4prA== X-Gm-Message-State: AOJu0YwivM57y6i43713fGCpR9I8Qr/5dvc+prs/vYw674iDZVszF2Og EG490DLjWAU2SbGR/T6lrxLl3ECO2qOhP4Yw4xMH554Xw6ylW9Us X-Gm-Gg: ASbGncuuzvh/7HVgEWqUE46OF5KqENHWbtuDLn7seUEdi0F2+C3dkGUdvVU1NPBkTkt EU5HJ0Ctj/5cR9Ld7jIQXIxHKmWVYaV1B6HEGXfDbeurz4hgDnh2XlB2JSqRcf1xhEUPovwWzIG jltsSJgJS/nme7OSIykA4mL8uiIdPLVVT7SuBxKh+I02rfJeTtBR25hzq3kqLB3fRDkFEpV6NCQ nFq/Gl9PU8ybftO0wJXZWgEpHF62kS6sSzaN0tvOanVgpKDkw== X-Google-Smtp-Source: AGHT+IHWydGgr3WnWB+RSdLritDmO2LETy7tDDD/I80oz02YNQzXbCGq1jEEMLnjq7iZP87GeNmtRg== X-Received: by 2002:a05:600c:358d:b0:431:59b2:f0d1 with SMTP id 5b1f17b1804b1-433ce41802amr65234135e9.4.1732386918732; Sat, 23 Nov 2024 10:35:18 -0800 (PST) Received: from localhost ([188.120.129.43]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-433b01e0584sm131264995e9.5.2024.11.23.10.35.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Nov 2024 10:35:17 -0800 (PST) Date: Sat, 23 Nov 2024 20:35:16 +0200 From: Efraim Flashner Message-ID: Mail-Followup-To: Efraim Flashner , Ludovic =?UTF-8?Q?Court=C3=A8s?= , 74253@debbugs.gnu.org, Christopher Baines , Josselin Poiret , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice References: <87serwu4iq.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MX4Kectl+38D19Hi" Content-Disposition: inline In-Reply-To: <87serwu4iq.fsf@gnu.org> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -2.24 X-Spam-Score: -2.24 X-Migadu-Queue-Id: 3976C1ED5D X-Migadu-Scanner: mx12.migadu.com X-TUID: 0JsN+kGUqIWy --MX4Kectl+38D19Hi Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 12, 2024 at 11:31:57AM +0100, Ludovic Court=C3=A8s wrote: > Hi, >=20 > Efraim Flashner skribis: >=20 > > * guix/transformations.scm (package-tuned-for-psabi, > > multituned-package): New variables. > > > > Change-Id: I09ac7ae9fc2bcd9aa712b3c30fef807bc7d55895 > > --- > > > > This allows wrapping a package definition in multituned-package, ie: > > > > (define-public opus > > (multituned-package > > (package > > ...))) > > > > I'm not sure where to go with this patch from here. This will provide > > the psabi libraries for x86_64 and powerpc64le so they get most of the > > benefits from tuning for the architecture but without needing to specify > > which architecture to tune for. It should also provide a nice boost for > > guix packs and docker images and the like. > > > > The downside with using this by default is the larger package size due > > to the extra versions of the libraries, and if it is used then the > > regular --tune is disabled for that package. > > > > I think adding it as a '--tune=3Dgeneric' or '--tune=3Dpsabi' would be a > > nice way to use it. >=20 > Should that be a package transformation though? Could we instead have a > build system trick or the =E2=80=98multituned-package=E2=80=99 procedure = exposed so > build the package several times and fill in lib/glibc-hwcaps? I figured (guix transformations) worked well since it was using an existing transformation to generate the different variants. I'm not sure what you mean by a build system trick, like build the package multiple times in one like with x265? This exposes the multituned-package procedure (looks like I mistyped in the commit message) which takes a package and can be just added on top of an existing package definition, like hidden-package can. > That way, packagers would explicitly choose this technique for select > packages, which would then no longer need the =E2=80=98tunable?=E2=80=99 = property. Something like a flag in the build-system like #:tests? is? Or like a package property? > The question becomes: how would we choose which packages is eligible to > this technique as opposed to =E2=80=98--tune=E2=80=99? Intuitively, I wo= uld use that > for general-purpose packages like =E2=80=98opus=E2=80=99, but keep =E2=80= =98--tune=E2=80=99 for more > niche/scientific packages. Unfortunately I think just like with choosing what to do with tunable? we end up in the same spot deciding somewhat arbitrarily what to provide the psabi options for and what not to. > WDYT? >=20 > Thanks, > Ludo=E2=80=99. Looking more at the patch I've remembered that I've only taken care of the gnu- and cmake- build-systems. I was going to add about tuning the package on other architectures, like aarch64, but it seems I fixed that already. If it were just the configure-flags and the post-installation removal of files then I could see trying to make something that could be inserted manually into specific packages, but the whole thing rests on the tuned-package procedure actually producing libraries tuned for the different psABIs. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --MX4Kectl+38D19Hi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmdCIF0ACgkQQarn3Mo9 g1EJlBAAsDrZYDFCOHNOdJbvN0AZg6aMrTGoAKKTJ2ElwT300Y76STETfw0EZvKm vriX82SWf8/FWmkvSlyI+xjKvVbWW3wYL9he7/TjSIt0Un2JJrox31t598ug/qsI KQ55TczsdJlv4P7yA5rmNliMHB6ac1KC9c6ZFi8cuLHrk7KLZjXOgpCDK0a+bGkv /ZZNKbCevC2pmQ34A8XxyLFuQtnMdkVPVOq0WS0hv9dsmu79v0xLcKPAQOBSY97w FZkSu9ZqQ/EYxR2v2gxzAeQCYhAoAj+UnskXq2dtjDGKlOawfKwuCB5hvKDMQTpL duKQcNM9qDL7u88M3WZ3MSvQAR+n7vrqq7kMb0etuzspJLbYY+rtTbuVFEtmBX3t /jClJFfkemTyAnCp56D4w6c4m6OFcvl9d4USxlimRsOk03nF7tQ2oXMY+6tmdHWX Eip1d/E+Gk043mZtXkLuP0PIVDZlkJjH+iuibq+Nuj0F4edORTH2i7a1MCTUzFpO 8+rHJs9ytexZ5kC8yz8DYrZlicgU9Of1a0RcRva9wHWW+R5EpwRhr3X0HG/EmqVi VZbtbsvL1SLnUZVEMuO3wgiJ+yzqg6nzjTuRSjiAU6MlZ10DK39tKiKNzJUOojdl 9rtdioVxWsgU8njqcMdeTCHryDY+1mg66OZnLiGYENitP/chp5o= =Qlmk -----END PGP SIGNATURE----- --MX4Kectl+38D19Hi--