From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <guix-devel-bounces+larch=yhetil.org@gnu.org>
Received: from mp12.migadu.com ([2001:41d0:2:4a6f::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms5.migadu.com with LMTPS
	id qCu/Ndfa6mLbfwEAbAwnHQ
	(envelope-from <guix-devel-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Wed, 03 Aug 2022 22:30:15 +0200
Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp12.migadu.com with LMTPS
	id uBOLNdfa6mLoRAEAauVa8A
	(envelope-from <guix-devel-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Wed, 03 Aug 2022 22:30:15 +0200
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id 9911384CE
	for <larch@yhetil.org>; Wed,  3 Aug 2022 22:30:15 +0200 (CEST)
Received: from localhost ([::1]:40944 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <guix-devel-bounces+larch=yhetil.org@gnu.org>)
	id 1oJL0Q-00030X-O7
	for larch@yhetil.org; Wed, 03 Aug 2022 16:30:14 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:36908)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <efraim@flashner.co.il>)
 id 1oJL03-00030G-1Z
 for guix-devel@gnu.org; Wed, 03 Aug 2022 16:29:51 -0400
Received: from flashner.co.il ([178.62.234.194]:43024)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <efraim@flashner.co.il>) id 1oJL01-0002X4-A7
 for guix-devel@gnu.org; Wed, 03 Aug 2022 16:29:50 -0400
Received: from localhost (ool-ad022d7f.dyn.optonline.net [173.2.45.127])
 by flashner.co.il (Postfix) with ESMTPSA id 58F0A4005E;
 Wed,  3 Aug 2022 20:29:47 +0000 (UTC)
Date: Wed, 3 Aug 2022 23:29:14 +0300
From: Efraim Flashner <efraim@flashner.co.il>
To: Olivier Dion <olivier.dion@polymtl.ca>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add perf-tools.
Message-ID: <YuramhDpMUhbvOvq@pbp>
Mail-Followup-To: Olivier Dion <olivier.dion@polymtl.ca>,
	guix-devel@gnu.org
References: <762adaa93e56bdb1e32e7aa114153bc525b3ced0.1659551643.git.olivier.dion@polymtl.ca>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature"; boundary="qj5emkyCKTeLaOQD"
Content-Disposition: inline
In-Reply-To: <762adaa93e56bdb1e32e7aa114153bc525b3ced0.1659551643.git.olivier.dion@polymtl.ca>
X-PGP-Key-ID: 0x41AAE7DCCA3D8351
X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc
X-PGP-Fingerprint: A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Received-SPF: pass client-ip=178.62.234.194;
 envelope-from=efraim@flashner.co.il; helo=flashner.co.il
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: guix-devel@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Development of GNU Guix and the GNU System distribution."
 <guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+larch=yhetil.org@gnu.org>
X-Migadu-Flow: FLOW_IN
X-Migadu-To: larch@yhetil.org
X-Migadu-Country: US
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org;
	s=key1; t=1659558615;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:in-reply-to:in-reply-to:
	 references:references:list-id:list-help:list-unsubscribe:
	 list-subscribe:list-post; bh=Tawj0AVMdVzLQFLD+GAXEFNSDYk8Lal/F4wGvqifRrc=;
	b=Fy8uJgC35i0FDN8XL7wjT7hBu1O8PUNHACh1xs7VyUsGfcoOkgOVtyvViKrlQxCXzFxTss
	zFd31dp9Twaj7JmRVdeJ155913UTvEm8YWh3jqcn9uu3HmOsqcysiZHR4kPXQky6ynW7e8
	iPA5cQXO7PARxv8mvPOp19lT3/dGt6URBHqComhAbhEThKD38XYVAR4EKmUdIJciMpKJ4X
	GlUXhgowydYYFQHEarS5IUN1W2y6D0jf8efxw0uT0erchfkKAO9x/VeG6qj1PVODyMQzhO
	NTlkfnridhiOR8CvGe4lathVaGAz+rDMvRo3ES3Yn+m+rLKfYV5kD0MFAUyY0w==
ARC-Seal: i=1; s=key1; d=yhetil.org; t=1659558615; a=rsa-sha256; cv=none;
	b=njJn5CEdsHYHt4rGrNMzdpT+RmtsY0331dT3/JWV5Cx8W2tAzjq1kEQGpvCZDRZ+t7Cwiw
	GINcsbqboJLsGtINgfWw41Q93vxa8ofzotSADKJ9hUpsrIKqUE/wsjxPk0oiYx9AYQItu+
	KKFgFVZ/miy4CH0aXUN7xPAIeKiWOFAw5sI8rpNBeKYqwxOcM0+wIF4+Q7erECUia98O03
	87fFlmPe/vgFCK+uICEAz/hqmFtIINIxih3La9DbSjactHdfLB55ebR0aUwcKH/kHgFbly
	RmJMOM+XtHiTxiGLtSwma1vWcaj+NRiGi3doLVfblAUxf0hch8hfpwKzeHtHpg==
ARC-Authentication-Results: i=1;
	aspmx1.migadu.com;
	dkim=none;
	dmarc=none;
	spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"
X-Migadu-Spam-Score: -3.31
Authentication-Results: aspmx1.migadu.com;
	dkim=none;
	dmarc=none;
	spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"
X-Migadu-Queue-Id: 9911384CE
X-Spam-Score: -3.31
X-Migadu-Scanner: scn0.migadu.com
X-TUID: wkprgy3i9cg6


--qj5emkyCKTeLaOQD
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Sorry for top posting.

You should send patches to guix-patches@gnu.org. Also I see you've added
gawk and perf as inputs, but a bunch of the scripts need to actually be
wrapped with those inputs.

On Wed, Aug 03, 2022 at 02:34:26PM -0400, Olivier Dion wrote:
> * gnu/packages/instrumentation.scm (perf-tools): New variable.
> ---
>  gnu/packages/instrumentation.scm | 46 ++++++++++++++++++++++++++++++++
>  1 file changed, 46 insertions(+)
>=20
> diff --git a/gnu/packages/instrumentation.scm b/gnu/packages/instrumentat=
ion.scm
> index 4e23e9bed4..66329c55a1 100644
> --- a/gnu/packages/instrumentation.scm
> +++ b/gnu/packages/instrumentation.scm
> @@ -18,6 +18,7 @@
> =20
>  (define-module (gnu packages instrumentation)
>    #:use-module (gnu packages base)
> +  #:use-module (gnu packages bash)
>    #:use-module (gnu packages bison)
>    #:use-module (gnu packages boost)
>    #:use-module (gnu packages datastructures)
> @@ -25,6 +26,7 @@ (define-module (gnu packages instrumentation)
>    #:use-module (gnu packages elf)
>    #:use-module (gnu packages engineering)
>    #:use-module (gnu packages flex)
> +  #:use-module (gnu packages gawk)
>    #:use-module (gnu packages glib)
>    #:use-module (gnu packages haskell-xyz)
>    #:use-module (gnu packages libunwind)
> @@ -290,6 +292,50 @@ (define-public lttng-tools
>  @code{lttng-relayd} for network streaming.")
>      (license (list  license:gpl2 license:lgpl2.1))))
> =20
> +(define-public perf-tools
> +  (package
> +    (name "perf-tools")
> +    (version "1.0")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/brendangregg/perf-tools")
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32 "1ab735idi0h62yvhzd7822jj3555vygixv4xjrfrdvi8d2hh=
z6qn"))))
> +    (build-system copy-build-system)
> +    (arguments
> +     `(#:install-plan
> +       ',(append
> +          (map (cut list <> "bin/")
> +               '("disk/bitesize"
> +                 "fs/cachestat"
> +                 "execsnoop"
> +                 "kernel/funccount"
> +                 "kernel/funcgraph"
> +                 "kernel/funcslower"
> +                 "kernel/functrace"
> +                 "iolatency"
> +                 "iosnoop"
> +                 "killsnoop"
> +                 "kernel/kprobe"
> +                 "opensnoop"
> +                 "misc/perf-stat-hist"
> +                 "tools/reset-ftrace"
> +                 "syscount"
> +                 "net/tcpretrans"
> +                 "system/tpoint"
> +                 "user/uprobe"))
> +          '(("man/man8/" "share/man/man8")))))
> +    (inputs (list bash gawk perf))
> +    (home-page "https://github.com/brendangregg/perf-tools")
> +    (synopsis "Performance analysis tools")
> +    (description "Perf-tools is a collection of scripts for performance
> +analysis and instrumentation based on Linux perf_events (aka perf) and
> +ftrace.")
> +    (license (list license:gpl2))))
> +
>  (define-public uftrace
>    (package
>      (name "uftrace")
> --=20
> 2.37.1
>=20
>=20

--=20
Efraim Flashner   <efraim@flashner.co.il>   =D7=90=D7=A4=D7=A8=D7=99=D7=9D =
=D7=A4=D7=9C=D7=A9=D7=A0=D7=A8
GPG key =3D A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

--qj5emkyCKTeLaOQD
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmLq2poACgkQQarn3Mo9
g1HJEg/+IU77zLZc6SB437XZatrzZ7AP3ix9+CcQENQSAtkZ9AjXdrTczwgRSTS4
sZ4wHnTreClHdzgRpPVt3NU9FguDpVAKE480umnUduRwOBWxUJ7Qh+UAAI3fjvYi
F/qW+8iR6p3eCR9o6pBrRLewKrwYk4yagDV2QXTrku/fqbyUOBPC0elo+1P7dvaZ
F4sKqNhWT4eVe2z/TNM18aKKzjeAojwCyEPpAW7xJiu8l5tyD0p0Fjiyh2ubmZTP
oT9sNN47k8NSjrXdXZzh4ryadg/x6y2BY6JpzFyNsB3ubnV9wz2tzQ4dJ1EvKmqJ
Poo5H6lXVURXZvwcuemQaK09qQv1nolD4JsUnYKmmFRms8cbIpDfTa8hTOTzss35
jk+41k9rwd0eG2yce10I7MGVrlKQYePbpe+acBY8gr11g/YJngbqOFSWrhhXPfVv
YYxDp2ceD12h+7F16j+dpVdh8/0vNwEhZ/JB+c1FsuihpbREXQ13yJGzbYIna56z
9V/azjXzuUn2nnFHdsxtGZxio6ZRCW+1MU2wuKwyrL/yKfL4ry4zLha4NuTyNz1a
QK2mm1UR0VlcZqk7jM8g+cicEMVATPvYl6Ozqc/I8+spt0oJtp56bOfhXerJz/cm
w0tZz9HYkVY/OM0RQsW3cami8zA8tKbkYKN6RdDrrSsZrh6JPL0=
=YIsl
-----END PGP SIGNATURE-----

--qj5emkyCKTeLaOQD--