bug#54658: "pypi->guix-package, no wheel" test fails

bug#54658: "pypi->guix-package, no wheel" test fails

[Maxime Devos]

[-- Attachment #1: Type: text/plain, Size: 3586 bytes --]

I noticed "./pre-inst-env guix build guix" fails on my computer due to
"pypi->guix-package, no wheel" failing.  Here is an excerpt from the log:

> test-name: pypi->guix-package, no wheel
> location: /tmp/guix-build-guix-1.3.0-24.2fb4304.drv-
> 0/source/tests/pypi.scm:221
> source:
> + (test-assert
> +   "pypi->guix-package, no wheel"
> +   (mock ((guix import utils)
> +          url-fetch
> +          (lambda (url file-name)
> +            (match url
> +                   ("https://example.com/foo-1.0.0.tar.gz"
> +                    (begin
> +                      (mkdir-p "foo-1.0.0/src/bizarre.egg-info")
> +                      (with-output-to-file
> +                        "foo-1.0.0/src/bizarre.egg-
> info/requires.txt"
> +                        (lambda () (display test-requires.txt)))
> +                      (parameterize
> +                        ((current-output-port (%make-void-port
> "rw+")))
> +                        (system* "tar" "czvf" file-name "foo-
> 1.0.0/"))
> +                      (delete-file-recursively "foo-1.0.0")
> +                      (set! test-source-hash
> +                        (call-with-input-file file-name port-
> sha256))))
> +                   (" 
> https://example.com/foo-1.0.0-py2.py3-none-any.whl"
> +                    #f)
> +                   (_ (error "Unexpected URL: " url)))))
> +         (mock ((guix http-client)
> +                http-fetch
> +                (lambda (url . rest)
> +                  (match url
> +                         ("https://pypi.org/pypi/foo/json"
> +                          (values
> +                            (open-input-string test-json-1)
> +                            (string-length test-json-1)))
> +                         (" 
> https://example.com/foo-1.0.0-py2.py3-none-any.whl"
> +                          #f)
> +                         (_ (error "Unexpected URL: " url)))))
> +               (match (pypi->guix-package "foo")
> +                      (('package
> +                        ('name "python-foo")
> +                        ('version "1.0.0")
> +                        ('source
> +                         ('origin
> +                          ('method 'url-fetch)
> +                          ('uri ('pypi-uri "foo" 'version))
> +                          ('sha256 ('base32 (? string? hash)))))
> +                        ('build-system 'python-build-system)
> +                        ('propagated-inputs
> +                         ('list 'python-bar 'python-foo))
> +                        ('native-inputs ('list 'python-pytest))
> +                        ('home-page "http://example.com")
> +                        ('synopsis "summary")
> +                        ('description "summary")
> +                        ('license 'license:lgpl2.0))
> +                       (and (string=?
> +                              (bytevector->nix-base32-string test-
> source-hash)
> +                              hash)
> +                            (equal?
> +                              (pypi->guix-package "foo" #:version
> "1.0.0")
> +                              (pypi->guix-package "foo"))
> +                            (guard (c ((error? c) #t))
> +                                   (pypi->guix-package
> +                                     "foo"
> +                                     #:version
> +                                     "42"))))
> +                      (x (pk 'fail x #f))))))
> actual-value: #f
> result: FAIL

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

bug#54658: "pypi->guix-package, no wheel" test fails

[Ludovic Courtès]

Hi,

Maxime Devos <maximedevos@telenet.be> skribis:

> I noticed "./pre-inst-env guix build guix" fails on my computer due to
> "pypi->guix-package, no wheel" failing.  Here is an excerpt from the log:

Which commit are you building for?  For x86_64-linux?

Current ‘guix’ package seems to be fine:

--8<---------------cut here---------------start------------->8---
$ guix describe
Generation 210	Apr 11 2022 09:34:10	(current)
  guix 7da907f
    repository URL: https://git.savannah.gnu.org/git/guix.git
    branch: master
    commit: 7da907f90e74a4edf96d76ee457ff958265ef8d4
$ guix weather guix
computing 1 package derivations for x86_64-linux...
looking for 1 store items on https://ci.guix.gnu.org...
https://ci.guix.gnu.org
  100.0% substitutes available (1 out of 1)
  at least 158.4 MiB of nars (compressed)
  303.7 MiB on disk (uncompressed)

  971 queued builds
      powerpc64le-linux: 504 (51.9%)
      i686-linux: 140 (14.4%)
      x86_64-linux: 327 (33.7%)
  build rate: 85.17 builds per hour
      armhf-linux: 22.58 builds per hour
      i686-linux: 21.50 builds per hour
      powerpc64le-linux: 8.06 builds per hour
      aarch64-linux: 23.71 builds per hour
      x86_64-linux: 10.05 builds per hour
looking for 1 store items on https://bordeaux.guix.gnu.org...
https://bordeaux.guix.gnu.org
  100.0% substitutes available (1 out of 1)
  41.8 MiB of nars (compressed)
  303.7 MiB on disk (uncompressed)
  2.105 seconds per request (2.1 seconds in total)
  0.5 requests per second
  (continuous integration information unavailable)
$ guix build guix --no-grafts -d
/gnu/store/vz0lxjxh0fykjk2rsgjycx59svclpj3v-guix-1.3.0-24.2fb4304.drv
--8<---------------cut here---------------end--------------->8---

Ludo’.

bug#54658: "pypi->guix-package, no wheel" test fails

[Maxime Devos]

[-- Attachment #1: Type: text/plain, Size: 757 bytes --]

Ludovic Courtès schreef op wo 13-04-2022 om 08:48 [+0200]:
> Hi,
> 
> Maxime Devos <maximedevos@telenet.be> skribis:
> 
> > I noticed "./pre-inst-env guix build guix" fails on my computer due to
> > "pypi->guix-package, no wheel" failing.  Here is an excerpt from the log:
> 
> Which commit are you building for?  For x86_64-linux?
> 
> Current ‘guix’ package seems to be fine:

I can reproduce it in a Guix checkout for
855097683230b756ba28636bed03ce904b6f3589 with "make check
TESTS=tests/pypi.scm". (x86_64-linux)

It appears to be non-deterministic though --  the first "make check
TESTS=tests/pypi.scm" failed, but the later ones succeeded.

I'll try adding some pk debugging and running it in a loop.

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

bug#54658: "pypi->guix-package, no wheel" test fails

[Maxime Devos]

[-- Attachment #1.1: Type: text/plain, Size: 2162 bytes --]

Maxime Devos schreef op wo 13-04-2022 om 09:52 [+0200]:
> Ludovic Courtès schreef op wo 13-04-2022 om 08:48 [+0200]:
> > Hi,
> > 
> > Maxime Devos <maximedevos@telenet.be> skribis:
> > 
> > > I noticed "./pre-inst-env guix build guix" fails on my computer
> due to
> > > "pypi->guix-package, no wheel" failing.  Here is an excerpt from
> the log:
> > 
> > Which commit are you building for?  For x86_64-linux?
> > 
> > Current ‘guix’ package seems to be fine:
> 
> I can reproduce it in a Guix checkout for
> 855097683230b756ba28636bed03ce904b6f3589 with "make check
> TESTS=tests/pypi.scm". (x86_64-linux)
> 
> It appears to be non-deterministic though --  the first "make check
> TESTS=tests/pypi.scm" failed, but the later ones succeeded.
> 
> I'll try adding some pk debugging and running it in a loop.

I added some pk:

;;; (found     (package (name "python-foo") (version "1.0.0") (source (origin (method url-fetch) (uri (pypi-uri "foo" version)) (sha256 (base32 "03rsmi1ricql316vak5gs89prv8494k1j7cgcgj7a763bcd6n4fa")))) (build-system python-build-system) (propagated-inputs (list python-bar python-foo)) (native-inputs (list python-pytest)) (home-page "http://example.com") (synopsis "summary") (description "summary") (license license:lgpl2.0)))

;;; (foo@1.0.0 (package (name "python-foo") (version "1.0.0") (source (origin (method url-fetch) (uri (pypi-uri "foo" version)) (sha256 (base32 "0z67xsvpivl9509m5l7n369nakszvnvm7ird09qgs6vn5pwqcl35")))) (build-system python-build-system) (propagated-inputs (list python-bar python-foo)) (native-inputs (list python-pytest)) (home-page "http://example.com") (synopsis "summary") (description "summary") (license license:lgpl2.0)))

;;; (foo@?? (package (name "python-foo") (version "1.0.0") (source (origin (method url-fetch) (uri (pypi-uri "foo" version)) (sha256 (base32 "03rsmi1ricql316vak5gs89prv8494k1j7cgcgj7a763bcd6n4fa")))) (build-system python-build-system) (

The problem is that the hash of 'found' and 'found@1.0.0' doesn't match :

03rsmi1ricql316vak5gs89prv8494k1j7cgcgj7a763bcd6n4fa
0z67xsvpivl9509m5l7n369nakszvnvm7ird09qgs6vn5pwqcl35

TBI ...

[-- Attachment #1.2: Type: text/x-patch, Size: 1497 bytes --]

diff --git a/tests/pypi.scm b/tests/pypi.scm
index 88bb0a3116..359dd58bb1 100644
--- a/tests/pypi.scm
+++ b/tests/pypi.scm
@@ -245,7 +245,7 @@ Requires-Dist: pytest (>=3.1.0); extra == 'testing'
                               (string-length test-json-1)))
                      ("https://example.com/foo-1.0.0-py2.py3-none-any.whl" #f)
                      (_ (error "Unexpected URL: " url)))))
-                (match (pypi->guix-package "foo")
+                (match (pk 'found (pypi->guix-package "foo"))
                   (('package
                      ('name "python-foo")
                      ('version "1.0.0")
@@ -265,10 +265,10 @@ Requires-Dist: pytest (>=3.1.0); extra == 'testing'
                    (and (string=? (bytevector->nix-base32-string
                                    test-source-hash)
                                   hash)
-                        (equal? (pypi->guix-package "foo" #:version "1.0.0")
-                                (pypi->guix-package "foo"))
-                        (guard (c ((error? c) #t))
-                          (pypi->guix-package "foo" #:version "42"))))
+                        (equal? (pk 'foo@1.0.0 (pypi->guix-package "foo" #:version "1.0.0"))
+                                (pk 'foo@?? (pypi->guix-package "foo")))
+                        (guard (c ((error? c) (pk 'c c #t)))
+                          (pk 'n (pypi->guix-package "foo" #:version "42")))))
                   (x
                    (pk 'fail x #f))))))
 

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

bug#54658: "pypi->guix-package, no wheel" test fails

[Ludovic Courtès]

Hi,

Maxime Devos <maximedevos@telenet.be> skribis:

> The problem is that the hash of 'found' and 'found@1.0.0' doesn't match :
>
> 03rsmi1ricql316vak5gs89prv8494k1j7cgcgj7a763bcd6n4fa
> 0z67xsvpivl9509m5l7n369nakszvnvm7ird09qgs6vn5pwqcl35
>
> TBI ...

Could it be that the test is talking to some other server?

Ludo’.

bug#54658: "pypi->guix-package, no wheel" test fails

[Maxime Devos]

[-- Attachment #1: Type: text/plain, Size: 553 bytes --]

Ludovic Courtès schreef op wo 20-04-2022 om 22:15 [+0200]:
> Hi,
> 
> Maxime Devos <maximedevos@telenet.be> skribis:
> 
> > The problem is that the hash of 'found' and 'found@1.0.0' doesn't match :
> > 
> > 03rsmi1ricql316vak5gs89prv8494k1j7cgcgj7a763bcd6n4fa
> > 0z67xsvpivl9509m5l7n369nakszvnvm7ird09qgs6vn5pwqcl35
> > 
> > TBI ...
> 
> Could it be that the test is talking to some other server?

It fails and succeeds both with networking enabled and disabled, and
nothing (Guix-related) appears in Wireshark.

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

bug#54658: "pypi->guix-package, no wheel" test fails

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 517 bytes --]

On Thu, Mar 31, 2022 at 10:26:06PM +0200, Maxime Devos wrote:
> I noticed "./pre-inst-env guix build guix" fails on my computer due to
> "pypi->guix-package, no wheel" failing.  Here is an excerpt from the log:
> 
< snip >
> 
> Greetings,
> Maxime.

FWIW this test also fails on riscv64-linux.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]