bug#55373: efibootmgr fails to cross-compile: it looks for 'pkg-config' instead of 'TARGET-pkg-config'

bug#55373: efibootmgr fails to cross-compile: it looks for 'pkg-config' instead of 'TARGET-pkg-config'

[Maxime Devos]

[-- Attachment #1: Type: text/plain, Size: 657 bytes --]

X-Debbugs-CC: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>

Title says it all.

Also see the following excerpt from the build log:

> make -f /tmp/guix-build-efibootmgr-17.drv-0/source/Make.deps deps SOURCES="efibootmgr.c efi.c unparse_path.c" SUBDIR_CFLAGS="-I/tmp/guix-build-efibootmgr-17.drv-0/source/src/include"
> /gnu/store/4y5m9lb8k3qkb1y9m02sw9w9a6hacd16-bash-minimal-5.1.8/bin/sh: line 1: pkg-config: command not found

Looks like PKG_CONFIG needs to be added to #:make-flags:
<https://github.com/rhboot/efibootmgr/blob/892cb7444ce6f2cded9c67ff2ab3ef35a4c810c8/Make.rules#L64>.

Maybe AR and CC as well.


Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

bug#55373: efibootmgr fails to cross-compile: it looks for 'pkg-config' instead of 'TARGET-pkg-config'

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 1068 bytes --]

On Wed, May 11, 2022 at 07:23:41PM +0200, Maxime Devos wrote:
> X-Debbugs-CC: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
> 
> Title says it all.
> 
> Also see the following excerpt from the build log:
> 
> > make -f /tmp/guix-build-efibootmgr-17.drv-0/source/Make.deps deps SOURCES="efibootmgr.c efi.c unparse_path.c" SUBDIR_CFLAGS="-I/tmp/guix-build-efibootmgr-17.drv-0/source/src/include"
> > /gnu/store/4y5m9lb8k3qkb1y9m02sw9w9a6hacd16-bash-minimal-5.1.8/bin/sh: line 1: pkg-config: command not found
> 
> Looks like PKG_CONFIG needs to be added to #:make-flags:
> <https://github.com/rhboot/efibootmgr/blob/892cb7444ce6f2cded9c67ff2ab3ef35a4c810c8/Make.rules#L64>.
> 
> Maybe AR and CC as well.
> 

I also needed to adjust efivar so it would refer to the correct gcc when
cross-compiling. Anyway, this should now be fixed.


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]