From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cCC/FHqgRWI6TQEAgWs5BA (envelope-from ) for ; Thu, 31 Mar 2022 14:37:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id UPViEXqgRWI5nQAAauVa8A (envelope-from ) for ; Thu, 31 Mar 2022 14:37:14 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EA06EFC35 for ; Thu, 31 Mar 2022 14:37:13 +0200 (CEST) Received: from localhost ([::1]:56582 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZu37-0000tG-3m for larch@yhetil.org; Thu, 31 Mar 2022 08:37:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58548) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZu2w-0000ro-2Y for guix-patches@gnu.org; Thu, 31 Mar 2022 08:37:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44331) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nZu2v-0002JS-Q2 for guix-patches@gnu.org; Thu, 31 Mar 2022 08:37:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nZu2v-0004jx-J2 for guix-patches@gnu.org; Thu, 31 Mar 2022 08:37:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54635] [PATCH 1/5] gnu: gsl: Force bootstrap when cross-compiling to riscv64-linux. Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 31 Mar 2022 12:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54635 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Arun Isaac Cc: 54635@debbugs.gnu.org, Maxime Devos Received: via spool by 54635-submit@debbugs.gnu.org id=B54635.164873017118160 (code B ref 54635); Thu, 31 Mar 2022 12:37:01 +0000 Received: (at 54635) by debbugs.gnu.org; 31 Mar 2022 12:36:11 +0000 Received: from localhost ([127.0.0.1]:38227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZu27-0004ip-2R for submit@debbugs.gnu.org; Thu, 31 Mar 2022 08:36:11 -0400 Received: from flashner.co.il ([178.62.234.194]:47224) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZu24-0004ia-Oe for 54635@debbugs.gnu.org; Thu, 31 Mar 2022 08:36:09 -0400 Received: from localhost (unknown [5.102.239.82]) by flashner.co.il (Postfix) with ESMTPSA id A68C640023; Thu, 31 Mar 2022 12:36:02 +0000 (UTC) Date: Thu, 31 Mar 2022 15:35:20 +0300 From: Efraim Flashner Message-ID: Mail-Followup-To: Efraim Flashner , Arun Isaac , Maxime Devos , 54635@debbugs.gnu.org References: <20220330091913.23206-1-arunisaac@systemreboot.net> <20220330092313.23584-1-arunisaac@systemreboot.net> <87k0cazl4s.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pIPAtajNCU2EQRLC" Content-Disposition: inline In-Reply-To: <87k0cazl4s.fsf@systemreboot.net> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1648730234; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=q3Qe7Yv+ym+wFQUKSr5v3zY04nqI+Do9zBhInUaeAD0=; b=eFN2Dq/3g1bokgzbmJyg771ldu9n0ka0M52jOxbYbhsRgKu0mBOaEG5/piIiFmTDPHzBKg CtbEyEJmDya0y0rY01kCPI3ZDKShWrCLbqJihK3NhZnrKF/swQ3/X0riV+HhcbqGZuEcaV 6ZDBcr8esGzTV5KWX2TgeIxABCwEd7L5Ni+GelL2HiIbBcCufqgipjHo0r7KAKniZisqJH 9fjGl4vdgbK2ZioppB7pZe3oTNq2NrAUK+P1Nu50co5yl+TvX4b8Zwj6TJ8a63St8ULZ4E y4lN1g7BDAEx9djTvED3M/S97ipBON/dK6gz9aE01cOUA4wWfKuhGBwXDzklTw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1648730234; a=rsa-sha256; cv=none; b=Ik1Ry0yXy25mSK4ezey+vnmnZ+g+4KMfJgtmHmU9dL25xU4fbLznzq/dKASM+DzMjPQRT7 X8uq7MsqqCpgWAfDN+6bmq7hy0YGwGYRwT51VZvh3aeMmtzxhSVk1K4wPHQq5LAwTrrW2A VuuycgychZLgbBLEFUSzriRn/DOkGfwZT12CSP5oAa7d4rWCvRH7QwNUpmEns+V8EaBdSw L+rrTOV/KQiyu8Hwep3FJeNsBEaiau2fPVHaJyaLD7ca4+Rz41LB0zVodOMSBrkDL0nC8Q pcAD37T/IAx94hfQIfPe1L45Pb/mLlOmrBf4UuTkT+ZiEK4Fkg4yxm5f95rvDA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.97 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: EA06EFC35 X-Spam-Score: -4.97 X-Migadu-Scanner: scn0.migadu.com X-TUID: EWFeh2JADL13 --pIPAtajNCU2EQRLC Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 31, 2022 at 12:03:39PM +0530, Arun Isaac wrote: >=20 > >> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ,= @(cond > >> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 ((target-riscv64?) > >> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 '((add-after 'unpack 'force-bootstrap > >> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (lambda _ > >> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ;; gsl ships with an= old configure script that does not > >> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ;; support riscv64. = Regenerate it. > >> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (delete-file "config= ure"))))) > >> > + > >>=20 > >> WDYT of making this unconditional? Two benefits: > >>=20 > >> * if Guix is ported to another new architecture, > >> then no changes are necessary to the package definition. > >>=20 > >> * 'configure' and 'Makefile.in' are not source code, > >> and more difficult to audit for things like malware than > >> 'configure.ac' and 'Makefile.am'. > > > > This can be with a TODO for core-updates. gsl itself has about 2000 > > dependant packages. >=20 > I agree. That was my reasoning as well. If we agree that making it > unconditional is the way forward, I can send another patch for > core-updates after this patchset is pushed to master. >=20 > > That said, I'm not convinced about unilaterally removing configure > > unless we make it a policy to remove it. Also, I haven't had trouble > > with building gsl on riscv64-linux without this patch. >=20 > Without the force-boostrap phase, the configure phase fails during > cross-compilation. >=20 > --8<---------------cut here---------------start------------->8--- =2E.snip.. > --8<---------------cut here---------------end--------------->8--- I somehow missed that when I was testing it before. It builds fine natively on riscv64-linux and I haven't tested cross-building from riscv64-linux to another architecture. I think for now we can tag it as (target-riscv64?) and (%current-target-system) so it only takes effect when needed. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --pIPAtajNCU2EQRLC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmJFoAgACgkQQarn3Mo9 g1H93g//edLAeCpCtFeziUbaQZeCSmK4jwK1d9VL4koOJg6uK+TEWMHkrLJxAZ7A Q3ShizTjmjVeJaMv/EqFZNO7FZprcVj72H6+6F+D1R0YEy89NSRvdUPMssA9ng1b rbSLLv+8KYhKUP8lTHhxhhesylZMZD6aQrT/4njgxV4WN7LMaOM6pEkvMPQ+GOG0 UdcetnlZdsulbCXpqRnjjJMqXZjisZHSKVd+b17ajCMtgxE5ywHj/lWrbhNkjnsw mCYgCBbnx7cxZM8/gRP09WcANcfVZWlPE3r+g2+PI7hjDJ4W+dKkh8EeTyecyvZq c+jJU+kmjSEfKuLsiRUTgh1F286kGtZREyMVjzuLbIsAR+WI03IUCQAls7pjliod GmJkJwe9sLX9O1qAyTNuoPOVj+VUF3F9If+eeYpQlJS3GCPluBHK3wz78+4Jhn62 4abHy/3LNAPxNXLH7VtMQcv39rFz3gPkHyV0Rikm0TiJiiVhXcWCGVJEle+YAUYN VKvOnBfPnC1rxAVvbWyD6ie/v8dp+xNjU3hZsRl1p8FbSyORqaqnW4HeJIe1pNys fvJ6EXIqWiSTGf+Dhn45QuFF2zUjSWZf8y+wxsm69Hew0wJrfjx0Wy0fvAwH7HhM WJ99UMHcopoU4LsL2QfBPVySsg+iK26RCR6g/qq1NkpzBEyEHDw= =4Unz -----END PGP SIGNATURE----- --pIPAtajNCU2EQRLC--