From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id fW8JH2zcCGKoywAAgWs5BA (envelope-from ) for ; Sun, 13 Feb 2022 11:24:44 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id yCSKGmzcCGK0/gAAauVa8A (envelope-from ) for ; Sun, 13 Feb 2022 11:24:44 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 806FA459FA for ; Sun, 13 Feb 2022 11:24:43 +0100 (CET) Received: from localhost ([::1]:51570 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nJC3e-0000c4-Au for larch@yhetil.org; Sun, 13 Feb 2022 05:24:42 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55350) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJC31-0000aj-1C for guix-patches@gnu.org; Sun, 13 Feb 2022 05:24:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:42602) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nJC2z-0005eI-Vv for guix-patches@gnu.org; Sun, 13 Feb 2022 05:24:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nJC2z-0007T2-SR for guix-patches@gnu.org; Sun, 13 Feb 2022 05:24:01 -0500 Subject: bug#53656: [PATCH 0/2] 2 Julia packages Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Sun, 13 Feb 2022 10:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 53656 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun Cc: 53656-done@debbugs.gnu.org Received: via spool by 53656-done@debbugs.gnu.org id=D53656.164474784028693 (code D ref 53656); Sun, 13 Feb 2022 10:24:01 +0000 Received: (at 53656-done) by debbugs.gnu.org; 13 Feb 2022 10:24:00 +0000 Received: from localhost ([127.0.0.1]:36497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJC2y-0007Sj-Hz for submit@debbugs.gnu.org; Sun, 13 Feb 2022 05:24:00 -0500 Received: from flashner.co.il ([178.62.234.194]:55338) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJC2w-0007SV-L3 for 53656-done@debbugs.gnu.org; Sun, 13 Feb 2022 05:23:59 -0500 Received: from localhost (unknown [37.46.46.251]) by flashner.co.il (Postfix) with ESMTPSA id 54C1840349; Sun, 13 Feb 2022 10:23:52 +0000 (UTC) Date: Sun, 13 Feb 2022 12:23:19 +0200 From: Efraim Flashner Message-ID: Mail-Followup-To: Efraim Flashner , zimoun , 53656-done@debbugs.gnu.org References: <93a51e504cd30094511b1eac3957e10ff800cdf0.1643625386.git.efraim@flashner.co.il> <87r18a8zee.fsf_-_@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="V5gLirqurfPJVpm6" Content-Disposition: inline In-Reply-To: <87r18a8zee.fsf_-_@gmail.com> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644747883; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=GEBvNOV/AbMSTAfTYafksF7fDmJqE8wmigrVfWjBsMc=; b=nYRayuSlVJgpWKOkrL2iARuVPzgjZ52XbYP8SrfwhEv4gJ9QrL9zMLkR1iTkau0khA4dfK 2z7uIyVyPd7yXR4yaobQqgyv+5RyKDJlk9AWpWAiCvbNPgOcNDXQybit5oLt0PgQRgZIVR n8laNSWQzrPILKfKa44Q6FIiFC5ac5Oj4b1W8s7WRETH3cZpIt1tAjcm6cZRsb7gp2ZP6K 5Q8caxk3BrAELKC6VSOTsUvBXaVgw5Vs2mxOYNoZXFT2xuwqNZALFutUItbV4H+lFliSDs xJ1qaqjeq/Xv7zTctd7YVaKCd9sluYc6GJaf5NOl00smHs6/bBDiN8LhYZP48w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1644747883; a=rsa-sha256; cv=none; b=TQ+yLO9hBm0FuOEpTceccOtDimV18jOHmTnZ6yJVo3cGtfASX1nWBkbMIQT6UGoGu6skid IRYn+paaUud2Wgvunvxvsrq5fWJzkMvHgOsskhTrDLG6UVTT20sSOHWcPXYm8LGWNqmqv0 3yXwlvStnbvnUH+geuiIG2/b0zC+KaZNQsBtnJM/MU7Cp8uIu/evMurKxEiLye11KVDB+p LHcnQVvctCCJlCEN+Qz0yu8I4O4P+yvOGQXtz1MpViVjPeIampI54aZohWDDKcsSyIy2P1 OJxHz6L+KfArBi4ps6nKvEySHXVATrSGvT9dwUAQXjfQRuZhlOUDD8Z/gL7dHQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.73 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 806FA459FA X-Spam-Score: -4.73 X-Migadu-Scanner: scn1.migadu.com X-TUID: o0xIPP/nTlxq --V5gLirqurfPJVpm6 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 10, 2022 at 05:22:33PM +0100, zimoun wrote: > Hi Efraim, >=20 > Both patches look good to me. >=20 >=20 > I notice this warning: >=20 > --8<---------------cut here---------------start------------->8--- > =E2=94=8C Warning: Package OptimTestProblems does not have LinearAlgebra = in its dependencies: > =E2=94=82 - If you have OptimTestProblems checked out for development and= have > =E2=94=82 added LinearAlgebra as a dependency but haven't updated your = primary > =E2=94=82 environment's manifest file, try `Pkg.resolve()`. > =E2=94=82 - Otherwise you may need to report an issue with OptimTestProbl= ems > =E2=94=94 Loading LinearAlgebra into OptimTestProblems from project depen= dency, future warnings for OptimTestProblems are suppressed. > --8<---------------cut here---------------end--------------->8--- It ends up not being a problem, but I'm left wondering if we should extend the #:julia-package-foo arguments to add more fields or if we should just add a custom phase to build a Package.toml that includes all the fields needed. > and... >=20 >=20 > On Mon, 31 Jan 2022 at 12:40, Efraim Flashner wro= te: >=20 > > * gnu/packages/julia-xyz.scm (julia-optim): New variable. >=20 > [...] >=20 > > + #:use-module (guix gexp) >=20 > [...] >=20 > > + #:phases > > + #~(modify-phases %standard-phases > > + (add-after 'unpack 'adjust-tests > > + (lambda _ > > + ;; TODO: Figure out why this test fails. > > + (substitute* "test/runtests.jl" > > + ((".*l_bfgs.*") ""))))))) >=20 > ...I am thinking loudly if this gexp is required. There are other many > similar patter without a gexp. Therefore, for consistency with the > rest, I would be in favor to switch to regular modification of phases. > Or let me know if this is becoming the new patter and I would adapt for > the others. It's definitely the new pattern we're using now. I suppose it's not really necessary here, but having more instances of it throughout the codebase also makes it easier to search for examples when others are looking to use or modify gexps. --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --V5gLirqurfPJVpm6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmII3BQACgkQQarn3Mo9 g1FiFhAArFpb+nlSp5h37UOgAu/iuK7v0wXIQ3Q66RSe7kssjSG/PqN4eVc7DDZS 6gwiOCCNIZrZYL/dmPs7a2DxjDMg9X9TW4d2VS5cU/3YVbQoS5AdLrFoBYeTTGX5 K+MzUROAz5TZhtsNObXwUWB4lcEjBK/xHAa16IXAvJss2bKOkQ5BXfh6Qor1lwSk odeIeqm/2hEXvKZ/ee6QYXsEoaEZDTLNIwhoOJdBIqIKTpcRIGfTLZdbKeZWyIcc HQDfDc231rWUeJUty+BCHXtaeWl+9uCTDhCVcTFgkDSsN8RJEcAvz8kyvdaQebfO j9yC4KnfZy9kWv6zWchzMZE0GWnHHSgIjZ6HFgR5mmDW1Ovm+OlwTlrxktK9oX3N OHJCcZhP2lERAdKu9ep9U/ex+1vgi5yM2RJJfE0wALj9fU14eIK6B7O2wBgiKa3j JYyVF+vL9XnhCoj9jakf6As7cS8TWLSw0lOKmYBr/gaq6ftt3sQU1gUl0DGj3/rJ IXKI2Q8qru7OBL4UJTwFdj6h0mMmeMDPv9yKtTFh46tXNgF4ZTvMyqVugu/iSonb dQAEAbL2Lv8jfFWl1zUQmvh5tgLOk9gSjaTE/dTjtURNqftNwtTj79a7khzYvXtn uTSJvhMP6fJiztzo7lU900fG5+7tyYExeesrbrhh3zeibtRSgCA= =Lfbu -----END PGP SIGNATURE----- --V5gLirqurfPJVpm6--