From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:f42::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id qOBoO8TRyGEsIAAAgWs5BA (envelope-from ) for ; Sun, 26 Dec 2021 21:34:12 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id UO4LOMTRyGE/WwAAauVa8A (envelope-from ) for ; Sun, 26 Dec 2021 21:34:12 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AA4CC3DEC2 for ; Sun, 26 Dec 2021 21:34:12 +0100 (CET) Received: from localhost ([::1]:43854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n1aDa-0002cO-Rz for larch@yhetil.org; Sun, 26 Dec 2021 15:34:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35658) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1aDS-0002bw-Nt for guix-patches@gnu.org; Sun, 26 Dec 2021 15:34:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:58334) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n1aDS-0000ea-Em for guix-patches@gnu.org; Sun, 26 Dec 2021 15:34:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n1aDS-00082j-3x for guix-patches@gnu.org; Sun, 26 Dec 2021 15:34:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH v6 2/3] installer: Recommend 'ntp-service-type' for non-graphical systems. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 26 Dec 2021 20:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.164055083630899 (code B ref 47979); Sun, 26 Dec 2021 20:34:02 +0000 Received: (at 47979) by debbugs.gnu.org; 26 Dec 2021 20:33:56 +0000 Received: from localhost ([127.0.0.1]:41645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1aDM-00082E-1S for submit@debbugs.gnu.org; Sun, 26 Dec 2021 15:33:56 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:48315) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1aDK-00081x-7H for 47979@debbugs.gnu.org; Sun, 26 Dec 2021 15:33:54 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 89DC23200929; Sun, 26 Dec 2021 15:33:48 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 26 Dec 2021 15:33:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=qsbXahxl+HPH/2Z1vh8DtWcf XGFSMpRGTjGYKgsqxBA=; b=k4hZ/hac5ReDfo7O8dE2LrRtuA3zy9qzRcP3nuDe PGX84sLOrtDrJFrExZWlLSuB1XVNOGoKURsRSj2r6UR02uZ6S/WwI4jcjZ9p+k2V Ivd7l4z3vT6T8zhA9bP0Gy4KSVANu77IifIMWen9ZqJKlKnqNeByyzx0t4n0QB3u gws= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=qsbXah xl+HPH/2Z1vh8DtWcfXGFSMpRGTjGYKgsqxBA=; b=Mml5ORc1oDs6OKGKfKad0U K1jQcqQ58e4pzBPOjoNiIV3yN4sujfdvnHcNak6oaMW+zuS6xCtyt6hsc8qzSR1j WvG8puZpYIlKvgOJrLDTD214NEAX5XC8JFKpLddaCN+FWF+BQls+S0fBoR2Koa8T 3EMcdztWi9qzHcsylrfIrjOpbb90Oncg4Vq+vh9Y6eIoHW19ulxPuqgXeOmFfz1b YGZUjfi8+iIZXoEzyMTpV1pO4Aiu8aQXmf57oUw4XgRLHhGxVvrZIg2uArd7XOHB NUR1sAB/wQp6nhwsEUxQljeRUjjBsSJqBVHLwwVDTQSOgXXlzR7G/WH2Ac4oFRxw == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddugedgjedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujgesghdtre ertddtvdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgr rhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhepudekveegteekleetgfeitdejgfejke ffudethedvhfeukeduleeikeejfeehffetnecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for <47979@debbugs.gnu.org>; Sun, 26 Dec 2021 15:33:47 -0500 (EST) Date: Sun, 26 Dec 2021 15:33:40 -0500 From: Leo Famulari Message-ID: References: <18b693c017c779578de0a6a367ebf0eab95c7054.1640550687.git.leo@famulari.name> <817dd7dd12e866f87428dcac82fff96e42c4ba77.1640550687.git.leo@famulari.name> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jkAnoMK9cQTwfQKQ" Content-Disposition: inline In-Reply-To: <817dd7dd12e866f87428dcac82fff96e42c4ba77.1640550687.git.leo@famulari.name> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1640550852; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=qsbXahxl+HPH/2Z1vh8DtWcfXGFSMpRGTjGYKgsqxBA=; b=loPGGIwJSMUKdoWQaDBEgf27/VEyWMyjF0ew1NPhBNqrf0YL2U87gvqBUSLVNHjGdkYgSZ bGMvdrhdRjYkqyW+/fOxbLzRBRzmSLlzOutvwzm9e77pCdKgNhoHyjmFgNbL0IyK6Vd42J cvnEWpMH6WEu0+z2YFZkg89V3abbbOourR+4/XMVZ1R6nKGiAyRV+9/7IGrTp6iTawS3I0 jodOwcdxMKP3+4Jrgyy9QNoxufLNWjD0aXJMdnEJ/hSXHCtWJzLDnwk/2BE7b+OdVTdtRf QOtsY4+nPqjCnKYt3uHw9m72ZlV2vAH6kobSkkiWReBZCnYUSABZX/5U5D23Lg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1640550852; a=rsa-sha256; cv=none; b=S9tHvXw7OwBzaEqa/xNNepGwoIr2FnslBRIIou5gu09TpmYc63oFJCzZ1byAlwEhhRSFgt x1Dz/2yDeZcreGGSE3M+/fM4+LwTUUsI6moST3RZcW5QVq7OJlII4YlsS1ioRn90jydbrN Yw6+8NnGK46SXPs/3GJU5RX2IKOaBNwHmchwRs3e6rTsryq7meapF+4DTYlH2ymHqrSCK4 UHRIoGcP25mZfBEt9+7tO40oy3CZnTfZr/3yfdmk8a13aIqCafdBxOlf8pJQ6Jjmu08CNl lZb134Oa+WNR3EVA/kueDCsec35sSiKm4IGXtROLVqQis0+X+K5FvQvkBJpI9g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b="k4hZ/hac"; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=Mml5ORc1; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.27 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b="k4hZ/hac"; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=Mml5ORc1; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: AA4CC3DEC2 X-Spam-Score: -4.27 X-Migadu-Scanner: scn1.migadu.com X-TUID: YGQHXIRq5Dzr --jkAnoMK9cQTwfQKQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Dec 26, 2021 at 03:31:30PM -0500, Leo Famulari wrote: > We had several bug reports with a root cause of "the clock was > incorrect" from users who used the installer to install a non-graphical > Guix System. >=20 > * gnu/installer/services.scm (%system-services): Add the ntp-service-type. > * gnu/installer/newt/services.scm (run-system-administration-cbt-page): N= ew > variable. > (run-services-page): Use run-system-administration-cbt-page when not > installing a desktop. > * gnu/installer/tests.scm (choose-services): Add and use a > choose-misc-service? procedure. > * gnu/tests/install.scm (installation-target-os-for-gui-tests):= Add > ntp-service-type. Here's v6 of this patch series. With it, the installer successfully installs systems with and without %desktop-services, and correctly chooses whether or not to offer NTP and GPM. It also passes `make check-system TESTS=3D"gui-installed-os"`. I think it's ready to go. --jkAnoMK9cQTwfQKQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAmHI0aEACgkQJkb6MLrK fwiwIhAA2S9Ib4pRPgo7KC3nHNTRppWY4fwmkIrAMrAbE50HlxuhXW3MqYYdj2TK EZILVqxM1gdZ1y6hnbHMq/CBTCkwEkrVHwlil7e9GtNglI7xIQ4YyySaVQOmANcw xj4izj2mygfuUnqSM2C9gw1UX+S5h2EHYWNTgIX3cDmZQbwJKQKMqn6LulPIPk8A ZQkGXhlyB7NMp6G9aq3yeCTYHnR3XOuu/BWBakwy2kaj/S3uRGn/NbZExFkBCmTY doMSn/62zdioWa97gDO0Inh5reSg/FB6TUVn4gMrjxG2+41+EPwePgSD8nrW96fw rev5NBIJjGVFzIUAMYQlxe6IzjSb4PyMibR7dOOFfT5At3r/NZ+6EMueOz/VYagQ RzXZtOVrEYxMoOzudNgnUVNpT9V8iVr6+bnW3bNz/2d+ZnD3TDaTRV4//ab5o9t4 MQ+wmauG6oPrco0PerDlLf+XeNB0WflAOiRocoRAnCv85JNo2iZA1eZ1SPR38e9f tmnrCcQlGj1urNNwV84MU4aJncJrYJi+yAAS3VPFPE+mhBrhywX4+q5RUJcMYc9K n5kbDaFIKhOb67wUEkrtDNt6JIWdgOEKG9IW5NS4z+N+qFtceAQf0Y15MB9/GxV2 E/5CNx2QPRX/iO9nEGiNb1QGnNuwmogB/L0yXAnx2ZW63xPpPWc= =VH0A -----END PGP SIGNATURE----- --jkAnoMK9cQTwfQKQ--