From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id EMl4Jv7auGEeKwAAgWs5BA (envelope-from ) for ; Tue, 14 Dec 2021 18:57:18 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 8HFTIv7auGF7cQAA1q6Kng (envelope-from ) for ; Tue, 14 Dec 2021 17:57:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 652609C3E for ; Tue, 14 Dec 2021 18:57:18 +0100 (CET) Received: from localhost ([::1]:60584 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mxC3B-0005Hi-L4 for larch@yhetil.org; Tue, 14 Dec 2021 12:57:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34950) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mxC34-0005Gm-1p for guix-patches@gnu.org; Tue, 14 Dec 2021 12:57:10 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:47946) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mxC2x-0001C6-32 for guix-patches@gnu.org; Tue, 14 Dec 2021 12:57:09 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mxC2x-0000v5-2E for guix-patches@gnu.org; Tue, 14 Dec 2021 12:57:03 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52486] [PATCH] gnu: deluge: Move librsvg to native inputs. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 14 Dec 2021 17:57:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52486 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 52486@debbugs.gnu.org Cc: dev@jpoiret.xyz X-Debbugs-Original-To: Josselin Poiret via Guix-patches via X-Debbugs-Original-Cc: 52486@debbugs.gnu.org, Josselin Poiret Received: via spool by 52486-submit@debbugs.gnu.org id=B52486.16395045903491 (code B ref 52486); Tue, 14 Dec 2021 17:57:03 +0000 Received: (at 52486) by debbugs.gnu.org; 14 Dec 2021 17:56:30 +0000 Received: from localhost ([127.0.0.1]:59491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxC2Q-0000uF-BT for submit@debbugs.gnu.org; Tue, 14 Dec 2021 12:56:30 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:55717) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxC2N-0000to-Ke for 52486@debbugs.gnu.org; Tue, 14 Dec 2021 12:56:27 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 73B225C01EA; Tue, 14 Dec 2021 12:56:22 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 14 Dec 2021 12:56:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=XYFTnODxk3ghIpol9XKKPya5 AK4+PGGj3QcRcEgOT/w=; b=NFry5miPvUJEYhBpbiphcB8MZYoraz2tt2ecILGd yHVkFfKPRrQuobXIIz7lOnNVnucuk3EIxQPfjQcY32nXSLa5n1sWWsGltMXmh9V7 hBsRY32pvD6P8QJIvjaV2LysZYzmLVBb/BVsLLMp9gOd+jwLvRR02g/+aO/PCRJy s0k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=XYFTnO Dxk3ghIpol9XKKPya5AK4+PGGj3QcRcEgOT/w=; b=LLwY2+H74P+bhwXIP3WzKs fEXwy8gCAfOd4hWqdrG7kNfhO2LHjBxQHZGppaeEyQ0iwYgIvvQnfaqgaAUu4k09 laFmX0Vam6m0sPKYsWHTiTDC8H1G0o0Nnw/csjLyvucgVVnLES5sxF3UwSTlE2bD EgqUPyG6uq3dKq7K5GMnuI1LOmK5OYr8k1UZ2rlFoA5k0R/RZyFxUXt4PMK3gltm xl+/VRswhu5dIXnKs20jUvaxEUxJMI8yGBUneYAfxm+qJl4aVBLY32SRZjvoLKkM lLKtqtRemxy+USvUqYeB5jS/EQU73i8Ov5tuQhJo2Gz5DAnfQT+AB6EKao36NlaA == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrledtgddutdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpeeukeektdffvddtudegjeegtdevhfeufeeivdejiedtieegtdevjedvjeehffev gfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvg hosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 14 Dec 2021 12:56:22 -0500 (EST) Date: Tue, 14 Dec 2021 12:56:20 -0500 From: Leo Famulari Message-ID: References: <20211214172151.28831-1-dev@jpoiret.xyz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211214172151.28831-1-dev@jpoiret.xyz> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1639504638; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=XYFTnODxk3ghIpol9XKKPya5AK4+PGGj3QcRcEgOT/w=; b=JCv9mvOxYwhUu2+QXYoEFVrHdk7sL21c+6p5pH9xgQuUFPjuXsQiWSgkl5AXR52qWc64I8 CfJuRFJwd5fjc0wkgMYfU1RY2ciFr9oY73i8w+LEBOQEq1HKmNq+5A6sbxsnwOPI6nmYty pBXBPo6QHw9/0Q2oTyJXmmxajGiKWrpoLa3LPUe7RxUETfMDwU2TUwvKQFi4fF5QMN2wzM 9t8fwzvAOSdMiRq0sU1VHlGxGYN3yDn3Y8pllJGvsnS6QefAjfbZEGWJeQdzUNwqjFSKrU 0MhRQPKH2mcq450SVRZvTLtdI4gRsc6MB5LUsunKt8CgLTbAoEnqLVDoVCELgg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1639504638; a=rsa-sha256; cv=none; b=dwBetoJMHCIssRcvturAKq2FrSfElu5b7JWhA3w4qEWYTFEcEjcUbVTnxfiAVZcfxKlgXa IkIFt9z9fA2WrHRuc5yO1cVK92rDwCkewk56ySjBuGQ607QGHlOApg29YtSzLwH42s04Mc jHYwaA2g/qAoZtawnFCNLj8EkFYrTUIu+p2VEa4ktBXlAhDcbf7BwvpFl30Az4+4f8ohQJ ccFMHEN8gG1+rreDiE3VurC6Nq4Q0Kn5Q4AKxR4Oe8cu4Vo+Dei3JE2zuEL4gEtjb5clhn UULsoShvhBGf8o/pBmv9cRkIQjEjnCGO83/hPo/HinNRcY0f3vRjegiEv2MIvA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=NFry5miP; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=LLwY2+H7; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.57 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=NFry5miP; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=LLwY2+H7; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 652609C3E X-Spam-Score: -2.57 X-Migadu-Scanner: scn0.migadu.com X-TUID: VkcWPvqVJgRt On Tue, Dec 14, 2021 at 06:21:51PM +0100, Josselin Poiret via Guix-patches via wrote: > Grepping the source code shows that librsvg is run by the > builder, and not by deluge itself. This fixes propagation conflicting > with gtk+'s librsvg. For now, use the C variant to build on all archs. > -- >8 -- I applied your patch and built Deluge. Then, I checked what packages it keeps a reference to: ------ $ guix gc --references $(./pre-inst-env guix build deluge) | grep librsvg /gnu/store/2dza2psfbrrbvsni8jjqzzqx3hmm8kw8-librsvg-2.50.7 /gnu/store/zxpbc78z40x7dr3ls4dgclkq7i4agx7a-librsvg-2.40.21 ------ So, Guix already records a run-time dependency on the Rust variant of librsvg (likely via GTK+), as well as the C variant if we apply your patch. I agree that, if Deluge does not use librsvg at run-time, we should make it a non-propagated-input. But, we should use the Rust variant on platforms where it is supported. Check the package definition of GTK+ for an example. And we should also make it a 'regular' input, because the package does keep a run-time reference to it. We are phasing out the C variant because it is abandoned upstream and no longer receiving security updates.