From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id yBENHt+ZdmELTgEAgWs5BA (envelope-from ) for ; Mon, 25 Oct 2021 13:49:51 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id MBOeGd+ZdmGafQAAbx9fmQ (envelope-from ) for ; Mon, 25 Oct 2021 11:49:51 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BD57DD083 for ; Mon, 25 Oct 2021 13:49:50 +0200 (CEST) Received: from localhost ([::1]:51690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1meyU9-0001QG-5Y for larch@yhetil.org; Mon, 25 Oct 2021 07:49:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41456) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1meyLe-0004SZ-4Z for guix-patches@gnu.org; Mon, 25 Oct 2021 07:41:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58437) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1meyLd-0006bv-Ql for guix-patches@gnu.org; Mon, 25 Oct 2021 07:41:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1meyLd-0005JI-M8 for guix-patches@gnu.org; Mon, 25 Oct 2021 07:41:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#51364] [PATCH] gnu: emacs-flymake-shellcheck: Add shellcheck as an input Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 25 Oct 2021 11:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51364 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Morgan.J.Smith@outlook.com Cc: 51364@debbugs.gnu.org Received: via spool by 51364-submit@debbugs.gnu.org id=B51364.163516202120327 (code B ref 51364); Mon, 25 Oct 2021 11:41:01 +0000 Received: (at 51364) by debbugs.gnu.org; 25 Oct 2021 11:40:21 +0000 Received: from localhost ([127.0.0.1]:41750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1meyKz-0005Hn-DO for submit@debbugs.gnu.org; Mon, 25 Oct 2021 07:40:21 -0400 Received: from flashner.co.il ([178.62.234.194]:44040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1meyKx-0005HV-GT for 51364@debbugs.gnu.org; Mon, 25 Oct 2021 07:40:20 -0400 Received: from localhost (unknown [141.226.169.107]) by flashner.co.il (Postfix) with ESMTPSA id 42C224004A; Mon, 25 Oct 2021 11:40:13 +0000 (UTC) Date: Mon, 25 Oct 2021 14:39:40 +0300 From: Efraim Flashner Message-ID: Mail-Followup-To: Efraim Flashner , Morgan.J.Smith@outlook.com, 51364@debbugs.gnu.org References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4OYT0zaN2xcFVJfW" Content-Disposition: inline In-Reply-To: X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1635162591; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=eG75Q3+7JKUzgLxAqgrhofsMpL1g/r6Y8GEzdkv9sCs=; b=cwUo0NbxsnKtypOfvkX9X+JYlus0KFeAFNaYgKQ8BbP5kJfSbgcwBvTjirS6qstO6k7hlH GxC6KK0QZKMvrWNughjqI+pRqZKx1h2J1R9kUl01NelC/fBizdShlONSl2fr+NQWlE4YiI GSGkxJcac2Jeaq22KSoqZIw+tlExs7uEvbBn4TW6Cs2Sv6VXfucrTUcqAonf91LJ/idZVb CpDIFKHoLbcBC4LBjQsqUC3K1J45R3WPmmLTqJFGIfeWAvshiWYLQ4MnoK/UV2fLQ6u3eE d4s8DTNtArPyY5/Ups/F1okqnolXacaLD76ndEBx2pbhAPQDRjrTf0YK3eaEbw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1635162591; a=rsa-sha256; cv=none; b=tB57VYBMIUR8bkrJJLl+O85LvuOFUWcYgMikWb5Aasl04epZqWeqZE3z1K0ZAxcxtafm/G DvRtmE1T7bUDu68MGgdhk/oX8zedz99anAAVH3+lbAY4sBz3faXPLBwPVYlzquEWNWiilw DlavF8E08sD5qwW9/utWc6yVQUgg6RBS8ZgztGkjcwYen/a0y/eTlygY8TEleh9JAUE4up t1qVuIbZ5rZMmncwIPySJdPem5F4vd7oDhAIw/dQFCkUHoQz46TCVk7W430fMJGvEztYqt GpVQom+fLKqXNuke62HYodu7U9cXPgQ0WateyP6j84RinsdEX9rQ2C/rwtIdVQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -4.03 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: BD57DD083 X-Spam-Score: -4.03 X-Migadu-Scanner: scn0.migadu.com X-TUID: NLqdf2Kfa1po --4OYT0zaN2xcFVJfW Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 23, 2021 at 06:21:28PM -0400, Morgan.J.Smith@outlook.com wrote: > From: Morgan Smith >=20 > * gnu/packages/emacs-xyz.scm (emacs-flymake-shellcheck) > [inputs]: Add shellcheck. > [arguments]: Add substitute-shellcheck-path phase. > --- > gnu/packages/emacs-xyz.scm | 12 ++++++++++++ > 1 file changed, 12 insertions(+) >=20 > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm > index aeb6aa4aba..602e6067a4 100644 > --- a/gnu/packages/emacs-xyz.scm > +++ b/gnu/packages/emacs-xyz.scm > @@ -1649,6 +1649,18 @@ (define-public emacs-flymake-shellcheck > (sha256 > (base32 "04yfb4sy41spjzk9mhm4gy0h8vnjx09p2g6nm1yzgd9a5ph9sqgl"= )))) > (build-system emacs-build-system) > + (arguments > + '(#:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'substitute-shellcheck-path > + (lambda* (#:key inputs #:allow-other-keys) > + (chmod "flymake-shellcheck.el" #o644) This line I'd change to (make-file-writable "flymake-shellcheck.el") > + (emacs-substitute-variables "flymake-shellcheck.el" > + ("flymake-shellcheck-path" > + (string-append (assoc-ref inputs "shellcheck") > + "/bin/shellcheck")))))))) > + (inputs > + `(("shellcheck" ,shellcheck))) > (home-page "https://github.com/federicotdn/flymake-shellcheck") > (synopsis "Flymake backend for Bash/Sh powered by ShellCheck") > (description > --=20 > 2.33.1 >=20 I'm not sure about hardcoding the path to shellcheck and removing the option to override it in the normal way of the file, by setting flymake-shellcheck-path=C2=B9. I am not sure of the exact return value of (executable-find "shellcheck") but it seems safer to replace that. Can you send an updated patch? =C2=B9 I assume, I don't actually use emacs --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --4OYT0zaN2xcFVJfW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmF2l3wACgkQQarn3Mo9 g1Eo4A/+IZ2xBPwxB8WbjWMa5NXZ10/s10IrFIwxgCUOXLJ8DB1Q3Dj+F+2MGBsF AIN+48J/nPRV/e1M9P5QaucSf90gST7sqlY0NesUHnPRhzLpiqLStH9NT0s+EZ4n QqW3WRnI2uRGvV2IUvgrw52ZpaiPQnDak2tVjKzRoaw6lUKwf9sqlR8m3gbgkrp/ QyuU9FapurPwI+YBPHY7C8SbUxUn+Dd1WUv/mBEyEw4+/E2hgw9+jHNwYnCz0QAI omdUCh6mMCsBJuu+SEea1VXrIttQzXtByK1OSucVRAvFlMj7a+nMrhmjQjOHwmAu onUcSvQNrbd6FFWn+g917MvsEMm6U0yP2HzRSKnhlZrqSkgEmzdK31NeG9mB307q cwg2nd4IeYLc4kFzJon3YeWU5cTb0y+AOqzt7Q4Zz/VbFkGFx2vVSeBv+0XmiLXv Riwdsrm+XQ6ARApS0T6xO6qRbCXPq6DQF+DMjUNvodd7mjALM1myVvyCPji2pHjd deEVY2hA/k6VcQvKZtBqkvz3YhWNyCvelGGv0UC+Ha0V26MOm+WaQ8HURjJyNk/v MKGpMCvhMsAjcwSd4pLhvsVTfQw9QNRvoP4QI+Ybhhse8Mq16e7UKcU7oI09SDfL PWg5R5Qe/Lj5U1SFLXhITLrfh+K2EPHxymVD3vHtRwmh28/Ew5Q= =WUG6 -----END PGP SIGNATURE----- --4OYT0zaN2xcFVJfW--